[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683822#comment-17683822
]
ZhangHB commented on HDFS-14795:
Hi, [~leosun08] . why do we do this desing : in stage of
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931887#comment-16931887
]
Íñigo Goiri commented on HDFS-14795:
Thanks [~leosun08] for the work.
Committed to trunk.
> Add
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931886#comment-16931886
]
Hudson commented on HDFS-14795:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17315 (See
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931833#comment-16931833
]
Íñigo Goiri commented on HDFS-14795:
+1 on [^HDFS-14795.012.patch].
> Add Throttler for writing
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931339#comment-16931339
]
Lisheng Sun commented on HDFS-14795:
hi [~elgoiri], should we commit this patch to trunk? Thank you.
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929634#comment-16929634
]
Lisheng Sun commented on HDFS-14795:
I confirmed all failed UTs are ok in local. So they are
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929361#comment-16929361
]
Íñigo Goiri commented on HDFS-14795:
The new test looks good.
Some of the failed unit tests aren't
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929291#comment-16929291
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929144#comment-16929144
]
Lisheng Sun commented on HDFS-14795:
Thanks [~elgoiri] for your good suggestion.
I added to check
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928737#comment-16928737
]
Íñigo Goiri commented on HDFS-14795:
[~leosun08], I think we should extend the tests to check that at
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928293#comment-16928293
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928082#comment-16928082
]
Íñigo Goiri commented on HDFS-14795:
Now I see where the docu description comes form. I would try to
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927940#comment-16927940
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927786#comment-16927786
]
Lisheng Sun commented on HDFS-14795:
Fixed the the problem in hdfs-default.xml and uploaded the v010
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927723#comment-16927723
]
Íñigo Goiri commented on HDFS-14795:
Just a minor comment: the capitalization in hdfs-default.xml is
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927290#comment-16927290
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927208#comment-16927208
]
Lisheng Sun commented on HDFS-14795:
Thanks [~elgoiri] for your suggestion.
I fixed the checkstyle
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927104#comment-16927104
]
Íñigo Goiri commented on HDFS-14795:
Let's fix the checkstyle and make the new methods static.
> Add
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926779#comment-16926779
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926671#comment-16926671
]
Lisheng Sun commented on HDFS-14795:
fixed checkstyle and uploaded the v008 patch.
> Add Throttler
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926653#comment-16926653
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926462#comment-16926462
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926347#comment-16926347
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925927#comment-16925927
]
Íñigo Goiri commented on HDFS-14795:
Thanks [~leosun08], I think this is more readable now.
For
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925230#comment-16925230
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925199#comment-16925199
]
Lisheng Sun commented on HDFS-14795:
Fixed checkstyle and uploaded the v004 patch.
> Add Throttler
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925156#comment-16925156
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925126#comment-16925126
]
Lisheng Sun commented on HDFS-14795:
hi [~elgoiri] I updated this patch and uploaded v003 patch.
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924697#comment-16924697
]
Lisheng Sun commented on HDFS-14795:
Thanks [~elgoiri] for good suggestions. I will update this patch
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924393#comment-16924393
]
Íñigo Goiri commented on HDFS-14795:
Thanks [~leosun08] for the patch.
In functionality, it looks
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924098#comment-16924098
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923926#comment-16923926
]
Hadoop QA commented on HDFS-14795:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920032#comment-16920032
]
Lisheng Sun commented on HDFS-14795:
hi [~elgoiri] I have finished this patch，but this patch depends
33 matches
Mail list logo
