[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934689#comment-16934689 ] Hudson commented on HDFS-14844: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17345 (See

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-20 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934670#comment-16934670 ] Íñigo Goiri commented on HDFS-14844: Thanks [~leosun08] for the patch. Committed to trunk. > Make

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-20 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934668#comment-16934668 ] Íñigo Goiri commented on HDFS-14844: This doesn't change any behavior. +1 on [^HDFS-14844.005.patch].

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-18 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932987#comment-16932987 ] Lisheng Sun commented on HDFS-14844: all failed UTs are ok in local. So they are unrelated to this

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-18 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932211#comment-16932211 ] Hadoop QA commented on HDFS-14844: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-17 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932013#comment-16932013 ] Lisheng Sun commented on HDFS-14844: [~elgoiri] I agree your option. And I confirmed all failed UTs

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931827#comment-16931827 ] Íñigo Goiri commented on HDFS-14844: The failed unit tests seem unrelated and I think this works. The

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-17 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931336#comment-16931336 ] Lisheng Sun commented on HDFS-14844: hi [~elgoiri], could you help continue to take a review? Thank

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929679#comment-16929679 ] Hadoop QA commented on HDFS-14844: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-13 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929638#comment-16929638 ] Lisheng Sun commented on HDFS-14844: Thanks [~elgoiri] for your deeply review. I updated the patch

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929495#comment-16929495 ] Íñigo Goiri commented on HDFS-14844: The description is much more clear now. Minor tune up: The

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929458#comment-16929458 ] Hadoop QA commented on HDFS-14844: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-13 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929318#comment-16929318 ] Lisheng Sun commented on HDFS-14844: uploaded the v003 patch. > Make buffer of

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-13 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929301#comment-16929301 ] Lisheng Sun commented on HDFS-14844: hi [~elgoiri] {quote} This is kind of a readahead buffer that

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-12 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928745#comment-16928745 ] Íñigo Goiri commented on HDFS-14844: The description is a little generic when saying "The buffer size

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-12 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928321#comment-16928321 ] Hadoop QA commented on HDFS-14844: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927919#comment-16927919 ] Hadoop QA commented on HDFS-14844: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14844) Make buffer of BlockReaderRemote#newBlockReader#BufferedOutputStream configurable

2019-09-11 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927721#comment-16927721 ] Íñigo Goiri commented on HDFS-14844: In my experience, dealing with all these buffer sizes and