[jira] [Commented] (HDFS-15019) Refactor the unit test of TestDeadNodeDetection

2019-11-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984183#comment-16984183 ] Hudson commented on HDFS-15019: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17707 (See

[jira] [Commented] (HDFS-15019) Refactor the unit test of TestDeadNodeDetection

2019-11-27 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984175#comment-16984175 ] Yiqun Lin commented on HDFS-15019: -- LGTM, +1. > Refactor the unit test of TestDeadNodeDetection >

[jira] [Commented] (HDFS-15019) Refactor the unit test of TestDeadNodeDetection

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984152#comment-16984152 ] Hadoop QA commented on HDFS-15019: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15019) Refactor the unit test of TestDeadNodeDetection

2019-11-27 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984089#comment-16984089 ] Lisheng Sun commented on HDFS-15019: Thanks  [~linyiqun] for your review. the v001 pathc refactors

[jira] [Commented] (HDFS-15019) Refactor the unit test of TestDeadNodeDetection

2019-11-27 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983619#comment-16983619 ] Yiqun Lin commented on HDFS-15019: -- We can put common setting in @Before method and leave specific