[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110393#comment-17110393
]
Hudson commented on HDFS-15207:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #18269 (See
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109303#comment-17109303
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108863#comment-17108863
]
Yang Yun commented on HDFS-15207:
-
Thanks [~weichiu] for the review.
Added the info to the
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108864#comment-17108864
]
Wei-Chiu Chuang commented on HDFS-15207:
+1 pending Jenkins.
> VolumeScanner skip to scan blocks
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108852#comment-17108852
]
Wei-Chiu Chuang commented on HDFS-15207:
Would you mind to add to the hdfs-default.xml that this
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108842#comment-17108842
]
Yang Yun commented on HDFS-15207:
-
if the atime is disabled, the atime will never change and keep the
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108790#comment-17108790
]
Wei-Chiu Chuang commented on HDFS-15207:
It just occurred to me that certain vendors (e.g.
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108778#comment-17108778
]
Yang Yun commented on HDFS-15207:
-
Thanks [~elgoiri] for the review, update to HDFS-15207.006.patch and
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108439#comment-17108439
]
Íñigo Goiri commented on HDFS-15207:
I was committing and I realized that we should not contract the
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106826#comment-17106826
]
Yang Yun commented on HDFS-15207:
-
Thanks [~elgoiri] [~weichiu] for the review.
Is this patch ready to
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077364#comment-17077364
]
Íñigo Goiri commented on HDFS-15207:
+1 on [^HDFS-15207.005.patch].
> VolumeScanner skip to scan
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076335#comment-17076335
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076191#comment-17076191
]
Yang Yun commented on HDFS-15207:
-
Thanks [~elgoiri] for the review.
Updated to HDFS-15207.005.patch
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075876#comment-17075876
]
Íñigo Goiri commented on HDFS-15207:
Is there something we can do for:
{quote}
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075219#comment-17075219
]
Wei-Chiu Chuang commented on HDFS-15207:
LGTM
> VolumeScanner skip to scan blocks accessed
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075213#comment-17075213
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075176#comment-17075176
]
Íñigo Goiri commented on HDFS-15207:
LamdaTestUtils with a wait inside is kind of weird, so I guess
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075161#comment-17075161
]
Yang Yun commented on HDFS-15207:
-
Thanks [~weichiu] and [~elgoiri] for the review.
Updated to new patch
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074984#comment-17074984
]
Íñigo Goiri commented on HDFS-15207:
Another thing, let's merge the else and the if as it makes it
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074851#comment-17074851
]
Wei-Chiu Chuang commented on HDFS-15207:
Patch makes sense tom me. Thanks for working on this
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055652#comment-17055652
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055590#comment-17055590
]
Yang Yun commented on HDFS-15207:
-
Thanks [~hexiaoqiao] for the suggestion.
Yes, the access time changes
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055576#comment-17055576
]
Xiaoqiao He commented on HDFS-15207:
Thanks [~hadoop_yangyun] for your works. This improvement seems
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1706#comment-1706
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055480#comment-17055480
]
Yang Yun commented on HDFS-15207:
-
Thanks [~elgoiri] for the review.
Simplified the test case. Please
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055211#comment-17055211
]
Íñigo Goiri commented on HDFS-15207:
A minor style comment, let's make the Thread a lambda too:
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054259#comment-17054259
]
Yang Yun commented on HDFS-15207:
-
One warning of checkstyle is for the Variable 'skipRecentAccessed',
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054109#comment-17054109
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054016#comment-17054016
]
Yang Yun commented on HDFS-15207:
-
Thanks [~elgoiri] for the review.
Got the lambda, thanks!
For the
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053670#comment-17053670
]
Íñigo Goiri commented on HDFS-15207:
Thanks [~hadoop_yangyun] for the update.
Can you number the
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053230#comment-17053230
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053082#comment-17053082
]
Yang Yun commented on HDFS-15207:
-
Thanks [~elgoiri] for the review.
Modified accoring to your comments.
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052447#comment-17052447
]
Íñigo Goiri commented on HDFS-15207:
I think this is good, let's improve the readability a little:
*
[
https://issues.apache.org/jira/browse/HDFS-15207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052337#comment-17052337
]
Hadoop QA commented on HDFS-15207:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
34 matches
Mail list logo
