[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149037#comment-17149037
]
Íñigo Goiri commented on HDFS-15410:
+1 on [^HDFS-15410.005.patch].
> Add separated config file
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148662#comment-17148662
]
Hadoop QA commented on HDFS-15410:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148609#comment-17148609
]
Jinglun commented on HDFS-15410:
Hi [~elgoiri], thanks your nice comments ! Rename
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147999#comment-17147999
]
Íñigo Goiri commented on HDFS-15410:
In addition to the keys, I was referring to calling the file:
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147742#comment-17147742
]
Yiqun Lin commented on HDFS-15410:
--
[~inigoiri], would you mind to have a quick review for this JIRA and
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147511#comment-17147511
]
Jinglun commented on HDFS-15410:
Hi [~linyiqun], shall we commit this ?:)
> Add separated config file
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142164#comment-17142164
]
Yiqun Lin commented on HDFS-15410:
--
LGTM , +1.
[~elgoiri], Does the latest patch also look good to you?
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142115#comment-17142115
]
Hadoop QA commented on HDFS-15410:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142048#comment-17142048
]
Jinglun commented on HDFS-15410:
Hi [~linyiqun], thanks your nice comments ! Add more description in
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141672#comment-17141672
]
Yiqun Lin commented on HDFS-15410:
--
[~LiJinglun], one minor comment: can you add more description for
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141132#comment-17141132
]
Hadoop QA commented on HDFS-15410:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141121#comment-17141121
]
Hadoop QA commented on HDFS-15410:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141109#comment-17141109
]
Jinglun commented on HDFS-15410:
Hi [~linyiqun], thanks your nice comments !
{quote}Not fully understand
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141104#comment-17141104
]
Jinglun commented on HDFS-15410:
Hi [~elgoiri], thanks your nice comments !
{quote}What about adding hdfs
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140960#comment-17140960
]
Yiqun Lin commented on HDFS-15410:
--
Besides [~elgoiri]'s review comment, some more reivew comments from
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140718#comment-17140718
]
Íñigo Goiri commented on HDFS-15410:
We can fix the checkstyle.
What about adding hdfs as a prefix
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140299#comment-17140299
]
Hadoop QA commented on HDFS-15410:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140240#comment-17140240
]
Jinglun commented on HDFS-15410:
Hi [~elgoiri], thanks your nice comments ! Refer the fedbalance-site.xml
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139961#comment-17139961
]
Íñigo Goiri commented on HDFS-15410:
I think we should refer to this in the documentation too.
> Add
[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139216#comment-17139216
]
Hadoop QA commented on HDFS-15410:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
