[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801818#comment-13801818 ] Hudson commented on HDFS-4885: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1586 (See [htt

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801729#comment-13801729 ] Hudson commented on HDFS-4885: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1560 (See [https://

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801708#comment-13801708 ] Hudson commented on HDFS-4885: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #370 (See [https://b

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801361#comment-13801361 ] Hudson commented on HDFS-4885: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4639 (See [https:

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801346#comment-13801346 ] Tsz Wo (Nicholas), SZE commented on HDFS-4885: -- Oops, I committed this to a wr

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801342#comment-13801342 ] Junping Du commented on HDFS-4885: -- Thanks Nicholas for review and comments! Yes. it seems

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801324#comment-13801324 ] Tsz Wo (Nicholas), SZE commented on HDFS-4885: -- > ... The failure in TestBalan

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801057#comment-13801057 ] Junping Du commented on HDFS-4885: -- Thanks Nicholas for review and re-launch jenkins tests

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800016#comment-13800016 ] Hadoop QA commented on HDFS-4885: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1373#comment-1373 ] Tsz Wo (Nicholas), SZE commented on HDFS-4885: -- I think the failure of TestBal

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799827#comment-13799827 ] Hadoop QA commented on HDFS-4885: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799731#comment-13799731 ] Hadoop QA commented on HDFS-4885: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799651#comment-13799651 ] Junping Du commented on HDFS-4885: -- Thanks Nicholas for carefully review. All comments her

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799572#comment-13799572 ] Tsz Wo (Nicholas), SZE commented on HDFS-4885: -- - In BlockPlacementStatusDefa

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799521#comment-13799521 ] Hadoop QA commented on HDFS-4885: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799381#comment-13799381 ] Junping Du commented on HDFS-4885: -- Sorry. the return value should be changed to BlockPlac

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799358#comment-13799358 ] Junping Du commented on HDFS-4885: -- Thanks Luke and Nicholas for comments! bq. More detail

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799334#comment-13799334 ] Tsz Wo (Nicholas), SZE commented on HDFS-4885: -- > Nicholas suggested offline t

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799324#comment-13799324 ] Luke Lu commented on HDFS-4885: --- Nicholas suggested offline that we simply pass in the replic

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783798#comment-13783798 ] Junping Du commented on HDFS-4885: -- Thanks Luke for review and suggestions. Hi [~szetszwo]

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783772#comment-13783772 ] Luke Lu commented on HDFS-4885: --- The v3 patch looks reasonable to me. We can deal with the ac

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783609#comment-13783609 ] Hadoop QA commented on HDFS-4885: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783528#comment-13783528 ] Junping Du commented on HDFS-4885: -- Thanks Luke for review and great comments! bq. I'd use

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783405#comment-13783405 ] Luke Lu commented on HDFS-4885: --- I posted the comment before refreshing to see the v2 patch,

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783252#comment-13783252 ] Hadoop QA commented on HDFS-4885: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783163#comment-13783163 ] Luke Lu commented on HDFS-4885: --- {{BlockPlacementStatus}} impls should just override toString

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782414#comment-13782414 ] Junping Du commented on HDFS-4885: -- Thanks Luke for suggestion here. That's definitely muc

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782099#comment-13782099 ] Luke Lu commented on HDFS-4885: --- I think this API change is problematic for several reasons:

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678333#comment-13678333 ] Hadoop QA commented on HDFS-4885: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677916#comment-13677916 ] Junping Du commented on HDFS-4885: -- As replica number is per file/directory property, and

[jira] [Commented] (HDFS-4885) Update verifyBlockPlacement() API in BlockPlacementPolicy

[ https://issues.apache.org/jira/browse/HDFS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677148#comment-13677148 ] Junping Du commented on HDFS-4885: -- Also, the parameter of minRacks doesn't make sense.