[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912980#comment-13912980
]
Hudson commented on HDFS-5939:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1710 (See
[htt
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912927#comment-13912927
]
Hudson commented on HDFS-5939:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1685 (See
[https://
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912768#comment-13912768
]
Hudson commented on HDFS-5939:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #493 (See
[https://b
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912053#comment-13912053
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Jing! and thanks Haohui, Tsz Wo and ATM a
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911877#comment-13911877
]
Hudson commented on HDFS-5939:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5223 (See
[https:
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911859#comment-13911859
]
Jing Zhao commented on HDFS-5939:
-
Thanks Yongjun. I will commit your patch shortly.
> Web
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911769#comment-13911769
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Haohui, would you please help committing
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911385#comment-13911385
]
Hadoop QA commented on HDFS-5939:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911294#comment-13911294
]
Haohui Mai commented on HDFS-5939:
--
+1
> WebHdfs returns misleading error code and logs n
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911254#comment-13911254
]
Yongjun Zhang commented on HDFS-5939:
-
Nice comments guys, I just uploaded a new versio
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911045#comment-13911045
]
Aaron T. Myers commented on HDFS-5939:
--
bq. You might want to remove this message as w
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911017#comment-13911017
]
Haohui Mai commented on HDFS-5939:
--
The patch mostly looks good. Three more minor issues:
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909252#comment-13909252
]
Hadoop QA commented on HDFS-5939:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909200#comment-13909200
]
Hadoop QA commented on HDFS-5939:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909176#comment-13909176
]
Yongjun Zhang commented on HDFS-5939:
-
Uploaded version 006 with the message printing r
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909084#comment-13909084
]
Yongjun Zhang commented on HDFS-5939:
-
Hi Haohui,
Thanks for your review earlier.
I g
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909010#comment-13909010
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks ATM for answering my question.
Hi Haohu
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909003#comment-13909003
]
Aaron T. Myers commented on HDFS-5939:
--
bq. On the other hand, I wonder if it's a bug
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909005#comment-13909005
]
Hadoop QA commented on HDFS-5939:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908986#comment-13908986
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Haohui for posting the code and ATM for t
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908966#comment-13908966
]
Aaron T. Myers commented on HDFS-5939:
--
bq. I'm not a big fan of verbose code. If you
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908958#comment-13908958
]
Haohui Mai commented on HDFS-5939:
--
bq. it's just one per test function, not too many. I
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908914#comment-13908914
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Haohui. I appreciate your diligence in re
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908857#comment-13908857
]
Haohui Mai commented on HDFS-5939:
--
bq. I on purposely added it, so in the log file for th
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908836#comment-13908836
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks [~wheat9] and [~szetszwo].
I just upload
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908730#comment-13908730
]
Tsz Wo (Nicholas), SZE commented on HDFS-5939:
--
{code}
+} catch (InvalidTo
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908708#comment-13908708
]
Haohui Mai commented on HDFS-5939:
--
The patch looks good. Some comments on the unit test:
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908083#comment-13908083
]
Yongjun Zhang commented on HDFS-5939:
-
Filed HDFS-5993 for the TestLoadGenerator failur
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908051#comment-13908051
]
Yongjun Zhang commented on HDFS-5939:
-
I think the two failed tests are irrelevant to t
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908027#comment-13908027
]
Hadoop QA commented on HDFS-5939:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907872#comment-13907872
]
Yongjun Zhang commented on HDFS-5939:
-
Hi Haohui and Tsz,
Thanks a lot for your earli
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907661#comment-13907661
]
Tsz Wo (Nicholas), SZE commented on HDFS-5939:
--
Users won't see the log. I th
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907640#comment-13907640
]
Yongjun Zhang commented on HDFS-5939:
-
HI Haohui.
At least we got a report from the f
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907615#comment-13907615
]
Haohui Mai commented on HDFS-5939:
--
bq. The case reported in this bug is about no datanode
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907609#comment-13907609
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Haohui. Good info.
All looks good to me,
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907373#comment-13907373
]
Haohui Mai commented on HDFS-5939:
--
bq. But thinking about it a bit more, why can't we als
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907308#comment-13907308
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Haohui.
I had one thought, I wonder why
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907277#comment-13907277
]
Haohui Mai commented on HDFS-5939:
--
{code}
+ LOG.error(" Caught InvalidTopologyExcept
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906776#comment-13906776
]
Hadoop QA commented on HDFS-5939:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906645#comment-13906645
]
Yongjun Zhang commented on HDFS-5939:
-
Hi Guys,
I just uploaded a new version to addre
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906406#comment-13906406
]
Yongjun Zhang commented on HDFS-5939:
-
HI [~szetszwo],
Sounds good to me, I will work
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906372#comment-13906372
]
Tsz Wo (Nicholas), SZE commented on HDFS-5939:
--
Conditions (C0) scope.startsWi
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906309#comment-13906309
]
Yongjun Zhang commented on HDFS-5939:
-
Hi [~szetszwo], thanks for looking at it further
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906230#comment-13906230
]
Tsz Wo (Nicholas), SZE commented on HDFS-5939:
--
> ... So (1) it never excludes
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906172#comment-13906172
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks [~wheat9] and [~szetszwo].
Based on your
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906120#comment-13906120
]
Tsz Wo (Nicholas), SZE commented on HDFS-5939:
--
In chooseRandom(..), excludedS
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905909#comment-13905909
]
Haohui Mai commented on HDFS-5939:
--
Two questions. {{In NetworkTopology}}:
# Under what c
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905606#comment-13905606
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks Haohui.
Indeed, the contract of Random.n
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905057#comment-13905057
]
Haohui Mai commented on HDFS-5939:
--
{code}
+if (numOfDatanodes == 0) {
+ return n
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905028#comment-13905028
]
Yongjun Zhang commented on HDFS-5939:
-
FYI Haohui, this function originally already has
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904989#comment-13904989
]
Yongjun Zhang commented on HDFS-5939:
-
BTW Haohui, would you please help committing thi
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904962#comment-13904962
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks a lot Haohui! I created jira (HDFS-5970)
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904460#comment-13904460
]
Haohui Mai commented on HDFS-5939:
--
{code}
@@ -712,6 +712,9 @@ private Node chooseRandom(S
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900990#comment-13900990
]
Hadoop QA commented on HDFS-5939:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900767#comment-13900767
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks!
> WebHdfs returns misleading error cod
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900765#comment-13900765
]
Haohui Mai commented on HDFS-5939:
--
I'll try to take a look at it in the following days.
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900755#comment-13900755
]
Yongjun Zhang commented on HDFS-5939:
-
HI [~wheat9],
I looked closer at HDFS-5891, wh
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900731#comment-13900731
]
Yongjun Zhang commented on HDFS-5939:
-
Thanks [~wheat9], I tired it and it doesn't solv
[
https://issues.apache.org/jira/browse/HDFS-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899499#comment-13899499
]
Haohui Mai commented on HDFS-5939:
--
Can you try whether HDFS-5891 fix this issue?
> WebHd
59 matches
Mail list logo