[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-07 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045809#comment-15045809 ] Jing Zhao commented on HDFS-9129: - +1 for the branch-2 patch. I've committed it into branch-2 as well. >

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-07 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045815#comment-15045815 ] Mingliang Liu commented on HDFS-9129: - Thanks for review and commit the {{branch-2}} patch,

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045842#comment-15045842 ] Hudson commented on HDFS-9129: -- FAILURE: Integrated in Hadoop-trunk-Commit #8936 (See

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046155#comment-15046155 ] Hudson commented on HDFS-9129: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #674 (See

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038621#comment-15038621 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036772#comment-15036772 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-02 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036894#comment-15036894 ] Mingliang Liu commented on HDFS-9129: - {noformat} Step 16 : RUN cd /usr/share/maven/lib && ln -s

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034991#comment-15034991 ] Hudson commented on HDFS-9129: -- SUCCESS: Integrated in Hadoop-trunk-Commit #8908 (See

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-01 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034932#comment-15034932 ] Jing Zhao commented on HDFS-9129: - The 025 patch looks good to me. +1. I will commit it first to trunk. >

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-12-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035299#comment-15035299 ] Hudson commented on HDFS-9129: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #656 (See

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-30 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032643#comment-15032643 ] Jing Zhao commented on HDFS-9129: - The latest patch looks pretty good to me. The only minor comment is the

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-30 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033170#comment-15033170 ] Mingliang Liu commented on HDFS-9129: - The _javac_ (both 1.7 and 1.8), _checkstyle_ and _asf license

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033162#comment-15033162 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028213#comment-15028213 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001372#comment-15001372 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1430#comment-1430 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994706#comment-14994706 ] Jing Zhao commented on HDFS-9129: - The latest patch looks good to me overall. Here're my comments: # Let's

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991106#comment-14991106 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989166#comment-14989166 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987196#comment-14987196 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986097#comment-14986097 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-11-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986435#comment-14986435 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983695#comment-14983695 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980137#comment-14980137 ] Hadoop QA commented on HDFS-9129: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976176#comment-14976176 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-26 Thread Anu Engineer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975016#comment-14975016 ] Anu Engineer commented on HDFS-9129: [~liuml07] Thanks for adding me to this review. It looks like the

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-26 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975703#comment-14975703 ] Mingliang Liu commented on HDFS-9129: - Thanks to [~anu] for the review and comment. Anu and I are

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972490#comment-14972490 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-23 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971490#comment-14971490 ] Haohui Mai commented on HDFS-9129: -- {code} + * The state machine is briefly elaborated in the following

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-23 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970512#comment-14970512 ] Mingliang Liu commented on HDFS-9129: - The failing tests can pass locally (Linux and Mac), and seem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968644#comment-14968644 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968827#comment-14968827 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-22 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970332#comment-14970332 ] Mingliang Liu commented on HDFS-9129: - s/this/v9 > Move the safemode block count into BlockManager >

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970455#comment-14970455 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-21 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967881#comment-14967881 ] Haohui Mai commented on HDFS-9129: -- Thanks for the work, [~liuml07] {code} +if (status ==

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961801#comment-14961801 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-16 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961110#comment-14961110 ] Mingliang Liu commented on HDFS-9129: - The failing tests can pass locally. Addressing the findbugs and

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960263#comment-14960263 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960230#comment-14960230 ] Jing Zhao commented on HDFS-9129: - Thanks for the work, Mingliang! Glad to hear that finally we're allowed

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960018#comment-14960018 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959556#comment-14959556 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948482#comment-14948482 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-07 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947444#comment-14947444 ] Daryn Sharp commented on HDFS-9129: --- Very close to a prototype I was working on. To save some reviewing

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945578#comment-14945578 ] Jing Zhao commented on HDFS-9129: - The patch looks good overall. Some early comments: # The jira currently

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944594#comment-14944594 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9129) Move the safemode block count into BlockManager

2015-10-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943189#comment-14943189 ] Hadoop QA commented on HDFS-9129: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem