[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565639#comment-15565639 ] Mehran Hassani commented on HDFS-9618: -- That make sense ;), Thanks! > Fix mismatch between log level

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564882#comment-15564882 ] Akira Ajisaka commented on HDFS-9618: - In the following code, isDebugEnabled is necessary because we

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556346#comment-15556346 ] Mehran Hassani commented on HDFS-9618: -- Correct me if I am wrong but I think self4j checks for all the

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111873#comment-15111873 ] Hadoop QA commented on HDFS-9618: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111947#comment-15111947 ] Hudson commented on HDFS-9618: -- FAILURE: Integrated in Hadoop-trunk-Commit #9160 (See

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110033#comment-15110033 ] Akira AJISAKA commented on HDFS-9618: - Mostly looks good to me. Would you join the following two if

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085335#comment-15085335 ] Masatake Iwasaki commented on HDFS-9618: The log level had been info but it seemed to be changed to

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085324#comment-15085324 ] Masatake Iwasaki commented on HDFS-9618: {code} if (blockLog.isInfoEnabled()) { // log

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085371#comment-15085371 ] Kai Zheng commented on HDFS-9618: - Good catch! The pattern to use {{logger.isInfoEnabled}} shouldn't be

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086043#comment-15086043 ] Mingliang Liu commented on HDFS-9618: - Thanks for working on this, [~iwasakims]i]. Calling

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086050#comment-15086050 ] Mingliang Liu commented on HDFS-9618: - We have 5 levels of priority queues and the aggregation should

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086063#comment-15086063 ] Mingliang Liu commented on HDFS-9618: - +1 (non-binding) > Fix mismatch between log level and guard in

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085978#comment-15085978 ] Masatake Iwasaki commented on HDFS-9618: This was wrong. The log level was changed by HDFS-6860. >

[jira] [Commented] (HDFS-9618) Fix mismatch between log level and guard in BlockManager#computeRecoveryWorkForBlocks

[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086271#comment-15086271 ] Hadoop QA commented on HDFS-9618: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||