[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048215#comment-13048215 ] Todd Lipcon commented on HDFS-988: -- +1 on the trunk patch, once you've run the full test su

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048213#comment-13048213 ] Todd Lipcon commented on HDFS-988: -- +1 on the 0.22 patch > saveNamespace can corrupt edits

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046397#comment-13046397 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046389#comment-13046389 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046369#comment-13046369 ] Eli Collins commented on HDFS-988: -- Btw test-patch is +1 for hdfs-988-b22-1.patch on branch

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042615#comment-13042615 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042600#comment-13042600 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042591#comment-13042591 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042445#comment-13042445 ] Eli Collins commented on HDFS-988: -- ELOS#flush calls ELFOS#flushAndSync which does a force

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042432#comment-13042432 ] Bharath Mundlapudi commented on HDFS-988: - I am just wondering, if we are calling os

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042351#comment-13042351 ] Eli Collins commented on HDFS-988: -- It looks like most of the unprotected* methods take the

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041962#comment-13041962 ] dhruba borthakur commented on HDFS-988: --- we should not logSync after a nextGenerationS

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log, apparently due to race conditions

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041934#comment-13041934 ] Todd Lipcon commented on HDFS-988: -- Didn't go through the new tests yet, but here are some

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035690#comment-13035690 ] Matt Foley commented on HDFS-988: - Out of the seven test failures, the only one that might h

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035653#comment-13035653 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035233#comment-13035233 ] dhruba borthakur commented on HDFS-988: --- yes, they should all be using RWLock, absolut

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035201#comment-13035201 ] Todd Lipcon commented on HDFS-988: -- Looking at trunk I see a lot of other strange synchroni

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029803#comment-13029803 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest att

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029783#comment-13029783 ] dhruba borthakur commented on HDFS-988: --- 1. we should not throw an exception is unable

[jira] [Commented] (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017997#comment-13017997 ] Nigel Daley commented on HDFS-988: -- Todd, any update on this for 0.22? > saveNamespace can

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884403#action_12884403 ] dhruba borthakur commented on HDFS-988: --- It is not a easily repeatable scenario: it is

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884380#action_12884380 ] Brahma Reddy Battula commented on HDFS-988: --- hi dhruba borthakur , I am using the

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880597#action_12880597 ] dhruba borthakur commented on HDFS-988: --- hi todd, would appreciate it if u can write so

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876798#action_12876798 ] Todd Lipcon commented on HDFS-988: -- Nicolas: by seqnum you're referring to the generation st

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866081#action_12866081 ] dhruba borthakur commented on HDFS-988: --- Code looks excellent. can we add a unit test t

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866070#action_12866070 ] Todd Lipcon commented on HDFS-988: -- dhruba, can you take a look at this blocker please? > s

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862838#action_12862838 ] Todd Lipcon commented on HDFS-988: -- The failed test is unrelated (been failing all patch bui

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861756#action_12861756 ] Hadoop QA commented on HDFS-988: -1 overall. Here are the results of testing the latest atta

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860918#action_12860918 ] Todd Lipcon commented on HDFS-988: -- Hey Dhruba, yep, I am planning on doing this this week s

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860870#action_12860870 ] dhruba borthakur commented on HDFS-988: --- Hi todd, is it possible to make this one into

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856961#action_12856961 ] Todd Lipcon commented on HDFS-988: -- Once HDFS-909 is committed I'll rebase this on trunk and

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837060#action_12837060 ] Konstantin Shvachko commented on HDFS-988: -- # {{enterSafeMode()}} looks good. # {{FS

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836021#action_12836021 ] Todd Lipcon commented on HDFS-988: -- Hi Dhruba, I still think we should fix this in the othe

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835488#action_12835488 ] Todd Lipcon commented on HDFS-988: -- HDFS-909's fixes cover two issues. One of the two is in

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835486#action_12835486 ] dhruba borthakur commented on HDFS-988: --- I agree that HDFS-956 could be fixed. But HDFS

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835472#action_12835472 ] Todd Lipcon commented on HDFS-988: -- Does this need to be a separate JIRA from HDFS-909? This

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835406#action_12835406 ] dhruba borthakur commented on HDFS-988: --- I think the wait time is theoretically unbound

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835402#action_12835402 ] Brian Bockelman commented on HDFS-988: -- How long can logSyncs be pending for? Is this c

[jira] Commented: (HDFS-988) saveNamespace can corrupt edits log

[ https://issues.apache.org/jira/browse/HDFS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835403#action_12835403 ] dhruba borthakur commented on HDFS-988: --- My proposal is to make the enterSafeMode metho