[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994089#comment-16994089
]
Xieming Li commented on HDFS-14983:
---
[~tasanuma][~inigoiri]
Thank you for your review.
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994084#comment-16994084
]
Hudson commented on HDFS-14983:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17754 (See
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994068#comment-16994068
]
Takanobu Asanuma commented on HDFS-14983:
-
[~elgoiri] Thanks for your review. Will commit it
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993915#comment-16993915
]
Íñigo Goiri commented on HDFS-14983:
+1 on [^HDFS-14983.006.patch].
> RBF: Add dfsrouteradmin
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993450#comment-16993450
]
Hadoop QA commented on HDFS-14983:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993320#comment-16993320
]
Takanobu Asanuma commented on HDFS-14983:
-
Created HDFS-15048 for the findbug.
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993305#comment-16993305
]
Takanobu Asanuma commented on HDFS-14983:
-
Thanks for updating the patch, [~risyomei] .
* Seems
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993255#comment-16993255
]
Hadoop QA commented on HDFS-14983:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993174#comment-16993174
]
Xieming Li commented on HDFS-14983:
---
[~tasanuma],
Thank you for your review.
I have posted a new
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992496#comment-16992496
]
Takanobu Asanuma commented on HDFS-14983:
-
Thanks for working on this, [~risyomei]. The 004 patch
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992412#comment-16992412
]
Hadoop QA commented on HDFS-14983:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992259#comment-16992259
]
Xieming Li commented on HDFS-14983:
---
[~inigoiri], Thank you for your review.
I have fixed that
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991984#comment-16991984
]
Íñigo Goiri commented on HDFS-14983:
For the checkstyle warning you can break the line in
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991112#comment-16991112
]
Xieming Li commented on HDFS-14983:
---
I think those errors are irrelevant to my changes except for that
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990421#comment-16990421
]
Hadoop QA commented on HDFS-14983:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990369#comment-16990369
]
Xieming Li commented on HDFS-14983:
---
HI, [~elgoiri], thank you for your prompt response.
I have fixed
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990129#comment-16990129
]
Íñigo Goiri commented on HDFS-14983:
Thanks [~risyomei], minor comments:
* Add break line between the
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989817#comment-16989817
]
Hadoop QA commented on HDFS-14983:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989634#comment-16989634
]
Xieming Li commented on HDFS-14983:
---
I have added documentation, javadoc, and a unit test.
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988363#comment-16988363
]
Xieming Li commented on HDFS-14983:
---
[~elgoiri]
Thank you for your fedback!
It took a little while
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988060#comment-16988060
]
Íñigo Goiri commented on HDFS-14983:
Thanks [~risyomei] for the proposal.
Yes, I think this is it.
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987635#comment-16987635
]
Hadoop QA commented on HDFS-14983:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987567#comment-16987567
]
Xieming Li commented on HDFS-14983:
---
I have uploaded a patch that works, and I hope to get some
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976130#comment-16976130
]
Ayush Saxena commented on HDFS-14983:
-
Thanx [~aajisaka] for the report. Indeed That is something
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973862#comment-16973862
]
Íñigo Goiri commented on HDFS-14983:
[~aajisaka], true, that's missing.
> RBF: Add dfsrouteradmin
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973855#comment-16973855
]
Akira Ajisaka commented on HDFS-14983:
--
HDFS-14545 is to refresh the configs of the NameNodes via
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973613#comment-16973613
]
Íñigo Goiri commented on HDFS-14983:
It might be missing in the dfsrouteradmin though.
You could use
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973612#comment-16973612
]
Íñigo Goiri commented on HDFS-14983:
Isn't this done by HDFS-14545?
> RBF: Add dfsrouteradmin
[
https://issues.apache.org/jira/browse/HDFS-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973036#comment-16973036
]
Akira Ajisaka commented on HDFS-14983:
--
The cost of restarting DFSRouter is much lower than
29 matches
Mail list logo
