[jira] [Commented] (HDDS-1497) Refactor blockade Tests
[ https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851989#comment-16851989 ] Hudson commented on HDDS-1497: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16631 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16631/]) HDDS-1497. Refactor blockade Tests. Contributed by Nilotpal Nandi. (elek: rev 1b041d4fd4ec0c8c4cfdcd6fa28711cf7fcd56fe) * (add) hadoop-ozone/dist/src/main/blockade/ozone/cluster.py * (edit) hadoop-ozone/dist/src/main/blockade/clusterUtils/cluster_utils.py * (add) hadoop-ozone/dist/src/main/blockade/ozone/__init__.py * (edit) hadoop-ozone/dist/src/main/blockade/test_blockade_datanode_isolation.py * (edit) hadoop-ozone/dist/src/main/blockade/test_blockade_flaky.py * (edit) hadoop-ozone/dist/src/main/blockade/blockadeUtils/blockade.py * (add) hadoop-ozone/dist/src/main/blockade/util.py * (edit) hadoop-ozone/dist/src/main/compose/ozoneblockade/docker-config * (edit) hadoop-ozone/dist/src/main/blockade/clusterUtils/__init__.py > Refactor blockade Tests > --- > > Key: HDDS-1497 > URL: https://issues.apache.org/jira/browse/HDDS-1497 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nilotpal Nandi >Assignee: Nilotpal Nandi >Priority: Major > Attachments: HDDS-1497.001.patch, HDDS-1497.002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-1497) Refactor blockade Tests
[ https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851953#comment-16851953 ] Elek, Marton commented on HDDS-1497: +1 It looks good to me. Will commit it soon. I can start locally the tests without any problem but it takes a lot of time to run all of them (and sometimes some of them failing for me). Not related to this patch, but I am planning to run a nightly blockade test to get regular data about the current status. We can also run them parallel in a k8s cluster. > Refactor blockade Tests > --- > > Key: HDDS-1497 > URL: https://issues.apache.org/jira/browse/HDDS-1497 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nilotpal Nandi >Assignee: Nilotpal Nandi >Priority: Major > Attachments: HDDS-1497.001.patch, HDDS-1497.002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-1497) Refactor blockade Tests
[
https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850953#comment-16850953
]
Hadoop QA commented on HDDS-1497:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
0s{color} | {color:green} trunk passed {color} |
| {color:orange}-0{color} | {color:orange} pylint {color} | {color:orange} 0m
2s{color} | {color:orange} Error running pylint. Please check pylint stderr
files. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 57s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
46s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} pylint {color} | {color:orange} 0m
5s{color} | {color:orange} Error running pylint. Please check pylint stderr
files. {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
5s{color} | {color:green} There were no new pylint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 27s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
36s{color} | {color:green} hadoop-hdds in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 56s{color}
| {color:red} hadoop-ozone in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.TestMiniOzoneCluster |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HDDS-Build/2714/artifact/out/Dockerfile
|
| JIRA Issue | HDDS-1497 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970178/HDDS-1497.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient pylint shellcheck shelldocs |
| uname | Linux 72049325d991 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
[jira] [Commented] (HDDS-1497) Refactor blockade Tests
[ https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850826#comment-16850826 ] Nilotpal Nandi commented on HDDS-1497: -- Thanks [~shashikant] for review . I have addressed your comments . Here are inline comments : 1. Please update comments for property, getter and setter functions. - done 2.cluster.py:223-224 : > incorrect comments. - done 3. clusterUtils.py:324 -> "om_1" should be "om"? - This should work fine with 'om_1" too. "om_1" string is present in om's container name. 4.cluster_utils.py:296 -> which file checksum is it supposed to compute ? can you please update the comments? - done > Refactor blockade Tests > --- > > Key: HDDS-1497 > URL: https://issues.apache.org/jira/browse/HDDS-1497 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nilotpal Nandi >Assignee: Nilotpal Nandi >Priority: Major > Attachments: HDDS-1497.001.patch, HDDS-1497.002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-1497) Refactor blockade Tests
[ https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844870#comment-16844870 ] Shashikant Banerjee commented on HDDS-1497: --- Thanks [~nilotpalnandi] for working on this. Some comments inline: 1. Please update comments for property, getter and setter functions. 2.cluster.py:223-224 : > incorrect comments. 3. clusterUtils.py:324 -> "om_1" should be "om"? 4.cluster_utils.py:296 -> which file checksum is it supposed to compute ? can you please update the comments? > Refactor blockade Tests > --- > > Key: HDDS-1497 > URL: https://issues.apache.org/jira/browse/HDDS-1497 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Nilotpal Nandi >Assignee: Nilotpal Nandi >Priority: Major > Attachments: HDDS-1497.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDDS-1497) Refactor blockade Tests
[
https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840502#comment-16840502
]
Hadoop QA commented on HDDS-1497:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} yetus {color} | {color:red} 0m 7s{color}
| {color:red} Unprocessed flag(s): --jenkins --skip-dir {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HDDS-Build/2692/artifact/out/Dockerfile
|
| JIRA Issue | HDDS-1497 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12968807/HDDS-1497.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/2692/console |
| versions | git=2.7.4 |
| Powered by | Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Refactor blockade Tests
> ---
>
> Key: HDDS-1497
> URL: https://issues.apache.org/jira/browse/HDDS-1497
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Nilotpal Nandi
>Assignee: Nilotpal Nandi
>Priority: Major
> Attachments: HDDS-1497.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
