[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-02 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461579#comment-16461579
 ] 

Hudson commented on HDDS-15:


SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14114 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14114/])
HDDS-15. Add memory profiler support to Genesis. Contributed by Anu (aengineer: 
rev 6b63a0af9b29c231166d9af50d499a246cbbb755)
* (edit) 
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genesis/Genesis.java
* (add) 
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genesis/GenesisMemoryProfiler.java


> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch, HDDS-15.002.patch, HDDS-15.003.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-02 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461310#comment-16461310
 ] 

Anu Engineer commented on HDDS-15:
--

[~xyao] Thanks for the reviews. I had added the Lic and got a clean Jenkins 
build. I will commit this patch now.

> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch, HDDS-15.002.patch, HDDS-15.003.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460470#comment-16460470
 ] 

genericqa commented on HDDS-15:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 30s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
35s{color} | {color:red} hadoop-ozone/tools in trunk has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 52s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
22s{color} | {color:green} tools in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
25s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 51s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-15 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921514/HDDS-15.003.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 0b9c2a610db6 4.4.0-121-generic #145-Ubuntu SMP Fri Apr 13 
13:47:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 8f42daf |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/22/artifact/out/branch-findbugs-hadoop-ozone_tools-warnings.html
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/22/testReport/ |
| Max. process+thread count | 410 (vs. ulimit of 1) |
| modules | C: hadoop-ozone/tools U: hadoop-ozone/tools |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/22/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460343#comment-16460343
 ] 

Anu Engineer commented on HDDS-15:
--

Patch - 3 adds the Lic to the new file.

> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch, HDDS-15.002.patch, HDDS-15.003.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460334#comment-16460334
 ] 

genericqa commented on HDDS-15:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 46s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
53s{color} | {color:red} hadoop-ozone/tools in trunk has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 41s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
21s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
27s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 59s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-15 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921479/HDDS-15.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 077ee75b9c33 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 8f42daf |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/20/artifact/out/branch-findbugs-hadoop-ozone_tools-warnings.html
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/20/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDDS-Build/20/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 335 (vs. ulimit of 1) |
| modules | C: hadoop-ozone/tools U: hadoop-ozone/tools |
| Console output |

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460327#comment-16460327
 ] 

Xiaoyu Yao commented on HDDS-15:


Can you add ASF license for GenesisMemoryProfiler.java? +1 after that.

> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch, HDDS-15.002.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460286#comment-16460286
 ] 

genericqa commented on HDDS-15:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m 
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 46s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
34s{color} | {color:red} hadoop-ozone/tools in trunk has 2 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 36s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
21s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
22s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 51s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-15 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921461/HDDS-15.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 79df63c2e391 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 8f42daf |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDDS-Build/19/artifact/out/branch-findbugs-hadoop-ozone_tools-warnings.html
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/19/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDDS-Build/19/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 289 (vs. ulimit of 1) |
| modules | C: hadoop-ozone/tools U: hadoop-ozone/tools |
| Console output |

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460245#comment-16460245
 ] 

Anu Engineer commented on HDDS-15:
--

[~xyao] Patch 2 addresses all the comments.

> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch, HDDS-15.002.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460220#comment-16460220
 ] 

Anu Engineer commented on HDDS-15:
--

Good catch, will fix both of these. Thanks for the review.

 

> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread Xiaoyu Yao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460217#comment-16460217
 ] 

Xiaoyu Yao commented on HDDS-15:


Patch looks good to me overall. Just two minor issues:

 

Genesis.java

Line 47: NIT: the ident/format needs to be adjusted after the comment.

 

GenesisMemoryProfiler.java

Line 28: should we sample to get the max used heap instead of total heap that 
includes both used and free?

long usedHeap = Runtime.getRuntime().totalMemory() - 
Runtime.getRuntime().freeMemory();

> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-15) Add memory profiler support to Genesis

2018-05-01 Thread Anu Engineer (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDDS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460169#comment-16460169
 ] 

Anu Engineer commented on HDDS-15:
--

With this patch the when you run Genesis, you will not only see the throughput, 
but also max used heap.

||Benchmark ||  
||Mode||  Cnt  || Score  ||   Error ||  Units||
|BenchMarkContainerStateMap.createContainerBenchMark |   thrpt|   
20|   49619.749| ±   14707.387|  ops/s|
|BenchMarkContainerStateMap.createContainerBenchMark:Max heap|   thrpt|   
20| | 2718433280.000 | |   bytes|
|BenchMarkContainerStateMap.getMatchingContainerBenchMark|   thrpt|   
20|24774461.267| ± 1074973.613|  ops/s|
|BenchMarkContainerStateMap.getMatchingContainerBenchMark:Max heap|  thrpt |   
20 |   350224384.000| |bytes|





> Add memory profiler support to Genesis
> --
>
> Key: HDDS-15
> URL: https://issues.apache.org/jira/browse/HDDS-15
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: Tools
>Affects Versions: 0.2.1
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-15.001.patch
>
>
> Add the ability to sample max memory usage when running tests under Genesis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org