[jira] [Commented] (HDDS-160) Refactor KeyManager, ChunkManager

2018-07-09 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537580#comment-16537580
 ] 

Hudson commented on HDDS-160:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14547 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14547/])
HDDS-160:Refactor KeyManager, ChunkManager. Contributed by Bharat (bharat: rev 
ca192cb7c9d76163391e88461716938fdb41c4d3)
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/ChunkManagerImpl.java
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/interfaces/KeyManager.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/ChunkManager.java
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyManagerImpl.java
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/ChunkUtils.java
* (add) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/interfaces/ChunkManager.java
* (add) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestChunkManagerImpl.java
* (edit) 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyUtils.java
* (add) 
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyManagerImpl.java


> Refactor KeyManager, ChunkManager
> -
>
> Key: HDDS-160
> URL: https://issues.apache.org/jira/browse/HDDS-160
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-160-HDDS-48.01.patch
>
>
> This Jira is to add new Interface ChunkManager and KeyManager to perform Key 
> and Chunk related operations.
>  # Changes to current existing Keymanager and ChunkManager are:
>  ## Removal of usage of ContainerManager.
>  ## Passing container to method calls.
>  ## Using layOutversion during reading/deleting chunk files.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-160) Refactor KeyManager, ChunkManager

2018-06-15 Thread Hanisha Koneru (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514376#comment-16514376
 ] 

Hanisha Koneru commented on HDDS-160:
-

Ok sure. Go ahead. +1.

> Refactor KeyManager, ChunkManager
> -
>
> Key: HDDS-160
> URL: https://issues.apache.org/jira/browse/HDDS-160
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-160-HDDS-48.01.patch
>
>
> This Jira is to add new Interface ChunkManager and KeyManager to perform Key 
> and Chunk related operations.
>  # Changes to current existing Keymanager and ChunkManager are:
>  ## Removal of usage of ContainerManager.
>  ## Passing container to method calls.
>  ## Using layOutversion during reading/deleting chunk files.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-160) Refactor KeyManager, ChunkManager

2018-06-15 Thread Bharat Viswanadham (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514375#comment-16514375
 ] 

Bharat Viswanadham commented on HDDS-160:
-

Hi [~hanishakoneru]

Thanks for the review.

The test code is being changed again in HDDS-169. I will address them when 
posting a patch for it.

 

> Refactor KeyManager, ChunkManager
> -
>
> Key: HDDS-160
> URL: https://issues.apache.org/jira/browse/HDDS-160
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-160-HDDS-48.01.patch
>
>
> This Jira is to add new Interface ChunkManager and KeyManager to perform Key 
> and Chunk related operations.
>  # Changes to current existing Keymanager and ChunkManager are:
>  ## Removal of usage of ContainerManager.
>  ## Passing container to method calls.
>  ## Using layOutversion during reading/deleting chunk files.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-160) Refactor KeyManager, ChunkManager

2018-06-15 Thread Hanisha Koneru (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514347#comment-16514347
 ] 

Hanisha Koneru commented on HDDS-160:
-

Thanks for the patch [~bharatviswa].

Few minor comments:
# testWriteChunkStageWriteAndCommit -> Can we check that the WRITE_DATA creates 
a temporary file and COMMIT_DATA renames it to final file.
# testWriteChunkStageCombinedData -> Line 159-160, COMBINED_DATA doesn’t create 
a temporary file.
# testWriteChunkChecksumMismatch -> chunkList is not used.
# testDeleteKey -> after deleteKey, can we versify that the key is deleted by 
calling getKey.

> Refactor KeyManager, ChunkManager
> -
>
> Key: HDDS-160
> URL: https://issues.apache.org/jira/browse/HDDS-160
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-160-HDDS-48.01.patch
>
>
> This Jira is to add new Interface ChunkManager and KeyManager to perform Key 
> and Chunk related operations.
>  # Changes to current existing Keymanager and ChunkManager are:
>  ## Removal of usage of ContainerManager.
>  ## Passing container to method calls.
>  ## Using layOutversion during reading/deleting chunk files.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-160) Refactor KeyManager, ChunkManager

2018-06-14 Thread genericqa (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1651#comment-1651
 ] 

genericqa commented on HDDS-160:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 
 5s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
28s{color} | {color:green} HDDS-48 passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red}  2m 
55s{color} | {color:red} branch has errors when building and testing our client 
artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
41s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red}  2m 
18s{color} | {color:red} patch has errors when building and testing our client 
artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
49s{color} | {color:green} container-service in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
21s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m  0s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-160 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12927898/HDDS-160-HDDS-48.01.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 7c79cd6a7357 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / 998e285 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDDS-Build/316/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDDS-Build/316/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 206 (vs. ulimit of 1) |
| modules | C: hadoop-hdds/container-service U: hadoop-hdds/container-service |
| Console output | 
https://builds.apache.org/job/PreCommit-HDDS-Build/316/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Refactor KeyManager, ChunkManager
> -
>
> 

[jira] [Commented] (HDDS-160) Refactor KeyManager, ChunkManager

2018-06-14 Thread Bharat Viswanadham (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512914#comment-16512914
 ] 

Bharat Viswanadham commented on HDDS-160:
-

This patch is dependant on HDDS-155 and HDDS-156.

> Refactor KeyManager, ChunkManager
> -
>
> Key: HDDS-160
> URL: https://issues.apache.org/jira/browse/HDDS-160
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Attachments: HDDS-160-HDDS-48.00.patch
>
>
> This Jira is to add new Interface ChunkManager and KeyManager to perform Key 
> and Chunk related operations.
>  # Changes to current existing Keymanager and ChunkManager are:
>  ## Removal of usage of ContainerManager.
>  ## Passing container to method calls.
>  ## Using layOutversion during reading/deleting chunk files.
> Add a new Class KeyValueManager to implement ContainerManager.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org