[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-18 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480962#comment-16480962 ] Bharat Viswanadham commented on HDDS-76: Thank You [~shashikant] for info. Will look into HDDS-87.

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-18 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480949#comment-16480949 ] Shashikant Banerjee commented on HDDS-76: - The tests have been fixed with HDDS-87. > Modify

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-18 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480945#comment-16480945 ] Bharat Viswanadham commented on HDDS-76: I think this has caused some test failures in

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480377#comment-16480377 ] Hudson commented on HDDS-76: SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14236 (See

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480184#comment-16480184 ] Mukul Kumar Singh commented on HDDS-76: --- +1, the patch looks good to me as well. I will commit this

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480061#comment-16480061 ] Bharat Viswanadham commented on HDDS-76: Thank You [~shashikant] for info. +1 LGTM. > Modify

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479981#comment-16479981 ] Shashikant Banerjee commented on HDDS-76: - Thanks [~bharatviswa] for the reviews.  1) Yes, the patch

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479846#comment-16479846 ] Bharat Viswanadham commented on HDDS-76: Patch LGTM. Few questions: # Will this patch have

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478893#comment-16478893 ] genericqa commented on HDDS-76: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478815#comment-16478815 ] Shashikant Banerjee commented on HDDS-76: - Thanks [~msingh], for the review. Patch v1 addresses your

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-17 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478650#comment-16478650 ] Mukul Kumar Singh commented on HDDS-76: --- Thanks for the patch [~shashikant]. The patch looks really

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-16 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477720#comment-16477720 ] genericqa commented on HDDS-76: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime

[jira] [Commented] (HDDS-76) Modify SCMStorageReportProto to include the data dir paths as well as the StorageType info

2018-05-16 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477595#comment-16477595 ] Shashikant Banerjee commented on HDDS-76: - patch v0 adds the storage location path, storage type and