[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753825#comment-16753825 ] Hudson commented on HDDS-974: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15839

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-28 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753810#comment-16753810 ] Yiqun Lin commented on HDDS-974: Comment makes sense to me. +1. Committing this. > Add get

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-28 Thread Doroszlai, Attila (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753800#comment-16753800 ] Doroszlai, Attila commented on HDDS-974: Hi [~linyiqun], thanks for the review. Re

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-27 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753659#comment-16753659 ] Yiqun Lin commented on HDDS-974: Almost looks good to me, only one comment: {code} /** -

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-25 Thread Dinesh Chitlangia (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752566#comment-16752566 ] Dinesh Chitlangia commented on HDDS-974: +1(non binding), test failure is unrelated

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752549#comment-16752549 ] Hadoop QA commented on HDDS-974: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Su

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-25 Thread Doroszlai, Attila (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752523#comment-16752523 ] Doroszlai, Attila commented on HDDS-974: Fixed checkstyle issues.  Unit test failur

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752440#comment-16752440 ] Hadoop QA commented on HDDS-974: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Su

[jira] [Commented] (HDDS-974) Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell

2019-01-25 Thread Dinesh Chitlangia (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752408#comment-16752408 ] Dinesh Chitlangia commented on HDDS-974: [~adoroszlai] Thank you for working on thi