[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728490#comment-15728490
]
Hadoop QA commented on HDFS-10206:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728003#comment-15728003
]
Nandakumar commented on HDFS-10206:
---
Thanks for the review [~mingma].
Have uploaded the patch on top of
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727676#comment-15727676
]
Ming Ma commented on HDFS-10206:
Thanks [~nandakumar131]. The patch looks good. Given the patch doesn't
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727604#comment-15727604
]
Hadoop QA commented on HDFS-10206:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15719836#comment-15719836
]
Nandakumar commented on HDFS-10206:
---
Hi [~mingma], Added logic to check for identical nodes in
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15718536#comment-15718536
]
Ming Ma commented on HDFS-10206:
ok. Maybe it isn't precise way to refer it. The "network path" comes from
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717602#comment-15717602
]
Nandakumar commented on HDFS-10206:
---
No, nodes of same network path refers to nodes on same rack.
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717543#comment-15717543
]
Ming Ma commented on HDFS-10206:
To clarify, "two nodes of the same network path" referred to two
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717398#comment-15717398
]
Nandakumar commented on HDFS-10206:
---
If we return 0 for two nodes having the same network path (i.e. in
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15717370#comment-15717370
]
Ming Ma commented on HDFS-10206:
Thanks [~nandakumar131]! The patches look good overall. To make the
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712724#comment-15712724
]
Nandakumar commented on HDFS-10206:
---
bq. nonDataNodeReader. However, it turns out NetworkTopology has
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707535#comment-15707535
]
Ming Ma commented on HDFS-10206:
bq. Can you point out the variables which are to be made more generic?
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704378#comment-15704378
]
Nandakumar commented on HDFS-10206:
---
bq. NetworkTopology can be used by HDFS, YARN and MAPREDUCE. It is
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702984#comment-15702984
]
Ming Ma commented on HDFS-10206:
* NetworkTopology can be used by HDFS, YARN and MAPREDUCE. It is better
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696454#comment-15696454
]
Nandakumar commented on HDFS-10206:
---
Thanks for the comment [~mingma]
{quote}
Any idea why 000.patch
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692234#comment-15692234
]
Ming Ma commented on HDFS-10206:
Thanks [~nanda619] for the micro benchmark and the new patch.
* Any idea
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683203#comment-15683203
]
Nandakumar commented on HDFS-10206:
---
New [^HDFS-10206.001.patch] has been uploaded.
The logic is
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679807#comment-15679807
]
Nandakumar commented on HDFS-10206:
---
{quote}
Here is another option. DatanodeManager#sortLocatedBlock
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679692#comment-15679692
]
Ming Ma commented on HDFS-10206:
bq. Any comments on using NetworkTopology.contains(node) to check and use
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676336#comment-15676336
]
Nandakumar commented on HDFS-10206:
---
bq. From the below code, it seems each level will increase by 2.
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674317#comment-15674317
]
Ming Ma commented on HDFS-10206:
bq. that is why getDistanceUsingNetworkLocation is called only when the
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673673#comment-15673673
]
Nandakumar commented on HDFS-10206:
---
Thanks for the review [~mingma].
{quote}
When the conditions
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673058#comment-15673058
]
Ming Ma commented on HDFS-10206:
Thank [~nandakumar131]!
* When the conditions {{reader.equals(node) &
[
https://issues.apache.org/jira/browse/HDFS-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651089#comment-15651089
]
Nandakumar commented on HDFS-10206:
---
{{NetworkTopology#sortByDistance}} uses
24 matches
Mail list logo
