[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765376#comment-15765376
]
Eric Badger commented on HDFS-11094:
[~liuml07], can we cherry-pick this to 2.8? I'm seeing test
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752852#comment-15752852
]
Eric Badger commented on HDFS-11094:
Thanks, [~liuml07]!
> Send back HAState along with NamespaceInfo
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752846#comment-15752846
]
Hudson commented on HDFS-11094:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11004 (See
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752737#comment-15752737
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752505#comment-15752505
]
Mingliang Liu commented on HDFS-11094:
--
+1 pending on Jenkins.
> Send back HAState along with
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751772#comment-15751772
]
Kihwal Lee commented on HDFS-11094:
---
I am fine with the latest patch.
> Send back HAState along with
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750003#comment-15750003
]
Mingliang Liu commented on HDFS-11094:
--
+1
Failing test is not related. Do we need separate patch
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746031#comment-15746031
]
Mingliang Liu commented on HDFS-11094:
--
Yes I will review this week if no reviews from others.
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746006#comment-15746006
]
Eric Badger commented on HDFS-11094:
[~liuml07], can you take a look at the latest patch?
> Send back
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743081#comment-15743081
]
Eric Badger commented on HDFS-11094:
Test failure looks like it's unrelated and doesn't fail for me
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15736011#comment-15736011
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735593#comment-15735593
]
Eric Badger commented on HDFS-11094:
The TestBPOfferService failure is definitely relevant here. Not
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733853#comment-15733853
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733675#comment-15733675
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733520#comment-15733520
]
Hudson commented on HDFS-11094:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10973 (See
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726682#comment-15726682
]
Eric Badger commented on HDFS-11094:
Ok, yes, that sounds good. Thanks!
> Send back HAState along
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726664#comment-15726664
]
Mingliang Liu commented on HDFS-11094:
--
Thanks for bringing this up. If we agree to revert
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726425#comment-15726425
]
Eric Badger commented on HDFS-11094:
[~liuml07], actually hold off on committing that
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723209#comment-15723209
]
Hudson commented on HDFS-11094:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10939 (See
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722763#comment-15722763
]
Daryn Sharp commented on HDFS-11094:
+1 Assuming no other blocking objections. I've been involved
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716886#comment-15716886
]
Mingliang Liu commented on HDFS-11094:
--
For the protocol changes, end-to-end tests are very helpful.
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716729#comment-15716729
]
Eric Badger commented on HDFS-11094:
bq. I think the existing tests are quite adequate. I understand
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716687#comment-15716687
]
Kihwal Lee commented on HDFS-11094:
---
bq. For the unit test, can we set a very large heartbeat interval
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705818#comment-15705818
]
Eric Badger commented on HDFS-11094:
{quote}
1. I discussed with Arpit Agarwal offline and he
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703890#comment-15703890
]
Mingliang Liu commented on HDFS-11094:
--
Hi [~ebadger], thanks for updating the patch. Sorry for
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690560#comment-15690560
]
Hadoop QA commented on HDFS-11094:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688247#comment-15688247
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677554#comment-15677554
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675208#comment-15675208
]
Mingliang Liu commented on HDFS-11094:
--
+1
Some comments:
# Is it possible to add a unit test for
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670530#comment-15670530
]
Eric Badger commented on HDFS-11094:
The test failures are unrelated to the patch and do not fail for
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668776#comment-15668776
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667941#comment-15667941
]
Hadoop QA commented on HDFS-11094:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667563#comment-15667563
]
Eric Badger commented on HDFS-11094:
[~liuml07], I updated the subject and description.
bq. One
33 matches
Mail list logo