[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454986#comment-16454986
]
Hudson commented on HDFS-11138:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450544#comment-16450544
]
Hudson commented on HDFS-11138:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677911#comment-15677911
]
Hadoop QA commented on HDFS-11138:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677871#comment-15677871
]
Anu Engineer commented on HDFS-11138:
-
+1, Thanks for updating this patch. I will commit this patch to
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677614#comment-15677614
]
Hadoop QA commented on HDFS-11138:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675342#comment-15675342
]
Anu Engineer commented on HDFS-11138:
-
Let us keep the map for time being. We can revisit this later.
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675319#comment-15675319
]
Chen Liang commented on HDFS-11138:
---
Thanks [~anu] for the comments! Again here are some thoughts I had
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675206#comment-15675206
]
Anu Engineer commented on HDFS-11138:
-
[~vagarychen] Thanks for updating the patch. Overall it is
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675154#comment-15675154
]
Chen Liang commented on HDFS-11138:
---
The findbug warnings are for the protobuf-generated classes. The
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674751#comment-15674751
]
Hadoop QA commented on HDFS-11138:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672424#comment-15672424
]
Hadoop QA commented on HDFS-11138:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672125#comment-15672125
]
Hadoop QA commented on HDFS-11138:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671496#comment-15671496
]
Anu Engineer commented on HDFS-11138:
-
Thought this might help you, checkstyle warnings:
{noformat}
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671319#comment-15671319
]
Anu Engineer commented on HDFS-11138:
-
bq. I actually do not have any strong opinion on this, if it is
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671324#comment-15671324
]
Chen Liang commented on HDFS-11138:
---
bq. I think if user specifies it we should use it, that is like
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671311#comment-15671311
]
Chen Liang commented on HDFS-11138:
---
I actually do not have any strong opinion on this, if it is making
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671293#comment-15671293
]
Anu Engineer commented on HDFS-11138:
-
bq. The idea is that the force flag is only an optional flag,
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671281#comment-15671281
]
Chen Liang commented on HDFS-11138:
---
Thanks [~anu] for the comments!
Here were my thoughts on some of
[
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669116#comment-15669116
]
Anu Engineer commented on HDFS-11138:
-
Thank you for the patch, overall it looks very good. I have a
19 matches
Mail list logo
