[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796865#comment-17796865
]
Tsz-wo Sze commented on HDFS-13056:
---
[~dennishuo], thanks for the nice work! Filed HAD
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848276#comment-16848276
]
Dennis Huo commented on HDFS-13056:
---
Sorry, I somehow missed the note from [~xiaochen]
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841106#comment-16841106
]
Wei-Chiu Chuang commented on HDFS-13056:
Additionally, this new feature does not
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841095#comment-16841095
]
Wei-Chiu Chuang commented on HDFS-13056:
I filed HDFS-14496 to add it into Hadoop
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439869#comment-16439869
]
Arpit Agarwal commented on HDFS-13056:
--
Cherry-picked to branch-3.1. Thanks for the f
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433401#comment-16433401
]
Hudson commented on HDFS-13056:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430851#comment-16430851
]
Xiao Chen commented on HDFS-13056:
--
Thanks [~ste...@apache.org]. I think we're on the sam
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430417#comment-16430417
]
Steve Loughran commented on HDFS-13056:
---
bq. in case Steve or other watchers want to
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428527#comment-16428527
]
Xiao Chen commented on HDFS-13056:
--
Casting my official +1 on this, will let it float for
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426528#comment-16426528
]
Xiao Chen commented on HDFS-13056:
--
Did another round of review, and played with the unit
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425348#comment-16425348
]
Steve Loughran commented on HDFS-13056:
---
bq. DFSClient is an hdfs class, so we don't
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425136#comment-16425136
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424935#comment-16424935
]
Dennis Huo commented on HDFS-13056:
---
Good observation, [~xiaochen], that seems to save a
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423449#comment-16423449
]
Xiao Chen commented on HDFS-13056:
--
Thanks [~dennishuo] for the new rev! LGTM, pending th
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416988#comment-16416988
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416732#comment-16416732
]
Dennis Huo commented on HDFS-13056:
---
Thanks for taking another look [~xiaochen]! Applied
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415032#comment-16415032
]
Xiao Chen commented on HDFS-13056:
--
Thanks for revving [~dennishuo]! I think we're pretty
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412902#comment-16412902
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412536#comment-16412536
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412452#comment-16412452
]
Dennis Huo commented on HDFS-13056:
---
Merged trunk to produce [^HDFS-13056.011.patch]
>
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412449#comment-16412449
]
Dennis Huo commented on HDFS-13056:
---
Thanks for taking a look [~ste...@apache.org]! Appl
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412441#comment-16412441
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411794#comment-16411794
]
Xiao Chen commented on HDFS-13056:
--
Thanks for revving [~dennishuo].
{quote}DFSClient des
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411254#comment-16411254
]
Steve Loughran commented on HDFS-13056:
---
* I'm worried that {{getFileChecksumWithCo
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410854#comment-16410854
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410650#comment-16410650
]
Dennis Huo commented on HDFS-13056:
---
Thanks for the review [~xiaochen]! Responses:
-
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409094#comment-16409094
]
Xiao Chen commented on HDFS-13056:
--
Thanks a lot for the work here [~dennishuo]! Looks pr
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393722#comment-16393722
]
Ajay Kumar commented on HDFS-13056:
---
+1 (non-binding)
[~dennishuo], agree, created [HDFS
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393595#comment-16393595
]
Dennis Huo commented on HDFS-13056:
---
[~ajayydv], unfortunately, the FileChecksumHelper a
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393485#comment-16393485
]
Ajay Kumar commented on HDFS-13056:
---
[~dennishuo], Sorry, i missed it earlier. Current
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393023#comment-16393023
]
Dennis Huo commented on HDFS-13056:
---
Thanks for helping validate the mixed-chunksize sup
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392391#comment-16392391
]
Ajay Kumar commented on HDFS-13056:
---
[~dennishuo] thanks for updating the patch to handl
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392176#comment-16392176
]
Dennis Huo commented on HDFS-13056:
---
Variable-sized blocks within a file are indeed supp
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392107#comment-16392107
]
Arpit Agarwal commented on HDFS-13056:
--
Hi [~dennishuo], I haven't read your design d
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390789#comment-16390789
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390617#comment-16390617
]
Dennis Huo commented on HDFS-13056:
---
Some observations - the FileSystem interface doesn'
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390272#comment-16390272
]
Dennis Huo commented on HDFS-13056:
---
Good catch, thanks for the report, [~ajayydv]. I ac
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390170#comment-16390170
]
Ajay Kumar commented on HDFS-13056:
---
Hi [~dennishuo], Below test case fails with latest
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387291#comment-16387291
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387080#comment-16387080
]
Dennis Huo commented on HDFS-13056:
---
Uploaded [^HDFS-13056-branch-2.8.004.patch] and [^H
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384558#comment-16384558
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384469#comment-16384469
]
Dennis Huo commented on HDFS-13056:
---
While testing some integration with non-HDFS filesy
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383387#comment-16383387
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383178#comment-16383178
]
Dennis Huo commented on HDFS-13056:
---
Added [^HDFS-13056.005.patch] to fix TestHdfsConfig
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383166#comment-16383166
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383162#comment-16383162
]
Dennis Huo commented on HDFS-13056:
---
Also added a backport to branch-2.8 which I was abl
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383143#comment-16383143
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382938#comment-16382938
]
Dennis Huo commented on HDFS-13056:
---
[~ajayydv] Thanks for helping test and reviewing! A
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381538#comment-16381538
]
Ajay Kumar commented on HDFS-13056:
---
[~dennishuo], Thanks for working on this. I tested
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373846#comment-16373846
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373729#comment-16373729
]
Dennis Huo commented on HDFS-13056:
---
[~szetszwo] and [~drankye] may also be interested i
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372423#comment-16372423
]
Dennis Huo commented on HDFS-13056:
---
Fixed all the checkstyle issues; the failed unittes
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372415#comment-16372415
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371052#comment-16371052
]
genericqa commented on HDFS-13056:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370820#comment-16370820
]
ASF GitHub Bot commented on HDFS-13056:
---
GitHub user dennishuo opened a pull request
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347851#comment-16347851
]
Dennis Huo commented on HDFS-13056:
---
Uploaded initial end-to-end working draft against t
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347407#comment-16347407
]
Dennis Huo commented on HDFS-13056:
---
I ended up going with modifying the existing protoc
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347281#comment-16347281
]
zhenzhao wang commented on HDFS-13056:
--
Thanks for the detailed info. Both adding new
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341933#comment-16341933
]
Dennis Huo commented on HDFS-13056:
---
Thanks for sharing! I was also weighing whether to
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341426#comment-16341426
]
zhenzhao wang commented on HDFS-13056:
--
I also get some prototype code on providing f
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338488#comment-16338488
]
Dennis Huo commented on HDFS-13056:
---
Cleaned up the POC code against branch-2.8 to sketc
[
https://issues.apache.org/jira/browse/HDFS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336852#comment-16336852
]
Dennis Huo commented on HDFS-13056:
---
Attached a quick and dirty poc patch which just har
62 matches
Mail list logo