[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-15 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401261#comment-16401261 ] Ajay Kumar commented on HDFS-13251: --- [~xyao] thanks for commit and review. > Avoid usin

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400838#comment-16400838 ] Hudson commented on HDFS-13251: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400091#comment-16400091 ] genericqa commented on HDFS-13251: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-14 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399866#comment-16399866 ] Ajay Kumar commented on HDFS-13251: --- [~xyao], thanks for commit. Added addendum patch wi

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399212#comment-16399212 ] Hudson commented on HDFS-13251: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-14 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399017#comment-16399017 ] Xiaoyu Yao commented on HDFS-13251: --- +1, I will commit it shortly. > Avoid using hard c

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-14 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398931#comment-16398931 ] Ajay Kumar commented on HDFS-13251: --- test failures are unrelated. TestDataNodeVolumeFail

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397919#comment-16397919 ] genericqa commented on HDFS-13251: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-13 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397739#comment-16397739 ] Xiaoyu Yao commented on HDFS-13251: --- Thanks [~ajayydv] for the update. +1 pending Jenkin

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-13 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397689#comment-16397689 ] Ajay Kumar commented on HDFS-13251: --- Patch v3 to adress [~xyao] suggestions. Removed bel

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-13 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397518#comment-16397518 ] Xiaoyu Yao commented on HDFS-13251: --- [~ajayydv] , thanks for the update. The new patch l

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-12 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396582#comment-16396582 ] genericqa commented on HDFS-13251: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-12 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396437#comment-16396437 ] Ajay Kumar commented on HDFS-13251: --- [~xyao], thanks for review. patch v2 to address you

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-12 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396084#comment-16396084 ] Xiaoyu Yao commented on HDFS-13251: --- Thanks [~ajayydv] for working on this. Here are som

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-12 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395832#comment-16395832 ] Ajay Kumar commented on HDFS-13251: --- [~xyao] thanks, made changes to {{TestDiskBalancerC

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-12 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395782#comment-16395782 ] Xiaoyu Yao commented on HDFS-13251: --- TestDiskBalancerCommand: line 618/624 > Avoid usin

[jira] [Commented] (HDFS-13251) Avoid using hard coded datanode data dirs in unit tests

2018-03-12 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395776#comment-16395776 ] Ajay Kumar commented on HDFS-13251: --- [~xyao], Don't find its usage in TestDiskBalancerCo