[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474431#comment-16474431
]
Xiao Chen commented on HDFS-13539:
--
Committing this based on Eddy's +1 and the belief that the above
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472403#comment-16472403
]
Xiao Chen commented on HDFS-13539:
--
Ping [~ajayydv], any comments?
> DFSInputStream NPE when
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471147#comment-16471147
]
Xiao Chen commented on HDFS-13539:
--
Thanks for the comment [~ajayydv]. Could you elaborate?
{code}
try {
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471062#comment-16471062
]
Ajay Kumar commented on HDFS-13539:
---
[~xiaochen] thanks for working on this. Patch LGTM. One suggestion
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469947#comment-16469947
]
Xiao Chen commented on HDFS-13539:
--
Failed tests look unrelated and passed locally. Will commit by end of
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469631#comment-16469631
]
genericqa commented on HDFS-13539:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469343#comment-16469343
]
Xiao Chen commented on HDFS-13539:
--
Thanks for the review Eddy. Comments addressed in
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469276#comment-16469276
]
Lei (Eddy) Xu commented on HDFS-13539:
--
Thanks Xiao for the patch.
Some minor comments:
* Could we
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469077#comment-16469077
]
Xiao Chen commented on HDFS-13539:
--
Failed tests does not look related.
The synchronized changes are only
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469074#comment-16469074
]
Xiao Chen commented on HDFS-13539:
--
[~eddyxu] could you take a look?
> DFSInputStream NPE when
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468277#comment-16468277
]
genericqa commented on HDFS-13539:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468073#comment-16468073
]
Xiao Chen commented on HDFS-13539:
--
It's not clear to me why this cannot happen to DFSInputStream, so the
12 matches
Mail list logo
