[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758761#comment-16758761
]
Hadoop QA commented on HDFS-14250:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758715#comment-16758715
]
Erik Krogen commented on HDFS-14250:
Great ! +1 from me pending Jenkins, will commit early next week
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758707#comment-16758707
]
Chao Sun commented on HDFS-14250:
-
Thanks [~xkrogen]! Attached patch v1 to address the comment.
>
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758643#comment-16758643
]
Erik Krogen commented on HDFS-14250:
v000 patch LGTM, only minor nit is that I would probably switch
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757742#comment-16757742
]
Chao Sun commented on HDFS-14250:
-
Yes, I think we can just use {{activeOnly}} for this type of purpose.
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757722#comment-16757722
]
Erik Krogen commented on HDFS-14250:
I don't think we want to make it write anything per se, but IIRC
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757712#comment-16757712
]
Chao Sun commented on HDFS-14250:
-
[~xkrogen] you are right. Maybe {{msync}} can simply be a write call
[
https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757704#comment-16757704
]
Erik Krogen commented on HDFS-14250:
I think #2 is not necessary -- this will be handled
