[jira] [Commented] (HDFS-8207) Improper log mesage when blockreport interval comapred with initial delay

2015-05-08 Thread Tsuyoshi Ozawa (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534150#comment-14534150
 ] 

Tsuyoshi Ozawa commented on HDFS-8207:
--

+1

 Improper log mesage when blockreport interval comapred with initial delay
 -

 Key: HDFS-8207
 URL: https://issues.apache.org/jira/browse/HDFS-8207
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Minor
  Labels: BB2015-05-TBR
 Attachments: HDFS-8207.patch, Hadoop-8253.patch, Hadoop-8253.patch


 Log message is telling if initialDelay is more than blockReportInterval 
 setting to 0.
 But actuall check is greaterthan and equal..like following..It is misleading 
 initail I thought if it
 is equal then initailBr wn't set to zero.
 {code}
 if (initBRDelay = blockReportInterval) {
   initBRDelay = 0;
   DataNode.LOG.info(dfs.blockreport.initialDelay is greater than  +
   dfs.blockreport.intervalMsec. +  Setting initial delay to 0 
 msec:);
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8207) Improper log mesage when blockreport interval comapred with initial delay

2015-04-22 Thread Brahma Reddy Battula (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507283#comment-14507283
 ] 

Brahma Reddy Battula commented on HDFS-8207:


Rebased the patch, kindly review!!!

 Improper log mesage when blockreport interval comapred with initial delay
 -

 Key: HDFS-8207
 URL: https://issues.apache.org/jira/browse/HDFS-8207
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Minor
 Attachments: HDFS-8207.patch, Hadoop-8253.patch, Hadoop-8253.patch


 Log message is telling if initialDelay is more than blockReportInterval 
 setting to 0.
 But actuall check is greaterthan and equal..like following..It is misleading 
 initail I thought if it
 is equal then initailBr wn't set to zero.
 {code}
 if (initBRDelay = blockReportInterval) {
   initBRDelay = 0;
   DataNode.LOG.info(dfs.blockreport.initialDelay is greater than  +
   dfs.blockreport.intervalMsec. +  Setting initial delay to 0 
 msec:);
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8207) Improper log mesage when blockreport interval comapred with initial delay

2015-04-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505653#comment-14505653
 ] 

Hadoop QA commented on HDFS-8207:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12726912/HDFS-8207.patch
  against trunk revision 8ddbb8d.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

  org.apache.hadoop.hdfs.server.namenode.TestEditLog

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/10333//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HDFS-Build/10333//console

This message is automatically generated.

 Improper log mesage when blockreport interval comapred with initial delay
 -

 Key: HDFS-8207
 URL: https://issues.apache.org/jira/browse/HDFS-8207
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Minor
 Attachments: HDFS-8207.patch, Hadoop-8253.patch, Hadoop-8253.patch


 Log message is telling if initialDelay is more than blockReportInterval 
 setting to 0.
 But actuall check is greaterthan and equal..like following..It is misleading 
 initail I thought if it
 is equal then initailBr wn't set to zero.
 {code}
 if (initBRDelay = blockReportInterval) {
   initBRDelay = 0;
   DataNode.LOG.info(dfs.blockreport.initialDelay is greater than  +
   dfs.blockreport.intervalMsec. +  Setting initial delay to 0 
 msec:);
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8207) Improper log mesage when blockreport interval comapred with initial delay

2015-04-21 Thread Brahma Reddy Battula (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505232#comment-14505232
 ] 

Brahma Reddy Battula commented on HDFS-8207:


Attached patch ..Kindly review...

 Improper log mesage when blockreport interval comapred with initial delay
 -

 Key: HDFS-8207
 URL: https://issues.apache.org/jira/browse/HDFS-8207
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Minor
 Attachments: HDFS-8207.patch, Hadoop-8253.patch, Hadoop-8253.patch


 Log message is telling if initialDelay is more than blockReportInterval 
 setting to 0.
 But actuall check is greaterthan and equal..like following..It is misleading 
 initail I thought if it
 is equal then initailBr wn't set to zero.
 {code}
 if (initBRDelay = blockReportInterval) {
   initBRDelay = 0;
   DataNode.LOG.info(dfs.blockreport.initialDelay is greater than  +
   dfs.blockreport.intervalMsec. +  Setting initial delay to 0 
 msec:);
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)