[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938023#comment-14938023
]
Hudson commented on HDFS-8319:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #439 (See
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937804#comment-14937804
]
Hudson commented on HDFS-8319:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #473 (See
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938593#comment-14938593
]
Hudson commented on HDFS-8319:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #465 (See
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937547#comment-14937547
]
Hudson commented on HDFS-8319:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #1203 (See
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937299#comment-14937299
]
Hudson commented on HDFS-8319:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8548 (See
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937102#comment-14937102
]
Hudson commented on HDFS-8319:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2379 (See
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573902#comment-14573902
]
Zhe Zhang commented on HDFS-8319:
-
I see, basically with the current algorithm, the {{if
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573800#comment-14573800
]
Zhe Zhang commented on HDFS-8319:
-
The rest of the patch looks good except the 2 nits
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573821#comment-14573821
]
Jing Zhao commented on HDFS-8319:
-
Thanks a lot for the review, Zhe!
bq. Is it possible
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573843#comment-14573843
]
Jing Zhao commented on HDFS-8319:
-
but we only read one more parity block each time we hit
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573626#comment-14573626
]
Zhe Zhang commented on HDFS-8319:
-
bq. Yeah, actually stateful read shares the same logic.
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573832#comment-14573832
]
Zhe Zhang commented on HDFS-8319:
-
Thx Jing for clarifying. What about cancelled requests?
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573776#comment-14573776
]
Zhe Zhang commented on HDFS-8319:
-
# Follow-on: {{divideOneStripe}} can be further
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571877#comment-14571877
]
Kai Zheng commented on HDFS-8319:
-
Thanks Jing for the update.
bq. We use a direct
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571900#comment-14571900
]
Jing Zhao commented on HDFS-8319:
-
bq. Using the same buffer type (no mixing) will also
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571918#comment-14571918
]
Kai Zheng commented on HDFS-8319:
-
bq. there is no API level restriction to prevent the
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571929#comment-14571929
]
Jing Zhao commented on HDFS-8319:
-
bq. So looks like the inputOffsets doesn't work?
The
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572095#comment-14572095
]
Jing Zhao commented on HDFS-8319:
-
bq. For pread, initDecodeInputs does the job of
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572017#comment-14572017
]
Jing Zhao commented on HDFS-8319:
-
bq. By the way, I noticed you have some code refactoring
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572056#comment-14572056
]
Walter Su commented on HDFS-8319:
-
{code}
void prepareParityChunk() {
for (int i =
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571976#comment-14571976
]
Kai Zheng commented on HDFS-8319:
-
Yes, we can avoid this by always allocating direct
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572012#comment-14572012
]
Kai Zheng commented on HDFS-8319:
-
bq. I guess you can try using ByteBuffer#arrayOffset
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571991#comment-14571991
]
Jing Zhao commented on HDFS-8319:
-
bq. We could also not use slice call, instead use
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572064#comment-14572064
]
Zhe Zhang commented on HDFS-8319:
-
For pread, initDecodeInputs does the job of preparing
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572070#comment-14572070
]
Kai Zheng commented on HDFS-8319:
-
HADOOP-12060 was opened to address coder related issues
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569501#comment-14569501
]
Zhe Zhang commented on HDFS-8319:
-
Thanks Jing for the updates! I'm taking a look at it now
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569977#comment-14569977
]
Kai Zheng commented on HDFS-8319:
-
Looks like the involved change is a little big. Maybe we
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569927#comment-14569927
]
Kai Zheng commented on HDFS-8319:
-
Thanks Jing and Zhe for the good work and discussion
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569792#comment-14569792
]
Zhe Zhang commented on HDFS-8319:
-
Great work Jing! {{StripeReader}} is a very good
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570102#comment-14570102
]
Walter Su commented on HDFS-8319:
-
bq. We can rename prepareParityChunk to
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570265#comment-14570265
]
Zhe Zhang commented on HDFS-8319:
-
bq. Did you miss the break statement too? It only
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568959#comment-14568959
]
Walter Su commented on HDFS-8319:
-
All good just one minor issue:
We need (5 dataBlks + 1
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569471#comment-14569471
]
Jing Zhao commented on HDFS-8319:
-
Thanks for the comments, Walter! Actually this has been
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558978#comment-14558978
]
Walter Su commented on HDFS-8319:
-
1.
{code}
int len = (int) (rangeEndInBlockGroup -
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559029#comment-14559029
]
Walter Su commented on HDFS-8319:
-
9. Pread create block reader at
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559508#comment-14559508
]
Jing Zhao commented on HDFS-8319:
-
Thanks for the review, [~walter.k.su]. Replied your
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542392#comment-14542392
]
Zhe Zhang commented on HDFS-8319:
-
{quote}
_readOneStripe looks quite similar to
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542403#comment-14542403
]
Jing Zhao commented on HDFS-8319:
-
Thanks Zhe! I will include the refactoring here.
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542419#comment-14542419
]
Zhe Zhang commented on HDFS-8319:
-
Thanks for confirming this :)
Erasure Coding: support
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527400#comment-14527400
]
Jing Zhao commented on HDFS-8319:
-
Yeah, sure. I will review HDFS-7678 later today.
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527404#comment-14527404
]
Zhe Zhang commented on HDFS-8319:
-
Thanks!
Erasure Coding: support decoding for stateful
[
https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527387#comment-14527387
]
Zhe Zhang commented on HDFS-8319:
-
Thanks Jing, would be great if you can take a look at
42 matches
Mail list logo
