[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747656#comment-15747656
]
SammiChen commented on HDFS-8411:
-
Thanks [~andrew.wang], [~rakeshr] and [~drankye] for the reviewing !
>
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747536#comment-15747536
]
Hudson commented on HDFS-8411:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10995 (See
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747475#comment-15747475
]
Kai Zheng commented on HDFS-8411:
-
The latest patch LGTM and +1. Will commit it shortly.
> Add bytes count
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744820#comment-15744820
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743764#comment-15743764
]
Kai Zheng commented on HDFS-8411:
-
Thanks Sammi for the update! It needs a rebase since HDFS-11368 was in.
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741789#comment-15741789
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15741304#comment-15741304
]
SammiChen commented on HDFS-8411:
-
Thanks Kai for reviewing the patch! I have uploaded new patch to address
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734508#comment-15734508
]
Kai Zheng commented on HDFS-8411:
-
Thanks [~andrew.wang] for the ping! It's good for me to have a very
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733531#comment-15733531
]
Andrew Wang commented on HDFS-8411:
---
Cool, thanks for the review Sammi! [~drankye] mind giving this a
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731999#comment-15731999
]
SammiChen commented on HDFS-8411:
-
Andrew, thanks for provide the sample patch! It perfectly solves the
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730941#comment-15730941
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727514#comment-15727514
]
SammiChen commented on HDFS-8411:
-
Hi [~andrew.wang], thanks for reviewing the patch!
bq. •In
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723974#comment-15723974
]
Andrew Wang commented on HDFS-8411:
---
Thanks for working on this Sammi and Rakesh for reviewing, I had a
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721710#comment-15721710
]
Rakesh R commented on HDFS-8411:
Thank you [~Sammi], +1, latest patch looks good to me.
[~andrew.wang],
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721666#comment-15721666
]
SammiChen commented on HDFS-8411:
-
Double checked the failed test cases, they are irrelevant to this patch.
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721429#comment-15721429
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715298#comment-15715298
]
Rakesh R commented on HDFS-8411:
Thanks [~Sammi] for the continuous effort. Its nearing completion, it
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715103#comment-15715103
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714870#comment-15714870
]
SammiChen commented on HDFS-8411:
-
Thanks [~rakeshr], It's a good point. I will upload a new patch. Besides
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713957#comment-15713957
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713875#comment-15713875
]
Rakesh R commented on HDFS-8411:
Thank you [~Sammi] for the good work. Apart from the following comment,
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711917#comment-15711917
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711748#comment-15711748
]
SammiChen commented on HDFS-8411:
-
Thanks [~rakeshr] very much for helping review the patch!
bq. 1.
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708820#comment-15708820
]
Rakesh R commented on HDFS-8411:
Thanks [~Sammi] for the work. I've few comments,
# Striped reading logic
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708492#comment-15708492
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708232#comment-15708232
]
SammiChen commented on HDFS-8411:
-
Hi [~andrew.wang], thanks for review the patch! I will upload a new
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15599055#comment-15599055
]
SammiChen commented on HDFS-8411:
-
Hi Andrew, thanks for provide so many insightful comments. I will do
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596287#comment-15596287
]
Andrew Wang commented on HDFS-8411:
---
Thanks for picking this up [~Sammi], I'd like to go a bit deeper in
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588653#comment-15588653
]
Hadoop QA commented on HDFS-8411:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587001#comment-15587001
]
Andrew Wang commented on HDFS-8411:
---
I think generally, more metrics are useful. HDFS-8529 I just closed
[
https://issues.apache.org/jira/browse/HDFS-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602315#comment-14602315
]
Walter Su commented on HDFS-8411:
-
I think this metric is unnecessary. Block replication
您的邮件已收到!谢谢!
32 matches
Mail list logo