[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620314#comment-14620314
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620356#comment-14620356
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/981/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618428#comment-14618428
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8130 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8130/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618558#comment-14618558
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #248 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/248/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618584#comment-14618584
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2196 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2196/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618655#comment-14618655
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2177 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2177/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618732#comment-14618732
]
Lei (Eddy) Xu commented on HDFS-8712:
-
Thanks much for committing this, [~vinayrpet]. And thanks for the reviews,
[~andrew.wang].
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618706#comment-14618706
]
Hudson commented on HDFS-8712:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #238 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/238/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and
FsDatasetSpi (Contributed by Lei (Eddy) Xu) (vinayakumarb: rev
bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Fix For: 2.8.0
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618141#comment-14618141
]
Hadoop QA commented on HDFS-8712:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 16m 1s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 51s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 9s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 47s | There were no new checkstyle
issues. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 5 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 40s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 27s | The patch appears to introduce 1
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 23s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 157m 36s | Tests passed in hadoop-hdfs.
|
| | | 201m 53s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744131/HDFS-8712.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c9dd2ca |
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/11617/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11617/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11617/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11617/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11617/console |
This message was automatically generated.
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617436#comment-14617436
]
Hadoop QA commented on HDFS-8712:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 18m 57s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 0s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 29s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 29s | The applied patch generated
10 new checkstyle issues (total was 118, now 33). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 6 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 30s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 27s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 167m 59s | Tests failed in hadoop-hdfs. |
| | | 217m 27s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.ha.TestHAAppend |
| | hadoop.hdfs.TestBlockReaderLocal |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12743363/HDFS-8712.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7e2fe8c |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11604/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11604/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/11604/artifact/patchprocess/whitespace.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11604/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11604/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11604/console |
This message was automatically generated.
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Attachments: HDFS-8712.000.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617889#comment-14617889
]
Hadoop QA commented on HDFS-8712:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 17m 55s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 13s | The applied patch generated
10 new checkstyle issues (total was 118, now 33). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 6 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 17s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 15s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 158m 45s | Tests passed in hadoop-hdfs.
|
| | | 205m 17s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12743363/HDFS-8712.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c9dd2ca |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11611/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11611/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/11611/artifact/patchprocess/whitespace.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11611/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11611/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11611/console |
This message was automatically generated.
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Attachments: HDFS-8712.000.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617975#comment-14617975
]
Vinayakumar B commented on HDFS-8712:
-
+1.
Will commit once jenkins gives a gate pass.
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8712) Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
[
https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612312#comment-14612312
]
Andrew Wang commented on HDFS-8712:
---
LGTM +1 pending, will help reduce the # of checkstyle warnings too.
Remove public and abstract modifiers in FsVolumeSpi and FsDatasetSpi
Key: HDFS-8712
URL: https://issues.apache.org/jira/browse/HDFS-8712
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Trivial
Attachments: HDFS-8712.000.patch
In [Java Language Specification
9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
bq. It is permitted, but discouraged as a matter of style, to redundantly
specify the public and/or abstract modifier for a method declared in an
interface.
{{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many
warnings in IDEs and {{checkstyle}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
