[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2016-03-14 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193520#comment-15193520 ] Colin Patrick McCabe commented on HDFS-9350: Thanks, [~cnauroth]. I uploaded the patch to

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2016-03-11 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191501#comment-15191501 ] Chris Nauroth commented on HDFS-9350: - [~cmccabe], that's perfect. +1. > Avoid creating temprorary

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2016-03-11 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191491#comment-15191491 ] Colin Patrick McCabe commented on HDFS-9350: Good catch, [~cnauroth]. I agree that we should

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2016-03-11 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191363#comment-15191363 ] Wei-Chiu Chuang commented on HDFS-9350: --- [~cnauroth], you're absolutely right about it. In HDFS-7284,

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2016-03-11 Thread Chris Nauroth (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191331#comment-15191331 ] Chris Nauroth commented on HDFS-9350: - I think this patch should be reverted, because it broke the

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2015-12-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064372#comment-15064372 ] Hudson commented on HDFS-9350: -- FAILURE: Integrated in Hadoop-trunk-Commit #8998 (See

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2015-12-18 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064295#comment-15064295 ] Colin Patrick McCabe commented on HDFS-9350: That makes sense. +1. Thanks, [~sfriberg]. >

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2015-11-02 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985387#comment-14985387 ] Daryn Sharp commented on HDFS-9350: --- I know SB should be used to append inside a loop, but doesn't the

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2015-11-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985487#comment-14985487 ] Hadoop QA commented on HDFS-9350: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9350) Avoid creating temprorary strings in Block.toString() and getBlockName()

2015-11-02 Thread Staffan Friberg (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985738#comment-14985738 ] Staffan Friberg commented on HDFS-9350: --- It does, but the problem is that the call to Long.toString