[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094137#comment-15094137
]
John Zhuge commented on HDFS-9522:
--
Thanks, [~drankye], it is not minor cleanup :) I will remove the
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093137#comment-15093137
]
Kai Zheng commented on HDFS-9522:
-
Looking at the patch, this looks more like refactoring of the existing
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091501#comment-15091501
]
Hadoop QA commented on HDFS-9522:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090838#comment-15090838
]
John Zhuge commented on HDFS-9522:
--
The unit tests do not belong to this jira. Will move them to
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090265#comment-15090265
]
Hadoop QA commented on HDFS-9522:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088994#comment-15088994
]
Hadoop QA commented on HDFS-9522:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087303#comment-15087303
]
Hadoop QA commented on HDFS-9522:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082945#comment-15082945
]
Hadoop QA commented on HDFS-9522:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075821#comment-15075821
]
John Zhuge commented on HDFS-9522:
--
Thanks [~ szetszwo] for the comments. Answers inline.
{quote}
No.
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075832#comment-15075832
]
John Zhuge commented on HDFS-9522:
--
Here is a short description for Patch 001:
* For different types of
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075825#comment-15075825
]
John Zhuge commented on HDFS-9522:
--
Thanks [~szetszwo] for the comments.
>> * if a class overrides
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074919#comment-15074919
]
Tsz Wo Nicholas Sze commented on HDFS-9522:
---
{quote}
-if a class overrides equals, it must
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074818#comment-15074818
]
Hadoop QA commented on HDFS-9522:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074659#comment-15074659
]
John Zhuge commented on HDFS-9522:
--
Passed unit test TestDistCpSync.
> Cleanup
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074657#comment-15074657
]
John Zhuge commented on HDFS-9522:
--
Uploaded patch 001. Passed unit test TestSnapshotDiffReport and
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058317#comment-15058317
]
John Zhuge commented on HDFS-9522:
--
There is a bug in DiffReportEntry.hashCode(). According to
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050239#comment-15050239
]
John Zhuge commented on HDFS-9522:
--
Thanks.
> Cleanup
[
https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047341#comment-15047341
]
Mingliang Liu commented on HDFS-9522:
-
Refined the title slightly.
> Cleanup
18 matches
Mail list logo
