[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=294216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294216 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 13/Aug/19 21:47 Start Date: 13/Aug/19 21:47 Worklog Time Spent: 10m Work Description: anuengineer commented on pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294216) Time Spent: 2h 10m (was: 2h) > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in > between test runs. > When writing tests in future for more failures scenarios, the tests will fail > if the log entry has multi-line stack trace in audit logs. > This jira aims to use ArrayList#clear to make the test future proof. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=294214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294214
]
ASF GitHub Bot logged work on HDDS-1886:
Author: ASF GitHub Bot
Created on: 13/Aug/19 21:46
Start Date: 13/Aug/19 21:46
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #1205: HDDS-1886.
Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r313627412
##
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
-lines.remove(0);
+lines.clear();
Review comment:
@adoroszlai Thanks for the review. I will commit this now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 294214)
Time Spent: 2h (was: 1h 50m)
> Use ArrayList#clear to address audit failure scenario
> -
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=294132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294132
]
ASF GitHub Bot logged work on HDDS-1886:
Author: ASF GitHub Bot
Created on: 13/Aug/19 19:53
Start Date: 13/Aug/19 19:53
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1205: HDDS-1886.
Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r313582830
##
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
-lines.remove(0);
+lines.clear();
Review comment:
@dineshchitlangia Thanks for clarifying the scope and filing the follow-up
Jira. I don't have any other concerns.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 294132)
Time Spent: 1h 50m (was: 1h 40m)
> Use ArrayList#clear to address audit failure scenario
> -
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=294126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294126
]
ASF GitHub Bot logged work on HDDS-1886:
Author: ASF GitHub Bot
Created on: 13/Aug/19 19:44
Start Date: 13/Aug/19 19:44
Worklog Time Spent: 10m
Work Description: dineshchitlangia commented on pull request #1205:
HDDS-1886. Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r313579214
##
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
-lines.remove(0);
+lines.clear();
Review comment:
@adoroszlai Could please you let me know if there are any other concerns
based on my response above and follow up jira? Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 294126)
Time Spent: 1h 40m (was: 1.5h)
> Use ArrayList#clear to address audit failure scenario
> -
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=291192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291192 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 08/Aug/19 11:36 Start Date: 08/Aug/19 11:36 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#issuecomment-519481991 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 94 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 595 | trunk passed | | +1 | compile | 360 | trunk passed | | +1 | checkstyle | 70 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 921 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 171 | trunk passed | | 0 | spotbugs | 464 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 687 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 629 | the patch passed | | +1 | compile | 400 | the patch passed | | +1 | javac | 400 | the patch passed | | +1 | checkstyle | 87 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 743 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 181 | the patch passed | | +1 | findbugs | 748 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 340 | hadoop-hdds in the patch passed. | | -1 | unit | 2038 | hadoop-ozone in the patch failed. | | +1 | asflicense | 42 | The patch does not generate ASF License warnings. | | | | 8271 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.ozone.om.TestKeyManagerImpl | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1205 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 57d888aca484 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 00b5a27 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/3/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/3/testReport/ | | Max. process+thread count | 5315 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 291192) Time Spent: 1.5h (was: 1h 20m) > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > La
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=290962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290962 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 08/Aug/19 02:54 Start Date: 08/Aug/19 02:54 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#issuecomment-519342897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 635 | trunk passed | | +1 | compile | 378 | trunk passed | | +1 | checkstyle | 63 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 847 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 156 | trunk passed | | 0 | spotbugs | 435 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 625 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 574 | the patch passed | | +1 | compile | 366 | the patch passed | | +1 | javac | 366 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedclient | 683 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 154 | the patch passed | | +1 | findbugs | 641 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 282 | hadoop-hdds in the patch passed. | | -1 | unit | 1995 | hadoop-ozone in the patch failed. | | +1 | asflicense | 43 | The patch does not generate ASF License warnings. | | | | 7698 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.client.rpc.TestCommitWatcher | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestKeyManagerImpl | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.om.TestScmSafeMode | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1205 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d459ff4e7ee0 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 70b4617 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/2/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/2/testReport/ | | Max. process+thread count | 5402 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290962) Time Spent: 1h 20m (was: 1h 10m) > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: pull-re
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=287354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-287354 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 01/Aug/19 23:19 Start Date: 01/Aug/19 23:19 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#issuecomment-517491076 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 582 | trunk passed | | +1 | compile | 355 | trunk passed | | +1 | checkstyle | 66 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 808 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 145 | trunk passed | | 0 | spotbugs | 432 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 616 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 567 | the patch passed | | +1 | compile | 370 | the patch passed | | +1 | javac | 370 | the patch passed | | +1 | checkstyle | 67 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 632 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 160 | the patch passed | | +1 | findbugs | 654 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 281 | hadoop-hdds in the patch passed. | | -1 | unit | 153 | hadoop-ozone in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 5686 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1205 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d2102f8a0289 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / e111789 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/1/testReport/ | | Max. process+thread count | 506 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common U: hadoop-hdds/common | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1205/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 287354) Time Spent: 1h 10m (was: 1h) > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in > between test runs. > When writing tests in future for more failures scenarios, the tests will fail > if the log entry has multi-line stack trace in audit logs. > This jira aims to use ArrayList#clear to make the test future proof.
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=286902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286902 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 01/Aug/19 18:03 Start Date: 01/Aug/19 18:03 Worklog Time Spent: 10m Work Description: dineshchitlangia commented on issue #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#issuecomment-517396117 Checkstyle & Integrations failures are unrelated to the patch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 286902) Time Spent: 1h (was: 50m) > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in > between test runs. > When writing tests in future for more failures scenarios, the tests will fail > if the log entry has multi-line stack trace in audit logs. > This jira aims to use ArrayList#clear to make the test future proof. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=286734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286734
]
ASF GitHub Bot logged work on HDDS-1886:
Author: ASF GitHub Bot
Created on: 01/Aug/19 14:23
Start Date: 01/Aug/19 14:23
Worklog Time Spent: 10m
Work Description: dineshchitlangia commented on pull request #1205:
HDDS-1886. Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r309700845
##
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
-lines.remove(0);
+lines.clear();
Review comment:
@adoroszlai Thanks for review & suggestions.
> 1. Wrap assertions and cleanup in `try` and `finally`, respectively.
Otherwise a failed assertion would cause all further independent test cases to
also fail due to leftover content in the file. (This one is not specific to
multi-line cases.)
Yes, that was the original approach, however, the review at the time
preferred to throw the Exception instead of catching it. This is because we
won't accept a few failures, the criteria required is all tests must pass.
> 2. Make `verifyLog` accept `String...` and check each expected line.
Also, retry reading the file until it has enough lines instead of being
non-empty.
In this test for the base framework of audit logging, we invoke verifyLog
each time a log worthy event has occurred. So at any time, the recent event is
the only event in the audit log. Hence we verify only one line at a time as
they are invoked by different tests.
> 3. I think using `assertEquals` would make it easier to spot differences
between expected and actual values. (I'm not sure case-ignorance is really
important. Currently the test passes with strict case check, too.)
Again, since the test was for base audit logging framework, strict checking
was required in the original.
That said, the goal of current jira is only to move away from using
ArrayList#remove.
I have filed HDDS-1889 to address the multi-line log scenario that will
cover your suggestions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 286734)
Time Spent: 50m (was: 40m)
> Use ArrayList#clear to address audit failure scenario
> -
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=286715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286715
]
ASF GitHub Bot logged work on HDDS-1886:
Author: ASF GitHub Bot
Created on: 01/Aug/19 13:39
Start Date: 01/Aug/19 13:39
Worklog Time Spent: 10m
Work Description: dineshchitlangia commented on pull request #1205:
HDDS-1886. Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r309700845
##
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
-lines.remove(0);
+lines.clear();
Review comment:
@adoroszlai Thanks for review & suggestions.
> 1. Wrap assertions and cleanup in `try` and `finally`, respectively.
Otherwise a failed assertion would cause all further independent test cases to
also fail due to leftover content in the file. (This one is not specific to
multi-line cases.)
Yes, that was the original approach, however, the review at the time
preferred to throw the Exception instead of catching it. This is because we
won't accept a few failures, the criteria required is all tests must pass.
> 2. Make `verifyLog` accept `String...` and check each expected line.
Also, retry reading the file until it has enough lines instead of being
non-empty.
In this test for the base framework of audit logging, we invoke verifyLog
each time a log worthy event has occurred. So at any time, the recent event is
the only event in the audit log. Hence we verify only one line at a time as
they are invoked by different tests.
> 3. I think using `assertEquals` would make it easier to spot differences
between expected and actual values. (I'm not sure case-ignorance is really
important. Currently the test passes with strict case check, too.)
Again, since the test was for base audit logging framework, strict checking
was required in the original.
That said, the goal of current jira is only to move away from using
ArrayList#remove. I will file a jira to refactor this test class so that it
doesn't rely on hard coded messages. We can address any other suggestions in
that jira.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 286715)
Time Spent: 40m (was: 0.5h)
> Use ArrayList#clear to address audit failure scenario
> -
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[
https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=286580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286580
]
ASF GitHub Bot logged work on HDDS-1886:
Author: ASF GitHub Bot
Created on: 01/Aug/19 09:34
Start Date: 01/Aug/19 09:34
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1205: HDDS-1886.
Use ArrayList#clear to address audit failure scenario
URL: https://github.com/apache/hadoop/pull/1205#discussion_r309608143
##
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java
##
@@ -153,7 +153,7 @@ private void verifyLog(String expected) throws IOException
{
assertTrue(lines.size() != 0);
assertTrue(expected.equalsIgnoreCase(lines.get(0)));
//empty the file
-lines.remove(0);
+lines.clear();
Review comment:
@dineshchitlangia good idea to avoid unnecessary assumptions.
Here are some further suggestions:
1. Wrap assertions and cleanup in `try` and `finally`, respectively.
Otherwise a failed assertion would cause all further independent test cases to
also fail due to leftover content in the file. (This one is not specific to
multi-line cases.)
2. Make `verifyLog` accept `String...` and check each expected line. Also,
retry reading the file until it has enough lines instead of being non-empty.
3. I think using `assertEquals` would make it easier to spot differences
between expected and actual values. (I'm not sure case-ignorance is really
important. Currently the test passes with strict case check, too.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 286580)
Time Spent: 0.5h (was: 20m)
> Use ArrayList#clear to address audit failure scenario
> -
>
> Key: HDDS-1886
> URL: https://issues.apache.org/jira/browse/HDDS-1886
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in
> between test runs.
> When writing tests in future for more failures scenarios, the tests will fail
> if the log entry has multi-line stack trace in audit logs.
> This jira aims to use ArrayList#clear to make the test future proof.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=286453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286453 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 01/Aug/19 06:14 Start Date: 01/Aug/19 06:14 Worklog Time Spent: 10m Work Description: dineshchitlangia commented on issue #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205#issuecomment-517135846 /label ozone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 286453) Time Spent: 20m (was: 10m) > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in > between test runs. > When writing tests in future for more failures scenarios, the tests will fail > if the log entry has multi-line stack trace in audit logs. > This jira aims to use ArrayList#clear to make the test future proof. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1886) Use ArrayList#clear to address audit failure scenario
[ https://issues.apache.org/jira/browse/HDDS-1886?focusedWorklogId=286447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286447 ] ASF GitHub Bot logged work on HDDS-1886: Author: ASF GitHub Bot Created on: 01/Aug/19 06:07 Start Date: 01/Aug/19 06:07 Worklog Time Spent: 10m Work Description: dineshchitlangia commented on pull request #1205: HDDS-1886. Use ArrayList#clear to address audit failure scenario URL: https://github.com/apache/hadoop/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 286447) Time Spent: 10m Remaining Estimate: 0h > Use ArrayList#clear to address audit failure scenario > - > > Key: HDDS-1886 > URL: https://issues.apache.org/jira/browse/HDDS-1886 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test >Reporter: Dinesh Chitlangia >Assignee: Dinesh Chitlangia >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > TestOzoneAuditLogger makes use of ArrayList#remove to clear the log file in > between test runs. > When writing tests in future for more failures scenarios, the tests will fail > if the log entry has multi-line stack trace in audit logs. > This jira aims to use ArrayList#clear to make the test future proof. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
