[jira] [Work logged] (HDFS-15565) Remove the invalid code in the Balancer#doBalance() method.

2020-09-10 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-15565?focusedWorklogId=481275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481275
 ]

ASF GitHub Bot logged work on HDFS-15565:
-

Author: ASF GitHub Bot
Created on: 10/Sep/20 06:45
Start Date: 10/Sep/20 06:45
Worklog Time Spent: 10m 
  Work Description: jianghuazhu commented on a change in pull request #2292:
URL: https://github.com/apache/hadoop/pull/2292#discussion_r486101882



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
##
@@ -705,7 +705,6 @@ static private int doBalance(Collection namenodes,
 LOG.info("excluded nodes = " + p.getExcludedNodes());
 LOG.info("source nodes = " + p.getSourceNodes());
 checkKeytabAndInit(conf);
-System.out.println("Time Stamp   Iteration#  Bytes Already 
Moved  Bytes Left To Move  Bytes Being Moved");

Review comment:
   ok 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 481275)
Time Spent: 50m  (was: 40m)

> Remove the invalid code in the Balancer#doBalance() method.
> ---
>
> Key: HDFS-15565
> URL: https://issues.apache.org/jira/browse/HDFS-15565
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: balancer  mover
>Reporter: jianghua zhu
>Assignee: jianghua zhu
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.3.0
>
> Attachments: HDFS-15565.001.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In the Balancer#doBalance() method, an invalid line of code is added, as 
> follows:
>  static private int doBalance(Collection namenodes,
>  Collection nsIds, final BalancerParameters p, Configuration conf)
>  throws IOException, InterruptedException
> { ... System.out.println("Time Stamp Iteration# Bytes Already Moved Bytes 
> Left To Move Bytes Being Moved"); ... }
>  
> I think it was originally used for testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-15565) Remove the invalid code in the Balancer#doBalance() method.

2020-09-09 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-15565?focusedWorklogId=481219=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481219
 ]

ASF GitHub Bot logged work on HDFS-15565:
-

Author: ASF GitHub Bot
Created on: 10/Sep/20 04:00
Start Date: 10/Sep/20 04:00
Worklog Time Spent: 10m 
  Work Description: Hexiaoqiao closed pull request #2292:
URL: https://github.com/apache/hadoop/pull/2292


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 481219)
Time Spent: 40m  (was: 0.5h)

> Remove the invalid code in the Balancer#doBalance() method.
> ---
>
> Key: HDFS-15565
> URL: https://issues.apache.org/jira/browse/HDFS-15565
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: balancer  mover
>Reporter: jianghua zhu
>Assignee: jianghua zhu
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.3.0
>
> Attachments: HDFS-15565.001.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In the Balancer#doBalance() method, an invalid line of code is added, as 
> follows:
>  static private int doBalance(Collection namenodes,
>  Collection nsIds, final BalancerParameters p, Configuration conf)
>  throws IOException, InterruptedException
> { ... System.out.println("Time Stamp Iteration# Bytes Already Moved Bytes 
> Left To Move Bytes Being Moved"); ... }
>  
> I think it was originally used for testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-15565) Remove the invalid code in the Balancer#doBalance() method.

2020-09-09 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-15565?focusedWorklogId=480919=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480919
 ]

ASF GitHub Bot logged work on HDFS-15565:
-

Author: ASF GitHub Bot
Created on: 09/Sep/20 16:43
Start Date: 09/Sep/20 16:43
Worklog Time Spent: 10m 
  Work Description: sunchao commented on a change in pull request #2292:
URL: https://github.com/apache/hadoop/pull/2292#discussion_r485763717



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
##
@@ -705,7 +705,6 @@ static private int doBalance(Collection namenodes,
 LOG.info("excluded nodes = " + p.getExcludedNodes());
 LOG.info("source nodes = " + p.getSourceNodes());
 checkKeytabAndInit(conf);
-System.out.println("Time Stamp   Iteration#  Bytes Already 
Moved  Bytes Left To Move  Bytes Being Moved");

Review comment:
   Hmm why you think this is not valid? I thought this is the header line 
for the balancer progress.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 480919)
Time Spent: 0.5h  (was: 20m)

> Remove the invalid code in the Balancer#doBalance() method.
> ---
>
> Key: HDFS-15565
> URL: https://issues.apache.org/jira/browse/HDFS-15565
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: balancer  mover
>Reporter: jianghua zhu
>Assignee: jianghua zhu
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.3.0
>
> Attachments: HDFS-15565.001.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In the Balancer#doBalance() method, an invalid line of code is added, as 
> follows:
>  static private int doBalance(Collection namenodes,
>  Collection nsIds, final BalancerParameters p, Configuration conf)
>  throws IOException, InterruptedException
> { ... System.out.println("Time Stamp Iteration# Bytes Already Moved Bytes 
> Left To Move Bytes Being Moved"); ... }
>  
> I think it was originally used for testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-15565) Remove the invalid code in the Balancer#doBalance() method.

2020-09-09 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-15565?focusedWorklogId=480913=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480913
 ]

ASF GitHub Bot logged work on HDFS-15565:
-

Author: ASF GitHub Bot
Created on: 09/Sep/20 16:23
Start Date: 09/Sep/20 16:23
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2292:
URL: https://github.com/apache/hadoop/pull/2292#issuecomment-689671513


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 42s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  34m 51s |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 32s |  trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |   1m 12s |  trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   0m 50s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 30s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m  8s |  branch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 22s |  trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   2m 56s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 54s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  6s |  the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javac  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  2s |  the patch passed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  javac  |   1m  2s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 33 unchanged - 1 
fixed = 33 total (was 34)  |
   | +1 :green_heart: |  mvnsite  |   1m 10s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedclient  |  13m 53s |  patch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 48s |  the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 21s |  the patch passed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  findbugs  |   2m 58s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 100m  8s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 40s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 190m 43s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
   |   | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
   |   | hadoop.hdfs.TestFileChecksumCompositeCrc |
   |   | hadoop.hdfs.TestStripedFileAppend |
   |   | hadoop.hdfs.TestFileChecksum |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2292/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2292 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux ccd0b8079a2d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 773ac799c63 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | unit |

[jira] [Work logged] (HDFS-15565) Remove the invalid code in the Balancer#doBalance() method.

2020-09-09 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-15565?focusedWorklogId=480802=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480802
 ]

ASF GitHub Bot logged work on HDFS-15565:
-

Author: ASF GitHub Bot
Created on: 09/Sep/20 13:11
Start Date: 09/Sep/20 13:11
Worklog Time Spent: 10m 
  Work Description: jianghuazhu opened a new pull request #2292:
URL: https://github.com/apache/hadoop/pull/2292


   ## NOTICE
   
   Please create an issue in ASF JIRA before opening a pull request,
   and you need to set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. HADOOP-X. Fix a typo in YYY.)
   For more details, please see 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 480802)
Remaining Estimate: 0h
Time Spent: 10m

> Remove the invalid code in the Balancer#doBalance() method.
> ---
>
> Key: HDFS-15565
> URL: https://issues.apache.org/jira/browse/HDFS-15565
> Project: Hadoop HDFS
>  Issue Type: Improvement
>  Components: balancer  mover
>Reporter: jianghua zhu
>Assignee: jianghua zhu
>Priority: Major
> Fix For: 3.3.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the Balancer#doBalance() method, an invalid line of code is added, as 
> follows:
> static private int doBalance(Collection namenodes,
>  Collection nsIds, final BalancerParameters p, Configuration conf)
>  throws IOException, InterruptedException {
> ...
> System.out.println("Time Stamp Iteration# Bytes Already Moved Bytes Left To 
> Move Bytes Being Moved");
> ...
> }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org