[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946160#comment-16946160
]
Hadoop QA commented on HDDS-1868:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939048#comment-16939048
]
Siddharth Wagle commented on HDDS-1868:
---
Just realized while writing the UT that we create pipeline
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939004#comment-16939004
]
Siddharth Wagle commented on HDDS-1868:
---
HI [~ljain] cna you take a look at 5, addressed all other
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937952#comment-16937952
]
Siddharth Wagle commented on HDDS-1868:
---
Hi [~ljain], regarding 3., the setLeaderId is called for
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937742#comment-16937742
]
Lokesh Jain commented on HDDS-1868:
---
[~swagle] Thanks for updating the patch! The changes look good to
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936409#comment-16936409
]
Hadoop QA commented on HDDS-1868:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936379#comment-16936379
]
Hadoop QA commented on HDDS-1868:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936374#comment-16936374
]
Siddharth Wagle commented on HDDS-1868:
---
[~ljain] Can you please review new changes in this patch
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933607#comment-16933607
]
Siddharth Wagle commented on HDDS-1868:
---
[~ljain] Fair point. If s2 and s3 don't report SCM will
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933383#comment-16933383
]
Lokesh Jain commented on HDDS-1868:
---
[~swagle] I think there is a case where it is not handled. There
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932745#comment-16932745
]
Siddharth Wagle commented on HDDS-1868:
---
Hi [~ljain], but with my latest change, all peers send
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932224#comment-16932224
]
Lokesh Jain commented on HDDS-1868:
---
[~swagle] Thanks for working on this! I think we should include
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929605#comment-16929605
]
Hadoop QA commented on HDDS-1868:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929599#comment-16929599
]
Siddharth Wagle commented on HDDS-1868:
---
Hi [~ljain]/[~msingh] can you guys take a look? Patch needs
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927278#comment-16927278
]
Lokesh Jain commented on HDDS-1868:
---
ContainerStateMachine already has an api called notifyLeader which
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927259#comment-16927259
]
Siddharth Wagle commented on HDDS-1868:
---
Do you think it makes sense to add a callback like
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926426#comment-16926426
]
Lokesh Jain commented on HDDS-1868:
---
[~swagle] The changes look good to me. I am not able to open the
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926246#comment-16926246
]
Hadoop QA commented on HDDS-1868:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925401#comment-16925401
]
Lokesh Jain commented on HDDS-1868:
---
[~swagle] In the patch below condition would only be true for the
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925365#comment-16925365
]
Siddharth Wagle commented on HDDS-1868:
---
Hi [~ljain], in my unit test I am able to get the
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923662#comment-16923662
]
Siddharth Wagle commented on HDDS-1868:
---
Yes, you are right, nto sure why I thought report includes
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923635#comment-16923635
]
Lokesh Jain commented on HDDS-1868:
---
On restart, SCM marks the pipeline as OPEN only if all the
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923628#comment-16923628
]
Siddharth Wagle commented on HDDS-1868:
---
[~ljain] But the pipeline report from the leader will
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923519#comment-16923519
]
Lokesh Jain commented on HDDS-1868:
---
[~swagle] Thanks for working on this! I think leaderInfo in
[
https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919010#comment-16919010
]
Siddharth Wagle commented on HDDS-1868:
---
[~msingh] Attaching a preliminary patch to get feedback
25 matches
Mail list logo