[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-10-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946160#comment-16946160 ] Hadoop QA commented on HDDS-1868: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-26 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939048#comment-16939048 ] Siddharth Wagle commented on HDDS-1868: --- Just realized while writing the UT that we create pipeline

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-26 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939004#comment-16939004 ] Siddharth Wagle commented on HDDS-1868: --- HI [~ljain] cna you take a look at 5, addressed all other

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-25 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937952#comment-16937952 ] Siddharth Wagle commented on HDDS-1868: --- Hi [~ljain], regarding 3., the setLeaderId is called for

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-25 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937742#comment-16937742 ] Lokesh Jain commented on HDDS-1868: --- [~swagle] Thanks for updating the patch! The changes look good to

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936409#comment-16936409 ] Hadoop QA commented on HDDS-1868: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936379#comment-16936379 ] Hadoop QA commented on HDDS-1868: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-23 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936374#comment-16936374 ] Siddharth Wagle commented on HDDS-1868: --- [~ljain] Can you please review new changes in this patch

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-19 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933607#comment-16933607 ] Siddharth Wagle commented on HDDS-1868: --- [~ljain] Fair point. If s2 and s3 don't report SCM will

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-19 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933383#comment-16933383 ] Lokesh Jain commented on HDDS-1868: --- [~swagle] I think there is a case where it is not handled. There

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-18 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932745#comment-16932745 ] Siddharth Wagle commented on HDDS-1868: --- Hi [~ljain], but with my latest change, all peers send

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-18 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932224#comment-16932224 ] Lokesh Jain commented on HDDS-1868: --- [~swagle] Thanks for working on this! I think we should include

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929605#comment-16929605 ] Hadoop QA commented on HDDS-1868: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-13 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929599#comment-16929599 ] Siddharth Wagle commented on HDDS-1868: --- Hi [~ljain]/[~msingh] can you guys take a look? Patch needs

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-11 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927278#comment-16927278 ] Lokesh Jain commented on HDDS-1868: --- ContainerStateMachine already has an api called notifyLeader which

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-10 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927259#comment-16927259 ] Siddharth Wagle commented on HDDS-1868: --- Do you think it makes sense to add a callback like

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-10 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926426#comment-16926426 ] Lokesh Jain commented on HDDS-1868: --- [~swagle] The changes look good to me. I am not able to open the

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926246#comment-16926246 ] Hadoop QA commented on HDDS-1868: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-09 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925401#comment-16925401 ] Lokesh Jain commented on HDDS-1868: --- [~swagle] In the patch below condition would only be true for the

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-08 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925365#comment-16925365 ] Siddharth Wagle commented on HDDS-1868: --- Hi [~ljain], in my unit test I am able to get the

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-05 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923662#comment-16923662 ] Siddharth Wagle commented on HDDS-1868: --- Yes, you are right, nto sure why I thought report includes

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-05 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923635#comment-16923635 ] Lokesh Jain commented on HDDS-1868: --- On restart, SCM marks the pipeline as OPEN only if all the

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-05 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923628#comment-16923628 ] Siddharth Wagle commented on HDDS-1868: --- [~ljain] But the pipeline report from the leader will

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-09-05 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923519#comment-16923519 ] Lokesh Jain commented on HDDS-1868: --- [~swagle] Thanks for working on this! I think leaderInfo in 

[jira] [Commented] (HDDS-1868) Ozone pipelines should be marked as ready only after the leader election is complete

2019-08-29 Thread Siddharth Wagle (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919010#comment-16919010 ] Siddharth Wagle commented on HDDS-1868: --- [~msingh] Attaching a preliminary patch to get feedback