[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819526#comment-15819526 ] Manoj Govindassamy commented on HDFS-10930: --- Got it. Thanks [~arpitagarwal]. >

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819522#comment-15819522 ] Manoj Govindassamy commented on HDFS-10930: --- I did check ReplicaOutputStreams an

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819510#comment-15819510 ] Arpit Agarwal commented on HDFS-10930: -- Hi [~manojg], the log message was removed by

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819480#comment-15819480 ] Xiaoyu Yao commented on HDFS-10930: --- [~manojg], the Slow logging was moved to ReplicaOut

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819461#comment-15819461 ] Manoj Govindassamy commented on HDFS-10930: --- [~xyao], [~arpitagarwal], When wri

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805981#comment-15805981 ] Xiaoyu Yao commented on HDFS-10930: --- Looks good to me. Thanks [~arpitagarwal] for taking

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805554#comment-15805554 ] Arpit Agarwal commented on HDFS-10930: -- The local test-patch run for branch-2 came ba

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752476#comment-15752476 ] Xiaoyu Yao commented on HDFS-10930: --- Thanks [~arpitagarwal] for the review. That 's a go

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752433#comment-15752433 ] Arpit Agarwal commented on HDFS-10930: -- Thanks for the branch-2 patch [~xyao]. Just o

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737003#comment-15737003 ] Andrew Wang commented on HDFS-10930: Once there's a PR, precommit bot can't process pa

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726966#comment-15726966 ] ASF GitHub Bot commented on HDFS-10930: --- Github user xiaoyuyao closed the pull reque

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726965#comment-15726965 ] ASF GitHub Bot commented on HDFS-10930: --- Github user xiaoyuyao commented on the issu

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726534#comment-15726534 ] Hudson commented on HDFS-10930: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726529#comment-15726529 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726375#comment-15726375 ] Xiaoyu Yao commented on HDFS-10930: --- Thanks [~arpitagarwal]. The Github PR 170 matches

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726289#comment-15726289 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726167#comment-15726167 ] Arpit Agarwal commented on HDFS-10930: -- Thanks [~xyao]. +1 for the v11 patch. I assu

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725951#comment-15725951 ] Xiaoyu Yao commented on HDFS-10930: --- Seems like Jenkins finally picked up the new [Githu

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724475#comment-15724475 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724397#comment-15724397 ] ASF GitHub Bot commented on HDFS-10930: --- GitHub user xiaoyuyao opened a pull request

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723932#comment-15723932 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723611#comment-15723611 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710712#comment-15710712 ] Brahma Reddy Battula commented on HDFS-10930: - *Regarding Trunk commit.* 1)

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710456#comment-15710456 ] Arpit Agarwal commented on HDFS-10930: -- Sigh.. I am not sure how to get Jenkins to st

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710452#comment-15710452 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710418#comment-15710418 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710386#comment-15710386 ] Arpit Agarwal commented on HDFS-10930: -- +1 for the branch-2 patch, pending Jenkins. T

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707674#comment-15707674 ] Xiaoyu Yao commented on HDFS-10930: --- Thanks [~arpitagarwal] for the review and commit. I

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707104#comment-15707104 ] Arpit Agarwal commented on HDFS-10930: -- Jenkins seems to be hopelessly confused as it

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706915#comment-15706915 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706582#comment-15706582 ] Xiaoyu Yao commented on HDFS-10930: --- Remove the PR link and resubmit for Jenkins. > Ref

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706571#comment-15706571 ] ASF GitHub Bot commented on HDFS-10930: --- Github user xiaoyuyao closed the pull reque

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703819#comment-15703819 ] Arpit Agarwal commented on HDFS-10930: -- +1 for the v07 patch pending Jenkins. Thanks

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703763#comment-15703763 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688196#comment-15688196 ] Arpit Agarwal commented on HDFS-10930: -- The findbugs issue looks valid. It can be add

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668300#comment-15668300 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667991#comment-15667991 ] Arpit Agarwal commented on HDFS-10930: -- +1 pending Jenkins (just started a manual bui

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665882#comment-15665882 ] ASF GitHub Bot commented on HDFS-10930: --- Github user xiaoyuyao commented on the issu

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665713#comment-15665713 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665422#comment-15665422 ] Arpit Agarwal commented on HDFS-10930: -- Mirroring comment from Github: Thanks [~xyao

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15659844#comment-15659844 ] ASF GitHub Bot commented on HDFS-10930: --- GitHub user xiaoyuyao opened a pull request

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658667#comment-15658667 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656266#comment-15656266 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608894#comment-15608894 ] Xiaoyu Yao commented on HDFS-10930: --- The instrumentation wrappers are moved into non-sta

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569242#comment-15569242 ] Xiaoyu Yao commented on HDFS-10930: --- Thanks [~daryn] for the feedback. I've put my answe

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569080#comment-15569080 ] Daryn Sharp commented on HDFS-10930: Took a cursory look, do we really need to move no

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566909#comment-15566909 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10930) Refactor: Wrap Datanode IO related operations

[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556717#comment-15556717 ] Hadoop QA commented on HDFS-10930: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote