[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2018-01-08 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317278#comment-16317278
 ] 

Hudson commented on HDFS-12945:
---

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13461 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/13461/])
HDFS-12945. Switch to ClientProtocol instead of NamenodeProtocols in (weiy: rev 
2ee0d64aceed876f57f09eb9efe1872b6de98d2e)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java


> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
> Attachments: HDFS-12945.000.patch, HDFS-12945.001.patch, 
> HDFS-12945.002.patch
>
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2018-01-08 Thread Wei Yan (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317139#comment-16317139
 ] 

Wei Yan commented on HDFS-12945:


TestDataNodeVolumeFailureReporting passed in my local, and the above test error 
doesn't look related to the change. I'll commit the patch soon.

> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
> Attachments: HDFS-12945.000.patch, HDFS-12945.001.patch, 
> HDFS-12945.002.patch
>
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2018-01-08 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317112#comment-16317112
 ] 

Íñigo Goiri commented on HDFS-12945:


{{TestDataNodeVolumeFailureReporting}} seemed to fial before; it seems spurious 
to me but do you mind checking?
Otherwise +1 on [^HDFS-12945.002.patch] too.

> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
> Attachments: HDFS-12945.000.patch, HDFS-12945.001.patch, 
> HDFS-12945.002.patch
>
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2018-01-08 Thread genericqa (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317104#comment-16317104
 ] 

genericqa commented on HDFS-12945:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 
 2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 24s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} hadoop-hdfs-project/hadoop-hdfs: The patch generated 
0 new + 117 unchanged - 3 fixed = 117 total (was 120) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 57s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}129m 30s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}186m 36s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | HDFS-12945 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12905132/HDFS-12945.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 4f30e348e745 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 01f3f21 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/22604/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/22604/testReport/ |
| Max. process+thread count | 3128 (vs. ulimit of 5000) |
| modules | C: 

[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2018-01-08 Thread Wei Yan (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316576#comment-16316576
 ] 

Wei Yan commented on HDFS-12945:


Thanks [~elgoiri]. Sorry for the late reply, just back from vacation. I'll 
rebase a new patch and commit it tonight, if no concern from other folks.

> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
> Attachments: HDFS-12945.000.patch, HDFS-12945.001.patch
>
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2018-01-05 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313811#comment-16313811
 ] 

Íñigo Goiri commented on HDFS-12945:


[~ywskycn], I would move forward committing [^HDFS-12945.001.patch] as some 
time has passed already and this change shouldn't have any implications.
This would unblock HDFS-12512.

> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
> Attachments: HDFS-12945.000.patch, HDFS-12945.001.patch
>
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2017-12-20 Thread genericqa (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299051#comment-16299051
 ] 

genericqa commented on HDFS-12945:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}  
9m 51s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
41s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant 
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
31s{color} | {color:green} hadoop-hdfs-project/hadoop-hdfs: The patch generated 
0 new + 117 unchanged - 3 fixed = 117 total (was 120) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}  
9m 25s{color} | {color:green} patch has no errors when building and testing our 
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}125m 28s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}186m 41s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
|   | hadoop.hdfs.web.TestWebHdfsTimeouts |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure |
|   | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | HDFS-12945 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12903078/HDFS-12945.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux bcde494e1541 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 
11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 13ad747 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| findbugs | 

[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2017-12-20 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298715#comment-16298715
 ] 

Íñigo Goiri commented on HDFS-12945:


The checkstyles were technically already there but it doesn't hurt to fix them.
I don't think this changes the behavior and it makes HDFS-12512 much cleaner.
Other than fixing the check styles, +1

> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
> Attachments: HDFS-12945.000.patch
>
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2017-12-19 Thread genericqa (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297996#comment-16297996
 ] 

genericqa commented on HDFS-12945:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 23s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
51s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant 
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 35s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch 
generated 2 new + 117 unchanged - 3 fixed = 119 total (was 120) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 48s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 30s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}134m 39s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | HDFS-12945 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12902971/HDFS-12945.000.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 4be6d4e17b43 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 41b5810 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/22465/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
 |
| checkstyle | 

[jira] [Commented] (HDFS-12945) Switch to ClientProtocol instead of NamenodeProtocols in NamenodeWebHdfsMethods

2017-12-19 Thread JIRA

[ 
https://issues.apache.org/jira/browse/HDFS-12945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297823#comment-16297823
 ] 

Íñigo Goiri commented on HDFS-12945:


>From the patch in HDFS-12512, I think it makes sense to do this change.

> Switch to ClientProtocol instead of NamenodeProtocols in 
> NamenodeWebHdfsMethods
> ---
>
> Key: HDFS-12945
> URL: https://issues.apache.org/jira/browse/HDFS-12945
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Wei Yan
>Assignee: Wei Yan
>Priority: Minor
>
> In HDFS-12512 which is to add WebHDFS support to Router-based Federation, we 
> found it would be good to switch from NamenodeProtocols to ClientProtocol in 
> NamenodeWebHdfsMethods, to make code sharable between NameNode WebHDFS and 
> Router WebHDFS. Would like to get some feedbacks about this refactor, any 
> concerns?
> cc [~elgoiri] [~szetszwo] [~sanjay.radia]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org