[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377954#comment-16377954 ] Chalchiuhticue Naabah commented on HDFS-13184: -- Many thanks for your input, [instagram search|http://imgaram.com/] > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Labels: RBF > Fix For: 3.1.0, 2.10.0, 2.9.1, 3.0.2, 3.2.0 > > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch, > HDFS-13184.003.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377936#comment-16377936 ] Hudson commented on HDFS-13184: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13723 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13723/]) HDFS-13184. RBF: Improve the unit test TestRouterRPCClientRetries. (yqlin: rev 1e85a995d1c7fe3dbf4b36a481feb5fdeeb6015b) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRPCClientRetries.java > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Labels: RBF > Fix For: 3.1.0, 2.10.0, 2.9.1, 3.0.2, 3.2.0 > > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch, > HDFS-13184.003.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377214#comment-16377214 ] Íñigo Goiri commented on HDFS-13184: [^HDFS-13184.003.patch] LGTM. +1 > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch, > HDFS-13184.003.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376438#comment-16376438 ] Yiqun Lin commented on HDFS-13184: -- [Latest test|https://builds.apache.org/job/PreCommit-HDFS-Build/23197/testReport/org.apache.hadoop.hdfs.server.federation.router/TestRouterRPCClientRetries/] takes 13s and 11s. The change makes sense. > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch, > HDFS-13184.003.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376433#comment-16376433 ] genericqa commented on HDFS-13184: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 2s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 34s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 23s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}147m 17s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}201m 3s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA | | | hadoop.hdfs.server.namenode.TestFsck | | | hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness | | | hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics | | | hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean | | | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting | | | hadoop.hdfs.TestDFSClientRetries | | | hadoop.hdfs.server.namenode.TestReencryption | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | HDFS-13184 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12911977/HDFS-13184.003.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 666583bc904a 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 2fa7963 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | unit |
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376349#comment-16376349 ] Yiqun Lin commented on HDFS-13184: -- Thanks for the review, [~elgoiri]. Attach the updated patch for fixing the typo. > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch, > HDFS-13184.003.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376205#comment-16376205 ] Íñigo Goiri commented on HDFS-13184: Thanks [~linyiqun] for [^HDFS-13184.002.patch]. I think this is cleaner; in the future we may want to go over the {{RouterDFSCluster}} to make these overrides more intuitive (this is probably on me) to use but for now I think is good for now. Just one minor comment, there is a typo in {{clinetConf}}. > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375301#comment-16375301 ] genericqa commented on HDFS-13184: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 33s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 13s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 57s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 44s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 41s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}140m 42s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.TestLeaseRecovery2 | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | | | hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean | | | hadoop.hdfs.web.TestWebHdfsTimeouts | | | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | HDFS-13184 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12911859/HDFS-13184.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux cbb05c2c9a93 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 329a4fd | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23184/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23184/testReport/ | | Max. process+thread count | 4632 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375251#comment-16375251 ] Yiqun Lin commented on HDFS-13184: -- {quote}Regarding HDFS-13184.001.patch, it seems a little anti intuitive for it to be a namenode override when it's the Router client doing this. Shouldn't this be a setting for the Router itself? {quote} Seems making these client settings into Router conf, it won't make sense. The Router conf is used for building {{RouterContext}} in UT. I create a new client settings and override them in startcluster. Hope this way makes sense to you, [~elgoiri]. Attach the updated patch. > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch, HDFS-13184.002.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374829#comment-16374829 ] Íñigo Goiri commented on HDFS-13184: The [latest test|https://builds.apache.org/job/PreCommit-HDFS-Build/23168/testReport/org.apache.hadoop.hdfs.server.federation.router/TestRouterRPCClientRetries/] takes 14 and 12 seconds, so this is an improvement compared to the 40 and 16 we had before. Regarding [^HDFS-13184.001.patch], it seems a little anti intuitive for it to be a namenode override when it's the Router client doing this. Shouldn't this be a setting for the Router itself? > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374415#comment-16374415 ] genericqa commented on HDFS-13184: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 49s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 0s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 44s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 16s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}135m 2s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}183m 49s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA | | | hadoop.hdfs.web.TestWebHdfsTimeouts | | | hadoop.hdfs.server.namenode.ha.TestEditLogTailer | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | HDFS-13184 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12911710/HDFS-13184.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 19bddb515315 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / d1cd573 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23168/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23168/testReport/ | | Max. process+thread count | 3550 (vs. ulimit of 1) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | |
[jira] [Commented] (HDFS-13184) RBF: Improve the unit test TestRouterRPCClientRetries
[ https://issues.apache.org/jira/browse/HDFS-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374267#comment-16374267 ] Yiqun Lin commented on HDFS-13184: -- {quote}In addition, to reduce the creation of MiniDFSCluster, we could use BeforeClass {quote} [~elgoiri], I didn't address this, just want to make these tests clear. Otherwise, we should restart the shutdown nameservice in each test method. > RBF: Improve the unit test TestRouterRPCClientRetries > - > > Key: HDFS-13184 > URL: https://issues.apache.org/jira/browse/HDFS-13184 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: Yiqun Lin >Priority: Minor > Attachments: HDFS-13184.001.patch > > > From the proposal in this > https://issues.apache.org/jira/browse/HDFS-13119?focusedCommentId=16370421=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16370421, > this will speed the test. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org