[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740058#comment-16740058
]
Ayush Saxena commented on HDFS-13856:
-
No additions from my side.
I am good with v3 :)
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739936#comment-16739936
]
Íñigo Goiri commented on HDFS-13856:
[~ayushtkn] had comments in the past; any further comments?
>
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739919#comment-16739919
]
Fei Hui commented on HDFS-13856:
[~elgoiri] Thanks
Could you please commit it before codebase changes?
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737793#comment-16737793
]
Íñigo Goiri commented on HDFS-13856:
[^HDFS-13856-HDFS-13891.003.patch] LGTM.
The failed unit test
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735722#comment-16735722
]
Fei Hui commented on HDFS-13856:
[~elgoiri] [~cheersyang] [~ayushtkn] Any suggestions for v003 patch?
>
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734831#comment-16734831
]
Fei Hui commented on HDFS-13856:
Failed tests are unrelated.
[~ayushtkn] could you please take a look at
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732683#comment-16732683
]
Hadoop QA commented on HDFS-13856:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732584#comment-16732584
]
Fei Hui commented on HDFS-13856:
[~ayushtkn] Upload v003 patch. Add the command to HDFSCommands.md
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732245#comment-16732245
]
Ayush Saxena commented on HDFS-13856:
-
Thanx [~hfyang20071] for the patch.
I think the command needs
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732147#comment-16732147
]
Weiwei Yang commented on HDFS-13856:
Thanks for adding me in this loop [~ferhui]. Looks like
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731723#comment-16731723
]
Fei Hui commented on HDFS-13856:
[~Weiwei Yang] could you please ask somebody for reviewing this ? Thanks
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731422#comment-16731422
]
Íñigo Goiri commented on HDFS-13856:
[^HDFS-13856-HDFS-13891.002.patch] looks good.
In the
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728137#comment-16728137
]
Hadoop QA commented on HDFS-13856:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728107#comment-16728107
]
Fei Hui commented on HDFS-13856:
[~elgoiri] Upload v002 patch
* remove the extra line in the imports of
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726957#comment-16726957
]
Íñigo Goiri commented on HDFS-13856:
Thanks [~ferhui] for [^HDFS-13856-HDFS-13891.001.patch].
Minor
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726506#comment-16726506
]
Hadoop QA commented on HDFS-13856:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726470#comment-16726470
]
Fei Hui commented on HDFS-13856:
[~elgoiri] Rebase the code on branch HDFS-13891. Change "-refresh" to
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726453#comment-16726453
]
Hadoop QA commented on HDFS-13856:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726447#comment-16726447
]
Íñigo Goiri commented on HDFS-13856:
I think this should be part of HDFS-13891.
Moving it there.
Can
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726429#comment-16726429
]
Fei Hui commented on HDFS-13856:
[~elgoiri] rebase the code on branch trunk
> RBF: RouterAdmin should
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707678#comment-16707678
]
Íñigo Goiri commented on HDFS-13856:
I think we should do this as part of the branch.
Can you rebase?
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707112#comment-16707112
]
Hadoop QA commented on HDFS-13856:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707103#comment-16707103
]
Fei Hui commented on HDFS-13856:
Good catch! Could you please review it [~elgoiri] [~linyiqun]
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594462#comment-16594462
]
yanghuafeng commented on HDFS-13856:
Thans for your comments, [~elgoiri]
I have added the generic
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594069#comment-16594069
]
genericqa commented on HDFS-13856:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593972#comment-16593972
]
Íñigo Goiri commented on HDFS-13856:
I wasn't familiar with generic refresh and I had to go over the
26 matches
Mail list logo
