[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245678#comment-17245678
]
Takanobu Asanuma commented on HDFS-15240:
-
Thanks again, [~marvelrock] and [~ferhui]!
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245641#comment-17245641
]
Hui Fei commented on HDFS-15240:
[~marvelrock] Thanks for your patch, [~tasanuma] Thanks for review !
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245144#comment-17245144
]
Hui Fei commented on HDFS-15240:
Failed tests are unrelated, they passed locally. +1 on
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245042#comment-17245042
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244960#comment-17244960
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244918#comment-17244918
]
Hui Fei commented on HDFS-15240:
[~tasanuma] Thanks for review! Because branch-3.3 test is not triggered,
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244910#comment-17244910
]
Takanobu Asanuma commented on HDFS-15240:
-
+1 on [^HDFS-15240-branch-3.1-001.patch] and
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244406#comment-17244406
]
Xiaoqiao He commented on HDFS-15240:
cherry-pick to branch-3.2.2.
> Erasure Coding: dirty buffer
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244379#comment-17244379
]
HuangTao commented on HDFS-15240:
-
I have check and run the failed unit test
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244348#comment-17244348
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244245#comment-17244245
]
HuangTao commented on HDFS-15240:
-
Upload [^HDFS-15240-branch-3.1-001.patch] for branch-3.1 and
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244195#comment-17244195
]
Takanobu Asanuma commented on HDFS-15240:
-
BTW, I'm going to change this issue to blocker. All
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244187#comment-17244187
]
Takanobu Asanuma commented on HDFS-15240:
-
[~hexiaoqiao] I confirmed TestReconstructStripedFile
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244039#comment-17244039
]
Xiaoqiao He commented on HDFS-15240:
It seems failed unit test is not related with this issue. check
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244016#comment-17244016
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243887#comment-17243887
]
Xiaoqiao He commented on HDFS-15240:
reopen and add 3.2.2 as another target version.
upload
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243662#comment-17243662
]
Takanobu Asanuma commented on HDFS-15240:
-
Thanks for committing it, [~ferhui]!
[~marvelrock] We
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243631#comment-17243631
]
Hui Fei commented on HDFS-15240:
Cherry-pick fails because of conflicts. [~marvelrock] Could you please
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243630#comment-17243630
]
Hui Fei commented on HDFS-15240:
Push to trunk.
Thanks again [~marvelrock] for report and fix,
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242842#comment-17242842
]
Takanobu Asanuma commented on HDFS-15240:
-
I confirmed that the patch also worked well with
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242837#comment-17242837
]
Hui Fei commented on HDFS-15240:
Thanks [~marvelrock] for report and fix, [~umamaheswararao] [~tasanuma]
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242747#comment-17242747
]
Uma Maheswara Rao G commented on HDFS-15240:
+1 latest patch looks good to me.
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242648#comment-17242648
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242388#comment-17242388
]
HuangTao commented on HDFS-15240:
-
Thanks [~tasanuma] for your careful review. I address all your
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242355#comment-17242355
]
Takanobu Asanuma commented on HDFS-15240:
-
This bug seems to have been since Hadoop-3.0.0 was
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240532#comment-17240532
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240439#comment-17240439
]
HuangTao commented on HDFS-15240:
-
Upload [^HDFS-15240.012.patch] to fix flaky test case.
The test cases
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240416#comment-17240416
]
Hui Fei commented on HDFS-15240:
[~umamaheswararao] Could you please take a look again ? Thanks!
>
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240038#comment-17240038
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239878#comment-17239878
]
Hui Fei commented on HDFS-15240:
[~marvelrock] Thanks. It's great, [^HDFS-15240.010.patch] looks better
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239657#comment-17239657
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239639#comment-17239639
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239546#comment-17239546
]
HuangTao commented on HDFS-15240:
-
Upload [^HDFS-15240.010.patch] to add a new function
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239509#comment-17239509
]
Hui Fei commented on HDFS-15240:
Trigger jenkins
> Erasure Coding: dirty buffer causes reconstruction
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239090#comment-17239090
]
HuangTao commented on HDFS-15240:
-
Upload [^HDFS-15240.009.patch] to address
??Either we have to make
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239039#comment-17239039
]
HuangTao commented on HDFS-15240:
-
The NPE fails the reconstruction and close the striped
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238943#comment-17238943
]
Uma Maheswara Rao G commented on HDFS-15240:
I think the latest patch mostly looks good to
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232775#comment-17232775
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232608#comment-17232608
]
HuangTao commented on HDFS-15240:
-
Upload [^HDFS-15240.008.patch] for fixing checkstyle.
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232588#comment-17232588
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232477#comment-17232477
]
HuangTao commented on HDFS-15240:
-
Thanks [~ferhui] [~umamaheswararao] for your comments. I upload
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230489#comment-17230489
]
Uma Maheswara Rao G commented on HDFS-15240:
HI [~marvelrock] Thanks a lot for working on
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225810#comment-17225810
]
HuangTao commented on HDFS-15240:
-
Thanks for your suggestion, [~ferhui] I will change that later.
>
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225269#comment-17225269
]
Hui Fei commented on HDFS-15240:
One more comment
* There are some sleeps for waiting as following, Could
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225229#comment-17225229
]
Hui Fei commented on HDFS-15240:
[~marvelrock] Thanks for contribution. It overall looks good. some minor
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224408#comment-17224408
]
Hui Fei commented on HDFS-15240:
[~touchida] [~marvelrock] Thanks for check, I will take a look later.
>
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224396#comment-17224396
]
HuangTao commented on HDFS-15240:
-
Thanks for your work, [~touchida]. I checked again and got the same
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223584#comment-17223584
]
Toshihiko Uchida commented on HDFS-15240:
-
@Hui Fei The unit tests without the fix failed on
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211704#comment-17211704
]
Hui Fei commented on HDFS-15240:
[~marvelrock] Test case you added without your fix also pass
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209985#comment-17209985
]
Hui Fei commented on HDFS-15240:
OK! I will take a look
> Erasure Coding: dirty buffer causes
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209917#comment-17209917
]
Wei-Chiu Chuang commented on HDFS-15240:
[~ferhui] could you review this patch? Looks like a
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194932#comment-17194932
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179461#comment-17179461
]
HuangTao commented on HDFS-15240:
-
No problem, [~ferhui] I will work on that later
> Erasure Coding:
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179393#comment-17179393
]
Fei Hui commented on HDFS-15240:
[~marvelrock] Fail to apply your patch on trunk branch. Could you please
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159804#comment-17159804
]
HuangTao commented on HDFS-15240:
-
Could you please help me review that ? [~weichiu]
I think this is a
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158991#comment-17158991
]
Hongbing Wang commented on HDFS-15240:
--
[~marvelrock] We have the same problem. At the same time as
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083820#comment-17083820
]
maobaolong commented on HDFS-15240:
---
What a great job you did, look forward to your patch in the trunk
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079067#comment-17079067
]
Wu Weiwei commented on HDFS-15240:
--
We have the same problem, Our cluster of several thousand units
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077758#comment-17077758
]
guo commented on HDFS-15240:
Nice job, LGTM.
> Erasure Coding: dirty buffer causes reconstruction block
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077745#comment-17077745
]
HuangTao commented on HDFS-15240:
-
Hi watchers, anyone would like to help take a review?
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075854#comment-17075854
]
HuangTao commented on HDFS-15240:
-
the failed test is unrelated with this patch. [~weichiu] PTAL, Thanks
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075851#comment-17075851
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075760#comment-17075760
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075078#comment-17075078
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075021#comment-17075021
]
HuangTao commented on HDFS-15240:
-
fix checkstyle and the unit case
> Erasure Coding: dirty buffer
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074946#comment-17074946
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073396#comment-17073396
]
HuangTao commented on HDFS-15240:
-
[~weichiu] I'm working on that, I will upload another patch later
>
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072030#comment-17072030
]
Wei-Chiu Chuang commented on HDFS-15240:
[~marvelrock] could you double check the patch again?
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068170#comment-17068170
]
Hadoop QA commented on HDFS-15240:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067871#comment-17067871
]
HuangTao commented on HDFS-15240:
-
I will try to add an UT
> Erasure Coding: dirty buffer causes
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067682#comment-17067682
]
Fei Hui commented on HDFS-15240:
[~marvelrock] Good Catch ! Thanks for reporting and fixing.
Could you
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067569#comment-17067569
]
Yao Guangdong commented on HDFS-15240:
--
[~weichiu] We have the same problem. PTAL.
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067559#comment-17067559
]
guojh commented on HDFS-15240:
--
[~surendrasingh] We have the same problem，please take a look.
> Erasure
[
https://issues.apache.org/jira/browse/HDFS-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067539#comment-17067539
]
HuangTao commented on HDFS-15240:
-
[~weichiu] PTAL, Thanks
> Erasure Coding: dirty buffer causes
74 matches
Mail list logo
