[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14021639#comment-14021639
]
Junping Du commented on HDFS-6362:
--
Hi [~arpitagarwal], I saw TestBalancerWithNodeGroup failed again here which
shouldn't happen after HDFS-6250. Some suspect is on recently changea on
InvalidateBlocks (please see analysis in HDFS-6159). Would you mind to take a
look at it? Thx!
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002938#comment-14002938
]
Hudson commented on HDFS-6362:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5606 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5606/])
HDFS-6362. InvalidateBlocks is inconsistent in usage of DatanodeUuid and
StorageID. (Arpit Agarwal) (arp:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595056)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003246#comment-14003246
]
Hudson commented on HDFS-6362:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #562 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/562/])
HDFS-6362. InvalidateBlocks is inconsistent in usage of DatanodeUuid and
StorageID. (Arpit Agarwal) (arp:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595056)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003281#comment-14003281
]
Hudson commented on HDFS-6362:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1754 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1754/])
HDFS-6362. InvalidateBlocks is inconsistent in usage of DatanodeUuid and
StorageID. (Arpit Agarwal) (arp:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595056)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003458#comment-14003458
]
Hudson commented on HDFS-6362:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1780 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1780/])
HDFS-6362. InvalidateBlocks is inconsistent in usage of DatanodeUuid and
StorageID. (Arpit Agarwal) (arp:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595056)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999300#comment-13999300
]
Hadoop QA commented on HDFS-6362:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644887/HDFS-6362.04.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6907//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6907//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6907//console
This message is automatically generated.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1381#comment-1381
]
Chris Nauroth commented on HDFS-6362:
-
Thanks, [~arpitagarwal]. BTW, you are correct that the findbugs warning was
unrelated to your patch. I introduced that problem in HDFS-6326, and then I
fixed it in HDFS-6402, so it won't be a problem anymore.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000322#comment-14000322
]
Arpit Agarwal commented on HDFS-6362:
-
Thanks for that clarification Chris!
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999261#comment-13999261
]
Arpit Agarwal commented on HDFS-6362:
-
The FindBugs warning looks invalid since the patch does not touch
FsAclPermissions.
bq. org.apache.hadoop.hdfs.protocol.FsAclPermission doesn't override
org.apache.hadoop.fs.permission.FsPermission.equals(Object)
Also we don't need new tests as per my earlier comment. I will commit this
shortly.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Fix For: 3.0.0, 2.4.1
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998201#comment-13998201
]
Arpit Agarwal commented on HDFS-6362:
-
Thanks Chris, will commit after Jenkins result.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993685#comment-13993685
]
Arpit Agarwal commented on HDFS-6362:
-
bq. Please justify why no new tests are needed for this patch.
There is an existing {{TestComputeInvalidateWork}} that failed to catch this
failure mode. Since we are replacing the String key with the {{DatanodeInfo}}
type safety checks will guard against this kind of bug.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993394#comment-13993394
]
Hadoop QA commented on HDFS-6362:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644050/HDFS-6362.01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6862//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6862//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6862//console
This message is automatically generated.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998454#comment-13998454
]
Hadoop QA commented on HDFS-6362:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644887/HDFS-6362.04.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6902//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6902//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6902//console
This message is automatically generated.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch, HDFS-6362.04.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993497#comment-13993497
]
Hadoop QA commented on HDFS-6362:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644077/HDFS-6362.03.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6866//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6866//console
This message is automatically generated.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6362) InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993432#comment-13993432
]
Hadoop QA commented on HDFS-6362:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644068/HDFS-6362.02.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6864//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6864//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6864//console
This message is automatically generated.
InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
---
Key: HDFS-6362
URL: https://issues.apache.org/jira/browse/HDFS-6362
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Arpit Agarwal
Assignee: Arpit Agarwal
Priority: Blocker
Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
HDFS-6362.03.patch
{{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
