[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041338#comment-14041338
]
Arpit Agarwal commented on HDFS-6578:
-
Your original understanding was correct. i.e. 1-3 are valid. I don't want to
spend more time on the exact wording of one comment and your comment is clearer
than no comment at all. I will commit your v2 patch.
+1
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040187#comment-14040187
]
Yongjun Zhang commented on HDFS-6578:
-
Hi [~arpit99],
Thanks for your comments. I didn't see it when I uploaded revision 002 for a
minor change.
About your comments. in patch 001, I wanted to give some more explanation why
the last BlockManager.processReport call is accurate, so I described it as
accumulate based on my understanding. This seems to be inaccurate. I wonder
if you could help saying a bit more on top of The result of the last
BlockManager.processReport call is accurate?
Say, since we are assigning noStaleStorages for each call, the patterns of
noStaleStorage value in the loop can be:
{code}
Iter 0 1234 (end of loop)
pattern1. false, false, false, false, false
pattern2. true, true, true, true, true
pattern3. false, false, true, true, true
pattern4, true, true, false, false, false
pattern5. false, true, false, true, false
{code}
I didn't study the code hard enough, but my understanding (which seems to be
wrong) was that, pattern1 through pattern4 are valid, and pattern5 not. Based
on your description, it seems actually any pattern of the above patterns could
happen, each call get up-to-date return value based on what processed so far.
And the last iteration is most up-to-date. Is this understanding correct? If
so, can we say The result of the last BlockManager.processReport call is most
up-to-date and accurate.
Thanks for your help toward my better understanding.
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040188#comment-14040188
]
Yongjun Zhang commented on HDFS-6578:
-
Sorry addressed to the wrong Arpit. Hi [~arpitagarwal], would you please see my
questions above? thanks.
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040221#comment-14040221
]
Hadoop QA commented on HDFS-6578:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651879/HDFS-6578.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7203//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7203//console
This message is automatically generated.
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039728#comment-14039728
]
Yongjun Zhang commented on HDFS-6578:
-
HI [~arpitagarwal], thanks for your comments earlier. Yes, that's what I
thought. Including these three piece of info should be helpful.
I just uploaded a patch, including the comments I wanted to add for HDFS-6577.
Thanks for review!
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039759#comment-14039759
]
Hadoop QA commented on HDFS-6578:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651813/HDFS-6578.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7199//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7199//console
This message is automatically generated.
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039930#comment-14039930
]
Arpit Agarwal commented on HDFS-6578:
-
Hi [~yzhangal],
bq. _BlockManager.processReport accumulates information of prior calls_
processReport does not accumulate results. We can just say _The result of the
last BlockManager.processReport call is accurate_?
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HDFS-6578.001.patch
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6578) add toString method to DatanodeStorage etc for easier debugging
[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039183#comment-14039183
]
Arpit Agarwal commented on HDFS-6578:
-
bq. It seems to be nice to add a toString() method for DatanodeStorage class,
so we can print out its key info easier while doing debuging.
The StorageID uniquely identifies the storage, but if you want to print out the
state and type that should be fine.
add toString method to DatanodeStorage etc for easier debugging
---
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
It seems to be nice to add a toString() method for DatanodeStorage class, so
we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the
following message,
{code}
blockLog.info(BLOCK* processReport: from storage +
storage.getStorageID()
+ node + nodeID + , blocks: + newReport.getNumberOfBlocks()
+ , processing time: + (endTime - startTime) + msecs);
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace
storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
