[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395780#comment-16395780
]
genericqa commented on HDFS-6853:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HDFS-6853 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-6853 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12662523/HDFS-6853.2.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/23420/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> --
>
> Key: HDFS-6853
> URL: https://issues.apache.org/jira/browse/HDFS-6853
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: James Thomas
>Assignee: James Thomas
>Priority: Major
> Attachments: HDFS-6853.2.patch, HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0).
> When we try to restart the other NN (NN1), we wait for isClusterUp() to
> return true, but this will never happen because NN0 is null and isNameNodeUp
> returns false for a null NN.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[ https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395761#comment-16395761 ] Tsz Wo Nicholas Sze commented on HDFS-6853: --- > It might make sense to fix isNameNodeUp() instead. If NN == null, NN is not up. So isNameNodeUp() seems fine. But as long as one NN is up, isClusterUp() should return true. So the bug is in isClusterUp(). For the .2 patch, it looks good except that it returns true if all NNs are null. [~james.thomas], would you mind updating the patch? > MiniDFSCluster.isClusterUp() should not check if null NameNodes are up > -- > > Key: HDFS-6853 > URL: https://issues.apache.org/jira/browse/HDFS-6853 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: James Thomas >Assignee: James Thomas >Priority: Major > Attachments: HDFS-6853.2.patch, HDFS-6853.patch > > > Suppose we have a two-NN cluster and then shut down one of the NN's (NN0). > When we try to restart the other NN (NN1), we wait for isClusterUp() to > return true, but this will never happen because NN0 is null and isNameNodeUp > returns false for a null NN. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806192#comment-15806192
]
Hadoop QA commented on HDFS-6853:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HDFS-6853 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-6853 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12662523/HDFS-6853.2.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/18094/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> --
>
> Key: HDFS-6853
> URL: https://issues.apache.org/jira/browse/HDFS-6853
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: James Thomas
>Assignee: James Thomas
> Attachments: HDFS-6853.2.patch, HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0).
> When we try to restart the other NN (NN1), we wait for isClusterUp() to
> return true, but this will never happen because NN0 is null and isNameNodeUp
> returns false for a null NN.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021318#comment-15021318
]
Haohui Mai commented on HDFS-6853:
--
It might make sense to fix {{isNameNodeUp()}} instead.
> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> --
>
> Key: HDFS-6853
> URL: https://issues.apache.org/jira/browse/HDFS-6853
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: James Thomas
>Assignee: James Thomas
> Labels: BB2015-05-TBR
> Attachments: HDFS-6853.2.patch, HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0).
> When we try to restart the other NN (NN1), we wait for isClusterUp() to
> return true, but this will never happen because NN0 is null and isNameNodeUp
> returns false for a null NN.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[ https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526045#comment-14526045 ] Hadoop QA commented on HDFS-6853: - (!) The patch artifact directory has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H4) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10760/ may provide some hints. > MiniDFSCluster.isClusterUp() should not check if null NameNodes are up > -- > > Key: HDFS-6853 > URL: https://issues.apache.org/jira/browse/HDFS-6853 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: James Thomas >Assignee: James Thomas > Attachments: HDFS-6853.2.patch, HDFS-6853.patch > > > Suppose we have a two-NN cluster and then shut down one of the NN's (NN0). > When we try to restart the other NN (NN1), we wait for isClusterUp() to > return true, but this will never happen because NN0 is null and isNameNodeUp > returns false for a null NN. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525759#comment-14525759
]
Hadoop QA commented on HDFS-6853:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 5s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 22s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 19s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 15s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 2s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 1m 19s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 169m 44s | Tests failed in hadoop-hdfs. |
| | | 191m 12s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.web.TestWebHDFSXAttr |
| | hadoop.hdfs.server.namenode.TestINodeFile |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12662523/HDFS-6853.2.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / a319771 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10731/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10731/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10731/console |
This message was automatically generated.
> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> --
>
> Key: HDFS-6853
> URL: https://issues.apache.org/jira/browse/HDFS-6853
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: James Thomas
>Assignee: James Thomas
> Attachments: HDFS-6853.2.patch, HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0).
> When we try to restart the other NN (NN1), we wait for isClusterUp() to
> return true, but this will never happen because NN0 is null and isNameNodeUp
> returns false for a null NN.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101577#comment-14101577
]
Hadoop QA commented on HDFS-6853:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12662523/HDFS-6853.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestINodeFile
org.apache.hadoop.hdfs.server.balancer.TestBalancer
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7667//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7667//console
This message is automatically generated.
> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> --
>
> Key: HDFS-6853
> URL: https://issues.apache.org/jira/browse/HDFS-6853
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: James Thomas
>Assignee: James Thomas
> Attachments: HDFS-6853.2.patch, HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0).
> When we try to restart the other NN (NN1), we wait for isClusterUp() to
> return true, but this will never happen because NN0 is null and isNameNodeUp
> returns false for a null NN.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[ https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098034#comment-14098034 ] James Thomas commented on HDFS-6853: Looks like a few tests rely on this behavior ... will hold off on this for now. > MiniDFSCluster.isClusterUp() should not check if null NameNodes are up > -- > > Key: HDFS-6853 > URL: https://issues.apache.org/jira/browse/HDFS-6853 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: James Thomas >Assignee: James Thomas > Attachments: HDFS-6853.patch > > > Suppose we have a two-NN cluster and then shut down one of the NN's (NN0). > When we try to restart the other NN (NN1), we wait for isClusterUp() to > return true, but this will never happen because NN0 is null and isNameNodeUp > returns false for a null NN. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6853) MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
[
https://issues.apache.org/jira/browse/HDFS-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098017#comment-14098017
]
Hadoop QA commented on HDFS-6853:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12661881/HDFS-6853.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
org.apache.hadoop.hdfs.server.namenode.TestINodeFile
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
org.apache.hadoop.hdfs.server.namenode.ha.TestHAMetrics
org.apache.hadoop.hdfs.TestHDFSServerPorts
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7637//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7637//console
This message is automatically generated.
> MiniDFSCluster.isClusterUp() should not check if null NameNodes are up
> --
>
> Key: HDFS-6853
> URL: https://issues.apache.org/jira/browse/HDFS-6853
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: James Thomas
>Assignee: James Thomas
> Attachments: HDFS-6853.patch
>
>
> Suppose we have a two-NN cluster and then shut down one of the NN's (NN0).
> When we try to restart the other NN (NN1), we wait for isClusterUp() to
> return true, but this will never happen because NN0 is null and isNameNodeUp
> returns false for a null NN.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
