[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=331192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331192
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 21/Oct/19 05:00
Start Date: 21/Oct/19 05:00
Worklog Time Spent: 10m 
  Work Description: bharatviswa504 commented on pull request #12: 
HDDS-2206. Separate handling for OMException and IOException in the Ozone 
Manager. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop-ozone/pull/12
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 331192)
Time Spent: 2h 10m  (was: 2h)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-15 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=328455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328455
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 15/Oct/19 10:05
Start Date: 15/Oct/19 10:05
Worklog Time Spent: 10m 
  Work Description: supratimdeka commented on pull request #1637: 
HDDS-2206. Separate handling for OMException and IOException in the Ozone 
Manager. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334861818
 
 

 ##
 File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
 ##
 @@ -1641,6 +1641,20 @@
 
   
 
+  
+ozone.om.exception.stacktrace.propagate
 
 Review comment:
   done the change in new PR
   https://github.com/apache/hadoop-ozone/pull/12
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328455)
Time Spent: 2h  (was: 1h 50m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-15 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=328454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328454
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 15/Oct/19 10:04
Start Date: 15/Oct/19 10:04
Worklog Time Spent: 10m 
  Work Description: supratimdeka commented on pull request #1637: 
HDDS-2206. Separate handling for OMException and IOException in the Ozone 
Manager. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334861662
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
 ##
 @@ -200,15 +200,7 @@
 import static org.apache.hadoop.ozone.OzoneConsts.OM_METRICS_FILE;
 import static org.apache.hadoop.ozone.OzoneConsts.OM_METRICS_TEMP_FILE;
 import static org.apache.hadoop.ozone.OzoneConsts.RPC_PORT;
-import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_ADDRESS_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_HANDLER_COUNT_DEFAULT;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_HANDLER_COUNT_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_KEYTAB_FILE_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_PRINCIPAL_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL_DEFAULT;
-import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_USER_MAX_VOLUME;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_USER_MAX_VOLUME_DEFAULT;
+import static org.apache.hadoop.ozone.om.OMConfigKeys.*;
 
 Review comment:
   done
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328454)
Time Spent: 1h 50m  (was: 1h 40m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-15 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=328453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328453
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 15/Oct/19 10:04
Start Date: 15/Oct/19 10:04
Worklog Time Spent: 10m 
  Work Description: supratimdeka commented on pull request #1637: 
HDDS-2206. Separate handling for OMException and IOException in the Ozone 
Manager. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334861542
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
 ##
 @@ -219,7 +244,7 @@ private OMResponse submitRequestDirectlyToOM(OMRequest 
request) {
 omClientResponse = omClientRequest.validateAndUpdateCache(
 ozoneManager, index, ozoneManagerDoubleBuffer::add);
   }
-} catch(IOException ex) {
+} catch(OMException ex) {
 
 Review comment:
   Addressed comments in
   https://github.com/apache/hadoop-ozone/pull/12
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 328453)
Time Spent: 1h 40m  (was: 1.5h)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-13 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327616&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327616
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 14/Oct/19 05:41
Start Date: 14/Oct/19 05:41
Worklog Time Spent: 10m 
  Work Description: supratimdeka commented on pull request #12: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop-ozone/pull/12
 
 
   https://issues.apache.org/jira/browse/HDDS-2206
   
   Introduced a boolean config parameter to control exception propagation from 
OM to Clients.
   If set to true, all system exceptions (IOException) are thrown as 
ServiceException to RPC client - this also propagates the complete server-side 
stack trace to the client. If false, system exception stack trace is logged 
locally on the server, not sent to client.
   The default value is set to true for now. For Ozone GA, we can revisit this 
choice.
   
   Business Exception (OMException) handling is not changed.
   
   This change does not include propagation of exceptions from within Ratis 
server.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 327616)
Time Spent: 1.5h  (was: 1h 20m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-13 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327440
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 13/Oct/19 07:32
Start Date: 13/Oct/19 07:32
Worklog Time Spent: 10m 
  Work Description: elek commented on issue #1637: HDDS-2206. Separate 
handling for OMException and IOException in the Ozone Manager. Contributed by 
Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#issuecomment-541394632
 
 
   
   Thank you very much to open this pull request.
   
   During the weekend the Ozone source code has been moved out from 
[apache/hadoop](https://github.com/apache/hadoop) repository to 
[apache/hadoop-ozone](https://github.com/apache/hadoop-ozone) repository.
   
   This git commits are rewritten, but the branch of this pull request is also 
transformed (state of Saturday morning), you can use the new, migrated branch 
to recreate this pull request.
   
   Your pull request is important for us: **Can you please re-create your pull 
request in the new repository?**
   
   **1**. Create a new fork of https://github.com/apache/hadoop-ozone
   
   **2**. Clone it and have both your fork and the apache repo as remotes:
   
   ```
   git clone g...@github.com:supratimdeka/hadoop-ozone.git
   cd hadoop-ozone
   git remote add apache g...@github.com:apache/hadoop-ozone.git
   git fetch apache
   ```
   
   **3**. Fetch your migrated branch and push it to your fork.
   
   ```
   git checkout -b HDDS-2206 apache/HDDS-2206
   git push origin HDDS-2206
   ```
   
   **4**. And create the new pull request on the new repository.
   
   
https://github.com/apache/hadoop-ozone/compare/master...supratimdeka:HDDS-2206?expand=1
   
   If you need more information, please check 
[this](https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Ozone+source+tree+split)
 wiki page or contact with me (my github user name + apache.org).
   
   Thank you, and sorry for the inconvenience.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 327440)
Time Spent: 1h 20m  (was: 1h 10m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327085
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 11/Oct/19 21:28
Start Date: 11/Oct/19 21:28
Worklog Time Spent: 10m 
  Work Description: arp7 commented on issue #1637: HDDS-2206. Separate 
handling for OMException and IOException in the Ozone Manager. Contributed by 
Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#issuecomment-541230130
 
 
   One thing I missed - where is the serialization of the exception message 
done over the wire?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 327085)
Time Spent: 1h 10m  (was: 1h)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327082
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 11/Oct/19 21:15
Start Date: 11/Oct/19 21:15
Worklog Time Spent: 10m 
  Work Description: arp7 commented on pull request #1637: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334176751
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
 ##
 @@ -219,7 +244,7 @@ private OMResponse submitRequestDirectlyToOM(OMRequest 
request) {
 omClientResponse = omClientRequest.validateAndUpdateCache(
 ozoneManager, index, ozoneManagerDoubleBuffer::add);
   }
-} catch(IOException ex) {
+} catch(OMException ex) {
 
 Review comment:
   I think we don't need this catch block at all, as the caller will do the 
right thing via the call to `createErrorResponse`.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 327082)
Time Spent: 1h  (was: 50m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327081
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 11/Oct/19 21:09
Start Date: 11/Oct/19 21:09
Worklog Time Spent: 10m 
  Work Description: arp7 commented on pull request #1637: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334175139
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
 ##
 @@ -200,15 +200,7 @@
 import static org.apache.hadoop.ozone.OzoneConsts.OM_METRICS_FILE;
 import static org.apache.hadoop.ozone.OzoneConsts.OM_METRICS_TEMP_FILE;
 import static org.apache.hadoop.ozone.OzoneConsts.RPC_PORT;
-import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_ADDRESS_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_HANDLER_COUNT_DEFAULT;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_HANDLER_COUNT_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_KEYTAB_FILE_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_KERBEROS_PRINCIPAL_KEY;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_METRICS_SAVE_INTERVAL_DEFAULT;
-import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_USER_MAX_VOLUME;
-import static 
org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_USER_MAX_VOLUME_DEFAULT;
+import static org.apache.hadoop.ozone.om.OMConfigKeys.*;
 
 Review comment:
   Probably better to avoid static wild-card import. Some IDEs do this by 
default.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 327081)
Time Spent: 50m  (was: 40m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-11 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327078
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 11/Oct/19 21:05
Start Date: 11/Oct/19 21:05
Worklog Time Spent: 10m 
  Work Description: arp7 commented on pull request #1637: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334173951
 
 

 ##
 File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
 ##
 @@ -1641,6 +1641,20 @@
 
   
 
+  
+ozone.om.exception.stacktrace.propagate
 
 Review comment:
   Instead of making it an OM-specific setting, we could make it a global 
setting for all services.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 327078)
Time Spent: 40m  (was: 0.5h)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-10 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=326718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326718
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 11/Oct/19 05:41
Start Date: 11/Oct/19 05:41
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on issue #1637: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#issuecomment-540916351
 
 
   /label ozone
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 326718)
Time Spent: 0.5h  (was: 20m)

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-10 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=326221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326221
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 10/Oct/19 10:55
Start Date: 10/Oct/19 10:55
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on issue #1637: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#issuecomment-540515504
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 69 | Maven dependency ordering for branch |
   | -1 | mvninstall | 39 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 38 | hadoop-ozone in trunk failed. |
   | -1 | compile | 22 | hadoop-hdds in trunk failed. |
   | -1 | compile | 16 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 61 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 928 | branch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 23 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 20 | hadoop-ozone in trunk failed. |
   | 0 | spotbugs | 1042 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | -1 | findbugs | 46 | hadoop-hdds in trunk failed. |
   | -1 | findbugs | 21 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 30 | Maven dependency ordering for patch |
   | -1 | mvninstall | 34 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 36 | hadoop-ozone in the patch failed. |
   | -1 | compile | 25 | hadoop-hdds in the patch failed. |
   | -1 | compile | 18 | hadoop-ozone in the patch failed. |
   | -1 | javac | 25 | hadoop-hdds in the patch failed. |
   | -1 | javac | 18 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 56 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 1 | The patch has no ill-formed XML file. |
   | +1 | shadedclient | 712 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 23 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 20 | hadoop-ozone in the patch failed. |
   | -1 | findbugs | 32 | hadoop-hdds in the patch failed. |
   | -1 | findbugs | 21 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 29 | hadoop-hdds in the patch failed. |
   | -1 | unit | 26 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 35 | The patch does not generate ASF License warnings. |
   | | | 2551 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.3 Server=19.03.3 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1637 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient xml findbugs checkstyle |
   | uname | Linux e85b794dee86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / a031388 |
   | Default Java | 1.8.0_222 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-javadoc-hadoop-ozone.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-findbugs-hadoop-hdds.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-findbugs-h

[jira] [Work logged] (HDDS-2206) Separate handling for OMException and IOException in the Ozone Manager

2019-10-10 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=326211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326211
 ]

ASF GitHub Bot logged work on HDDS-2206:


Author: ASF GitHub Bot
Created on: 10/Oct/19 10:06
Start Date: 10/Oct/19 10:06
Worklog Time Spent: 10m 
  Work Description: supratimdeka commented on pull request #1637: 
HDDS-2206. Separate handling for OMException and IOException in the Ozone 
Manager. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637
 
 
   https://issues.apache.org/jira/browse/HDDS-2206
   
   Introduced a boolean config parameter to control exception propagation from 
OM to Clients.
   If set to true, all system exceptions (IOException) are thrown as 
ServiceException to RPC client - this also propagates the complete server-side 
stack trace to the client. If false, system exception stack trace is logged 
locally on the server, not sent to client.
   The default value is set to true for now. For Ozone GA, we can revisit this 
choice.
   
   Business Exception (OMException) handling is not changed.
   
   This change does not include propagation of exceptions from within Ratis 
server.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 326211)
Remaining Estimate: 0h
Time Spent: 10m

> Separate handling for OMException and IOException in the Ozone Manager
> --
>
> Key: HDDS-2206
> URL: https://issues.apache.org/jira/browse/HDDS-2206
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Manager
>Reporter: Supratim Deka
>Assignee: Supratim Deka
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org