Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-16 Thread Steve Ebersole
I talked with Andrea and we both think this is getting important to do.  So
Monday we will start the process of integrating master (5.3) on to 6.0.
Then you'll be able to have a better idea.

This figures to be a huge undertaking, so not sure when it will be done.

On Thu, Feb 15, 2018 at 10:05 PM Steve Ebersole  wrote:

> I'm not sure what else to tell you.  Sure some things have been removed.
>
> I'm not going to go through all of these right now.  If there are some in
> particular you are interested please bring those of specifically.
>
>
> On Thu, Feb 15, 2018 at 6:48 PM Gail Badner  wrote:
>
>> Hi Steve,
>>
>> The list I provided contains removals from your fork in wip/6.0 branch.
>>
>> IIUC, integrating changes from master will not restore what was deleted
>> or moved to a different package.  After integrating from master and
>> resolving conflicts, we'll have the same incompatibilities.
>>
>> Am I missing something? Is there some other branch I should be comparing?
>>
>> Regards,
>> Gail
>>
>> On Thu, Feb 15, 2018 at 9:13 AM, Steve Ebersole 
>> wrote:
>>
>>> We have not integrated changes from master into 6.0 for a long time.
>>> And we probably won't for some time yet either.  So comparisons between 5.2
>>> or 5.3 and 6.0 right now are pointless
>>>
>>> On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:
>>>
 I sent this last night with a huge report file, and it seems that it
 didn't
 get out.

 I'm re-sending without the report file...

 I ran japi-compliance-checker to compare differences in APIs
 between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
 SNAPSHOT.jar.

 I ran it last week, so it may not include updates made since that time.

 Differences in Envers shown in the report should be disregarded because
 it
 only reflects that hibernate-envers was merged into hibernate-core. A
 separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
 hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers
 changes.

 Chris will provide details about Envers differences in a separate email.

 The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what
 I've
 documented are the only non-Envers API changes that could affect
 applications. They all involve removed classes/methods.

 My intention here is just to get this information out, so we have some
 solid examples to discuss.

 Regards,
 Gail

 
 --

 Custom types: I am not familiar with how this will work in 6.0. Steve,
 please fill in details about any incompatibilities.

 org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:

 In 5.0/5.1/5.2:
 * user guides say, "This appendix covers the legacy Hibernate
 org.hibernate.Criteria API, which should be considered deprecated. New
 development should focus on the JPA
 javax.persistence.criteria.CriteriaQuery
 API. Eventually, Hibernate-specific criteria features will be ported as
 extensions to the JPA javax.persistence.criteria.CriteriaQuery. For
 details
 on the JPA APIs, see Criteria."

 In 5.2/5.3:
 * Criteria and DetachedCriteria are not deprecated;
 * all SharedSessionContract#createCriteria methods are deprecated;
 * public static methods in DetachedCriteria are not deprecated;

 In 6.0:
 * Criteria and DetachedCriteria are removed along with other classes in
 org.hibernate.criterion.

 Incompatibilities migrating from 5.3 -> 6.0:
 1) Existing applications using legacy org.hibernate.Criteria will need
 to
 be updated to use javax.persistence.criteria.CriteriaQuery;
 2) If Hibernate's implementation of
 javax.persistence.criteria.CriteriaQuery
 does not include the Hibernate-specific extensions that were available
 using org.hibernate.Criteria, applications may not have a
 straightforward
 way to change their applications to work.

 org.hibernate.Query

 In 5.1:
 * SharedSessionContract#createQuery returns org.hibernate.Query
 (org.hibernate.Session extends SharedSessionContract);

 In 5.2/5.3:
 * org.hibernate.Query was deprecated; org.hibernate.query.Query should
 be
 used instead; org.hibernate.query.Query extends org.hibernate.Query;
 * SharedSessionContract#createQuery moved to
 org.hibernate.query.QueryProducer#createQuery,
 returning  org.hibernate.query.Query (which extends
 org.hibernate.Query);
 (org.hibernate.Session extends QueryProducer);

 In 6.0:
 * org.hibernate.Query was removed.

 Incompatibilities migrating from 5.3 -> 6.0:
 1) Existing applications that 

Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-15 Thread Steve Ebersole
I'm not sure what else to tell you.  Sure some things have been removed.

I'm not going to go through all of these right now.  If there are some in
particular you are interested please bring those of specifically.


On Thu, Feb 15, 2018 at 6:48 PM Gail Badner  wrote:

> Hi Steve,
>
> The list I provided contains removals from your fork in wip/6.0 branch.
>
> IIUC, integrating changes from master will not restore what was deleted
> or moved to a different package.  After integrating from master and
> resolving conflicts, we'll have the same incompatibilities.
>
> Am I missing something? Is there some other branch I should be comparing?
>
> Regards,
> Gail
>
> On Thu, Feb 15, 2018 at 9:13 AM, Steve Ebersole 
> wrote:
>
>> We have not integrated changes from master into 6.0 for a long time.  And
>> we probably won't for some time yet either.  So comparisons between 5.2 or
>> 5.3 and 6.0 right now are pointless
>>
>> On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:
>>
>>> I sent this last night with a huge report file, and it seems that it
>>> didn't
>>> get out.
>>>
>>> I'm re-sending without the report file...
>>>
>>> I ran japi-compliance-checker to compare differences in APIs
>>> between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
>>> SNAPSHOT.jar.
>>>
>>> I ran it last week, so it may not include updates made since that time.
>>>
>>> Differences in Envers shown in the report should be disregarded because
>>> it
>>> only reflects that hibernate-envers was merged into hibernate-core. A
>>> separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
>>> hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers changes.
>>>
>>> Chris will provide details about Envers differences in a separate email.
>>>
>>> The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what I've
>>> documented are the only non-Envers API changes that could affect
>>> applications. They all involve removed classes/methods.
>>>
>>> My intention here is just to get this information out, so we have some
>>> solid examples to discuss.
>>>
>>> Regards,
>>> Gail
>>>
>>> 
>>> --
>>>
>>> Custom types: I am not familiar with how this will work in 6.0. Steve,
>>> please fill in details about any incompatibilities.
>>>
>>> org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:
>>>
>>> In 5.0/5.1/5.2:
>>> * user guides say, "This appendix covers the legacy Hibernate
>>> org.hibernate.Criteria API, which should be considered deprecated. New
>>> development should focus on the JPA
>>> javax.persistence.criteria.CriteriaQuery
>>> API. Eventually, Hibernate-specific criteria features will be ported as
>>> extensions to the JPA javax.persistence.criteria.CriteriaQuery. For
>>> details
>>> on the JPA APIs, see Criteria."
>>>
>>> In 5.2/5.3:
>>> * Criteria and DetachedCriteria are not deprecated;
>>> * all SharedSessionContract#createCriteria methods are deprecated;
>>> * public static methods in DetachedCriteria are not deprecated;
>>>
>>> In 6.0:
>>> * Criteria and DetachedCriteria are removed along with other classes in
>>> org.hibernate.criterion.
>>>
>>> Incompatibilities migrating from 5.3 -> 6.0:
>>> 1) Existing applications using legacy org.hibernate.Criteria will need to
>>> be updated to use javax.persistence.criteria.CriteriaQuery;
>>> 2) If Hibernate's implementation of
>>> javax.persistence.criteria.CriteriaQuery
>>> does not include the Hibernate-specific extensions that were available
>>> using org.hibernate.Criteria, applications may not have a straightforward
>>> way to change their applications to work.
>>>
>>> org.hibernate.Query
>>>
>>> In 5.1:
>>> * SharedSessionContract#createQuery returns org.hibernate.Query
>>> (org.hibernate.Session extends SharedSessionContract);
>>>
>>> In 5.2/5.3:
>>> * org.hibernate.Query was deprecated; org.hibernate.query.Query should be
>>> used instead; org.hibernate.query.Query extends org.hibernate.Query;
>>> * SharedSessionContract#createQuery moved to
>>> org.hibernate.query.QueryProducer#createQuery,
>>> returning  org.hibernate.query.Query (which extends org.hibernate.Query);
>>> (org.hibernate.Session extends QueryProducer);
>>>
>>> In 6.0:
>>> * org.hibernate.Query was removed.
>>>
>>> Incompatibilities migrating from 5.3 -> 6.0:
>>> 1) Existing applications that explicitly use org.hibernate.Query
>>> (including
>>> javax.persistence.Query.unwrap( org.hibernate.Query.class )) will have to
>>> be changed to use org.hibernate.query.Query.
>>>
>>> org.hibernate.SQLQuery:
>>>
>>> In 5.1:
>>> * SharedSessionContract#createSQLQuery returns org.hibernate.SQLQuery
>>> (org.hibernate.Session extends SharedSessionContract);
>>>
>>> In 5.2/5.3:
>>> * SQLQuery was deprecated; NativeQuery should be used instead;
>>> NativeQuery
>>> extends SQLQuery;
>>> * 

Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-15 Thread Gail Badner
Hi Steve,

The list I provided contains removals from your fork in wip/6.0 branch.

IIUC, integrating changes from master will not restore what was deleted or
moved to a different package.  After integrating from master and resolving
conflicts, we'll have the same incompatibilities.

Am I missing something? Is there some other branch I should be comparing?

Regards,
Gail

On Thu, Feb 15, 2018 at 9:13 AM, Steve Ebersole  wrote:

> We have not integrated changes from master into 6.0 for a long time.  And
> we probably won't for some time yet either.  So comparisons between 5.2 or
> 5.3 and 6.0 right now are pointless
>
> On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:
>
>> I sent this last night with a huge report file, and it seems that it
>> didn't
>> get out.
>>
>> I'm re-sending without the report file...
>>
>> I ran japi-compliance-checker to compare differences in APIs
>> between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
>> SNAPSHOT.jar.
>>
>> I ran it last week, so it may not include updates made since that time.
>>
>> Differences in Envers shown in the report should be disregarded because it
>> only reflects that hibernate-envers was merged into hibernate-core. A
>> separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
>> hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers changes.
>>
>> Chris will provide details about Envers differences in a separate email.
>>
>> The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what I've
>> documented are the only non-Envers API changes that could affect
>> applications. They all involve removed classes/methods.
>>
>> My intention here is just to get this information out, so we have some
>> solid examples to discuss.
>>
>> Regards,
>> Gail
>>
>> 
>> --
>>
>> Custom types: I am not familiar with how this will work in 6.0. Steve,
>> please fill in details about any incompatibilities.
>>
>> org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:
>>
>> In 5.0/5.1/5.2:
>> * user guides say, "This appendix covers the legacy Hibernate
>> org.hibernate.Criteria API, which should be considered deprecated. New
>> development should focus on the JPA javax.persistence.criteria.Cri
>> teriaQuery
>> API. Eventually, Hibernate-specific criteria features will be ported as
>> extensions to the JPA javax.persistence.criteria.CriteriaQuery. For
>> details
>> on the JPA APIs, see Criteria."
>>
>> In 5.2/5.3:
>> * Criteria and DetachedCriteria are not deprecated;
>> * all SharedSessionContract#createCriteria methods are deprecated;
>> * public static methods in DetachedCriteria are not deprecated;
>>
>> In 6.0:
>> * Criteria and DetachedCriteria are removed along with other classes in
>> org.hibernate.criterion.
>>
>> Incompatibilities migrating from 5.3 -> 6.0:
>> 1) Existing applications using legacy org.hibernate.Criteria will need to
>> be updated to use javax.persistence.criteria.CriteriaQuery;
>> 2) If Hibernate's implementation of javax.persistence.criteria.Cri
>> teriaQuery
>> does not include the Hibernate-specific extensions that were available
>> using org.hibernate.Criteria, applications may not have a straightforward
>> way to change their applications to work.
>>
>> org.hibernate.Query
>>
>> In 5.1:
>> * SharedSessionContract#createQuery returns org.hibernate.Query
>> (org.hibernate.Session extends SharedSessionContract);
>>
>> In 5.2/5.3:
>> * org.hibernate.Query was deprecated; org.hibernate.query.Query should be
>> used instead; org.hibernate.query.Query extends org.hibernate.Query;
>> * SharedSessionContract#createQuery moved to
>> org.hibernate.query.QueryProducer#createQuery,
>> returning  org.hibernate.query.Query (which extends org.hibernate.Query);
>> (org.hibernate.Session extends QueryProducer);
>>
>> In 6.0:
>> * org.hibernate.Query was removed.
>>
>> Incompatibilities migrating from 5.3 -> 6.0:
>> 1) Existing applications that explicitly use org.hibernate.Query
>> (including
>> javax.persistence.Query.unwrap( org.hibernate.Query.class )) will have to
>> be changed to use org.hibernate.query.Query.
>>
>> org.hibernate.SQLQuery:
>>
>> In 5.1:
>> * SharedSessionContract#createSQLQuery returns org.hibernate.SQLQuery
>> (org.hibernate.Session extends SharedSessionContract);
>>
>> In 5.2/5.3:
>> * SQLQuery was deprecated; NativeQuery should be used instead; NativeQuery
>> extends SQLQuery;
>> * SharedSessionContract#createSQLQuery moved to
>> QueryProducer#createSQLQuery, returning  NativeQuery (which extends
>> SQLQuery); Session extends QueryProducer;
>> * QueryProducer#createSQLQuery is deprecated;
>> QueryProducer#createNativeQuery
>> should be used instead
>>
>> In 6.0:
>> * SQLQuery and org.hibernate.query.QueryProducer#createSQLQuery are
>> removed.
>>
>> Incompatibilities migrating from 5.3 -> 6.0:
>> 1) Existing 

Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-15 Thread Steve Ebersole
We have not integrated changes from master into 6.0 for a long time.  And
we probably won't for some time yet either.  So comparisons between 5.2 or
5.3 and 6.0 right now are pointless

On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:

> I sent this last night with a huge report file, and it seems that it didn't
> get out.
>
> I'm re-sending without the report file...
>
> I ran japi-compliance-checker to compare differences in APIs
> between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
> SNAPSHOT.jar.
>
> I ran it last week, so it may not include updates made since that time.
>
> Differences in Envers shown in the report should be disregarded because it
> only reflects that hibernate-envers was merged into hibernate-core. A
> separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
> hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers changes.
>
> Chris will provide details about Envers differences in a separate email.
>
> The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what I've
> documented are the only non-Envers API changes that could affect
> applications. They all involve removed classes/methods.
>
> My intention here is just to get this information out, so we have some
> solid examples to discuss.
>
> Regards,
> Gail
>
> 
> --
>
> Custom types: I am not familiar with how this will work in 6.0. Steve,
> please fill in details about any incompatibilities.
>
> org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:
>
> In 5.0/5.1/5.2:
> * user guides say, "This appendix covers the legacy Hibernate
> org.hibernate.Criteria API, which should be considered deprecated. New
> development should focus on the JPA
> javax.persistence.criteria.CriteriaQuery
> API. Eventually, Hibernate-specific criteria features will be ported as
> extensions to the JPA javax.persistence.criteria.CriteriaQuery. For details
> on the JPA APIs, see Criteria."
>
> In 5.2/5.3:
> * Criteria and DetachedCriteria are not deprecated;
> * all SharedSessionContract#createCriteria methods are deprecated;
> * public static methods in DetachedCriteria are not deprecated;
>
> In 6.0:
> * Criteria and DetachedCriteria are removed along with other classes in
> org.hibernate.criterion.
>
> Incompatibilities migrating from 5.3 -> 6.0:
> 1) Existing applications using legacy org.hibernate.Criteria will need to
> be updated to use javax.persistence.criteria.CriteriaQuery;
> 2) If Hibernate's implementation of
> javax.persistence.criteria.CriteriaQuery
> does not include the Hibernate-specific extensions that were available
> using org.hibernate.Criteria, applications may not have a straightforward
> way to change their applications to work.
>
> org.hibernate.Query
>
> In 5.1:
> * SharedSessionContract#createQuery returns org.hibernate.Query
> (org.hibernate.Session extends SharedSessionContract);
>
> In 5.2/5.3:
> * org.hibernate.Query was deprecated; org.hibernate.query.Query should be
> used instead; org.hibernate.query.Query extends org.hibernate.Query;
> * SharedSessionContract#createQuery moved to
> org.hibernate.query.QueryProducer#createQuery,
> returning  org.hibernate.query.Query (which extends org.hibernate.Query);
> (org.hibernate.Session extends QueryProducer);
>
> In 6.0:
> * org.hibernate.Query was removed.
>
> Incompatibilities migrating from 5.3 -> 6.0:
> 1) Existing applications that explicitly use org.hibernate.Query (including
> javax.persistence.Query.unwrap( org.hibernate.Query.class )) will have to
> be changed to use org.hibernate.query.Query.
>
> org.hibernate.SQLQuery:
>
> In 5.1:
> * SharedSessionContract#createSQLQuery returns org.hibernate.SQLQuery
> (org.hibernate.Session extends SharedSessionContract);
>
> In 5.2/5.3:
> * SQLQuery was deprecated; NativeQuery should be used instead; NativeQuery
> extends SQLQuery;
> * SharedSessionContract#createSQLQuery moved to
> QueryProducer#createSQLQuery, returning  NativeQuery (which extends
> SQLQuery); Session extends QueryProducer;
> * QueryProducer#createSQLQuery is deprecated;
> QueryProducer#createNativeQuery
> should be used instead
>
> In 6.0:
> * SQLQuery and org.hibernate.query.QueryProducer#createSQLQuery are
> removed.
>
> Incompatibilities migrating from 5.3 -> 6.0:
> 1) Existing applications using Session#createSQLQuery will need to be
> updated to use Session#createNativeQuery.
> 2) Existing applications that explicitly use org.hibernate.SQLQuery
> (including javax.persistence.Query.unwrap( SQLQuery.class )) will have to
> be changed to use NativeQuery.
>
> org.hibernate.SynchronizeableQuery
>
> In 5.2/5.3:
> * org.hibernate.SynchronizeableQuery is not deprecated;
> * SQLQuery, NativeQuery and ProcedureCall extend org.hibernate.
> SynchronizeableQuery
>
> In 6.0:
> * org.hibernate.SynchronizeableQuery is moved to org.hibernate.query.
>