Jeff Squyres (jsquyres), le Fri 01 Nov 2013 18:03:55 +0100, a écrit :
> On Nov 1, 2013, at 11:54 AM, Samuel Thibault wrote:
>
> > We could avoid Xutil.h and keysym.h by disabling the case KeyPress part,
> > but I'd rather not: people will wonder why they don't have keyboard
> > shortcut, and find
Le 01/11/2013 16:01, Jeff Squyres (jsquyres) a écrit :
> Ah; I missed that because we have the X11 checking stuff done in hwloc.m4
> already -- I thought the ones in the Cairo were actually redundant.
>
> It looks like this logic isn't quite correct, anyway -- the X11 checks are
> embedded in the
On Nov 1, 2013, at 11:54 AM, Samuel Thibault wrote:
> We could avoid Xutil.h and keysym.h by disabling the case KeyPress part,
> but I'd rather not: people will wonder why they don't have keyboard
> shortcut, and finding out from ./configure output will not be easy.
> When one has Xlib.h, having
Jeff Squyres (jsquyres), le Fri 01 Nov 2013 16:33:41 +0100, a écrit :
> There's some funny m4 logic in the CHECK_HEADERS for X11. Let me make sure I
> understand the intent:
>
> - X11/Xlib.h: this file is required for X11 support
> - X11/Xutil.h X11/keysym.h: these files are optional for X11 sup
There's some funny m4 logic in the CHECK_HEADERS for X11. Let me make sure I
understand the intent:
- X11/Xlib.h: this file is required for X11 support
- X11/Xutil.h X11/keysym.h: these files are optional for X11 support (i.e., we
can still build X11 support without them, but if we have them, t
Ya -- working on a new patch, too.
On Nov 1, 2013, at 11:10 AM, Brice Goglin wrote:
> Can you first find out which header and library contains XOpenDisplay()
> on your Mac?
>
> Brice
>
>
>
> Le 01/11/2013 16:01, Jeff Squyres (jsquyres) a écrit :
>> Ah; I missed that because we have the X11
Can you first find out which header and library contains XOpenDisplay()
on your Mac?
Brice
Le 01/11/2013 16:01, Jeff Squyres (jsquyres) a écrit :
> Ah; I missed that because we have the X11 checking stuff done in hwloc.m4
> already -- I thought the ones in the Cairo were actually redundant.
>
Jeff Squyres (jsquyres), le Fri 01 Nov 2013 16:01:41 +0100, a écrit :
> It looks like this logic isn't quite correct, anyway -- the X11 checks are
> embedded in the Cairo and GL sections. Should they moved out to be
> independent of Cairo and GL (and therefore only once, and include the
> AC_DE
Ah; I missed that because we have the X11 checking stuff done in hwloc.m4
already -- I thought the ones in the Cairo were actually redundant.
It looks like this logic isn't quite correct, anyway -- the X11 checks are
embedded in the Cairo and GL sections. Should they moved out to be independent
Jeff Squyres (jsquyres), le Fri 01 Nov 2013 15:12:31 +0100, a écrit :
> Cool. Does the following patch look ok? If so, I'll commit to master and
> v1.7:
Err, no, we really need to have HWLOC_HAVE_X11 defined when X11 is
available, otherwise we won't get the graphical lstopo.
Samuel
Cool. Does the following patch look ok? If so, I'll commit to master and v1.7:
diff --git a/config/hwloc_internal.m4 b/config/hwloc_internal.m4
index b0ac041..bfc3f36 100644
--- a/config/hwloc_internal.m4
+++ b/config/hwloc_internal.m4
@@ -255,31 +255,6 @@ EOF
HWLOC_PKG_CHECK_MODULES([CAI
Hello,
Jeff Squyres (jsquyres), le Fri 01 Nov 2013 14:59:03 +0100, a écrit :
> I notice that we have an explicit dependency between Cairo and X11 in
> configure:
>
> Is there any reason for this?
I think if there was any it's now gone.
> Indeed, I manually disabled this extra check in configur
I notice that we have an explicit dependency between Cairo and X11 in configure:
-
if test "x$enable_X11" != "xyes"; then
AC_MSG_WARN([X11 headers not found, Cairo/X11 back-end disabled])
hwloc_cairo_happy=no
fi
-
Is there any reason for this?
I ask be
13 matches
Mail list logo
