Re: [hwloc-devel] multiline legend
On Nov 30, 2010, at 9:30 AM, Brice Goglin wrote: > Yes, adding "p" to "#2" when showing physical indexes in the graphical > output exactly like we do for the textual output (which does not have > the legend). Ah, I see. > Some colleague even want to always have "P#" or "L#" and the legend to > make everything clear. I'm not opposed to P# and L# everywhere (i.e., capital P, so that we can use capital L), if it helps readability. -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [hwloc-devel] multiline legend
Le 30/11/2010 15:20, Jeff Squyres a écrit : > On Nov 30, 2010, at 9:17 AM, Brice Goglin wrote: > > >> I discussed with some "random" people about the "p" prefix in physical >> mode. It's not clear whether removing it from the graphical output is a >> good idea or not. People already have a hard time trying to understand >> all this logical/physical index stuff... >> > You mean in addition to the legend? > Yes, adding "p" to "#2" when showing physical indexes in the graphical output exactly like we do for the textual output (which does not have the legend). Some colleague even want to always have "P#" or "L#" and the legend to make everything clear. Brice
Re: [hwloc-devel] multiline legend
On Nov 30, 2010, at 9:17 AM, Brice Goglin wrote: > I discussed with some "random" people about the "p" prefix in physical > mode. It's not clear whether removing it from the graphical output is a > good idea or not. People already have a hard time trying to understand > all this logical/physical index stuff... You mean in addition to the legend? > By the way, we talk about "index" instead of "ID" almost everywhere. So > should we use "index" in the legend too? Good call; can you fix? I'm in meetings all morning. :-( -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [hwloc-devel] multiline legend
Le 30/11/2010 15:03, Jeff Squyres a écrit : > On Nov 30, 2010, at 8:50 AM, Samuel Thibault wrote: > > >>> How's this, instead? I made a few minor changes: >>> >>> - prefixed each line of the legend (the "physical IDs" line was confusing >>> to me without a prefix) >>> - fixed logic for terminating timestamp string >>> - moved all the legend logic inside "if (legend)" >>> >> That looks good to me. >> > Cool. Committed to trunk and v1.1. > > What's left for v1.1? > I discussed with some "random" people about the "p" prefix in physical mode. It's not clear whether removing it from the graphical output is a good idea or not. People already have a hard time trying to understand all this logical/physical index stuff... By the way, we talk about "index" instead of "ID" almost everywhere. So should we use "index" in the legend too? Brice
Re: [hwloc-devel] multiline legend
On Nov 30, 2010, at 8:50 AM, Samuel Thibault wrote: >> How's this, instead? I made a few minor changes: >> >> - prefixed each line of the legend (the "physical IDs" line was confusing to >> me without a prefix) >> - fixed logic for terminating timestamp string >> - moved all the legend logic inside "if (legend)" > > That looks good to me. Cool. Committed to trunk and v1.1. What's left for v1.1? -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [hwloc-devel] multiline legend
Jeff Squyres, le Tue 30 Nov 2010 14:45:13 +0100, a écrit : > How's this, instead? I made a few minor changes: > > - prefixed each line of the legend (the "physical IDs" line was confusing to > me without a prefix) > - fixed logic for terminating timestamp string > - moved all the legend logic inside "if (legend)" That looks good to me. Samuel
Re: [hwloc-devel] multiline legend
How's this, instead? I made a few minor changes: - prefixed each line of the legend (the "physical IDs" line was confusing to me without a prefix) - fixed logic for terminating timestamp string - moved all the legend logic inside "if (legend)" On Nov 29, 2010, at 8:54 AM, Brice Goglin wrote: > Jeff, is the attached patch what you want? Lines should be small enough > on most machines now. > > Brice > > ___ > hwloc-devel mailing list > hwloc-de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/ multiline-legend-take-2.diff Description: Binary data
