Jeff Squyres, le Thu 17 Dec 2009 07:51:34 -0500, a écrit :
> > > Re make check - I know it exists, but it was difficult to integrate the
> > > embedded test in with the existing "check" target because the embedded
> > > test
> > > effectively needs a full hwloc tarball to compile against.
> >
> >
On Dec 17, 2009, at 6:47 AM, Samuel Thibault wrote:
> > I see you added some casts, too. ;)
>
> Yes, but carefully :p
Fair 'nuff. :-)
> > Re make check - I know it exists, but it was difficult to integrate the
> > embedded test in with the existing "check" target because the embedded test
> >
Jeff Squyres (jsquyres), le Thu 17 Dec 2009 05:33:45 -0600, a écrit :
> I see you added some casts, too. ;)
Yes, but carefully :p
> Re make check - I know it exists, but it was difficult to integrate the
> embedded test in with the existing "check" target because the embedded test
> effectively n
No type good.
- Original Message -
From: hwloc-devel-boun...@open-mpi.org
To: Hardware locality development list
Sent: Thu Dec 17 04:57:19 2009
Subject: Re: [hwloc-devel] signed / unsigned
Jeff Squyres, le Wed 16 Dec 2009 21:51:38 -0500, a écrit :
> On Dec 16, 2009, at 9:03 PM, Jeff Squ
Jeff Squyres, le Wed 16 Dec 2009 21:51:38 -0500, a écrit :
> On Dec 16, 2009, at 9:03 PM, Jeff Squyres wrote:
> > Ok, done. Please review:
> >
> >https://svn.open-mpi.org/trac/hwloc/changeset/1475
>
> I definitely broke something. :-(
I've fixed everything. Please note that these gcc warn
On Dec 16, 2009, at 9:03 PM, Jeff Squyres wrote:
> Ok, done. Please review:
>
>https://svn.open-mpi.org/trac/hwloc/changeset/1475
I definitely broke something. :-(
>From my embedding test, I make a trivial app that does the following:
mytest_hwloc_topology_init(&topology);
m
Ok, done. Please review:
https://svn.open-mpi.org/trac/hwloc/changeset/1475
Additionally, there were a whole pile of signed/unsigned comparisons left in
lstopo-draw.c that I am a bit too tired to figure out -- could you guys resolve
them?
On Dec 16, 2009, at 4:58 PM, Brice Goglin wrote:
Jeff Squyres wrote:
> On Dec 16, 2009, at 3:35 PM, Jeff Squyres wrote:
>
>
>> While preparing to SVN commit, I made the default for HG checkouts to
>> compile with debug and picky modes. I now see a TRUCKLOAD of
>> signed/unsigned comparison warnings. I'll look into these right now...
>>
