Integrated: 8283324: CLDRConverter run time increased by 3x

2022-04-21 Thread Naoto Sato
On Mon, 18 Apr 2022 23:16:18 GMT, Naoto Sato wrote: > Fixing performance regression caused by the fix to > https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra > looping through the resource map multiple times which was not necessary. The > execution time of the tool now

Re: RFR: 8285370: Fix typo in jdk.charsets

2022-04-21 Thread Naoto Sato
On Thu, 21 Apr 2022 11:34:14 GMT, Magnus Ihse Bursie wrote: > `codespell` could just find a single typo in the files covered by the i18n > alias. Just fixing the typo did not make the comment more readable, so I > rewrote it slightly. Marked as reviewed by naoto (Reviewer). - PR:

Re: RFR: 8285370: Fix typo in jdk.charsets

2022-04-21 Thread Magnus Ihse Bursie
On Thu, 21 Apr 2022 11:47:30 GMT, Alan Bateman wrote: >> `codespell` could just find a single typo in the files covered by the i18n >> alias. Just fixing the typo did not make the comment more readable, so I >> rewrote it slightly. > > src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM942C.java.

Re: RFR: 8285370: Fix typo in jdk.charsets

2022-04-21 Thread Alan Bateman
On Thu, 21 Apr 2022 11:34:14 GMT, Magnus Ihse Bursie wrote: > `codespell` could just find a single typo in the files covered by the i18n > alias. Just fixing the typo did not make the comment more readable, so I > rewrote it slightly. Marked as reviewed by alanb (Reviewer). src/jdk.charsets/s

RFR: 8285370: Fix typo in jdk.charsets

2022-04-21 Thread Magnus Ihse Bursie
`codespell` could just find a single typo in the files covered by the i18n alias. Just fixing the typo did not make the comment more readable, so I rewrote it slightly. - Commit messages: - Fix typo in charsets Changes: https://git.openjdk.java.net/jdk/pull/8335/files Webrev: htt

Re: RFR: 8283324: CLDRConverter run time increased by 3x

2022-04-21 Thread Magnus Ihse Bursie
On Mon, 18 Apr 2022 23:16:18 GMT, Naoto Sato wrote: > Fixing performance regression caused by the fix to > https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra > looping through the resource map multiple times which was not necessary. The > execution time of the tool now

RFR: 8285306: Fix typos in java.desktop

2022-04-21 Thread Magnus Ihse Bursie
I ran `codespell` on the `src/java.desktop` directory, and accepted those changes where it indeed discovered real typos. I ignored typos in public methods and variables. Maybe they can be fixed later on without much fanfare, if they are in internal classes. Typos in exposed APIs are likely here