Re: [9] RFR: 8048123: Replace calendars.properties with another mechanism to specify a new Japanese calendar era

2014-07-23 Thread Masayoshi Okutsu
Revised the webrev: http://cr.openjdk.java.net/~okutsu/9/8048123/webrev.01 The changes from the previous one are: - Changed (originally ) to {@code - Replaced StringTokenizer with String.split() - Eliminated RuntimeException Thanks, Masayoshi On 7/23/2014 8:12 AM, Masayoshi Okutsu wrote: Than

Re: [9] RFR: 8048123: Replace calendars.properties with another mechanism to specify a new Japanese calendar era

2014-07-23 Thread Alan Bateman
On 23/07/2014 09:46, Masayoshi Okutsu wrote: Revised the webrev: http://cr.openjdk.java.net/~okutsu/9/8048123/webrev.01 The changes from the previous one are: - Changed (originally ) to {@code - Replaced StringTokenizer with String.split() - Eliminated RuntimeException The use of {@code ..} and

Re: [9] RFR: 8048123: Replace calendars.properties with another mechanism to specify a new Japanese calendar era

2014-07-23 Thread Naoto Sato
Although I believe the incorrect behavior would be very obvious ("era" specified in the property would simply be not used), I would agree the failed property be better logged. Naoto On 7/23/14, 6:23 AM, Alan Bateman wrote: On 23/07/2014 09:46, Masayoshi Okutsu wrote: Revised the webrev: http

Re: [9] RFR: 8048123: Replace calendars.properties with another mechanism to specify a new Japanese calendar era

2014-07-23 Thread Masayoshi Okutsu
The expected property usage, which hasn't changed from the properties file, is that we will provide the correct property value of any new era probably with a test program which will verify the given values. For JDK 6 to 8, the updated property file will need to be provided by us with a test pro