that kind of information in the
commit message.
With that information:
Acked-by: Henrique de Moraes Holschuh
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index c404706379d9..69402758b99c 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
On Wed, 06 Jan 2021, Joe Perches wrote:
> On Wed, 2021-01-06 at 14:36 +0800, YANG LI wrote:
> > The snprintf() function returns the number of characters which would
> > have been printed if there were enough space, but the scnprintf()
> > returns the number of characters which were actually printed
On Mon, 27 Jul 2020, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 10:49 AM Andy Shevchenko
> wrote:
> > On Mon, Jul 27, 2020 at 10:45 AM Hans de Goede wrote:
> > >
> > > Hi,
> > >
> > > On 7/27/20 2:50 AM, Henrique de Moraes Holschuh wrote:
&g
On Tue, 21 Jul 2020, Dmitry Torokhov wrote:
> On Sun, Jul 19, 2020 at 07:56:49PM -0300, Henrique de Moraes Holschuh wrote:
> > On Fri, 17 Jul 2020, Hans de Goede wrote:
> > > This is a simple patch-series adding support for 3 new hotkeys found
> > > on various
On Fri, 17 Jul 2020, Hans de Goede wrote:
> This is a simple patch-series adding support for 3 new hotkeys found
> on various new Lenovo Thinkpad models.
For all three patches, pending an ack for the new keycodes by the input
maintainers:
Acked-by: Henrique de Moraes Holschuh
--
He
On Mon, 01 Jun 2020, Mark Pearson wrote:
> Newer Lenovo Thinkpad platforms have support to identify whether the
> system is on-lap or not using an ACPI DYTC event from the firmware.
>
> This patch provides the ability to retrieve the current mode via sysfs
> entrypoints and will be used by
On Wed, 06 May 2020, Leonhard Klein wrote:
> I just upgraded my T60 from some old Ubuntu from ~2016 to the newest
> release and found out that the fan is really quiet --- and the thing is
> overheating under load (crashing).
Try to remove anything you had installed to "control fan speed", nothing
On Fri, 15 May 2020, Andrzej Pietrasiewicz wrote:
> Use the new helper. Inspecting input device's 'users' member needs to be
> done under device's mutex, so add appropriate invocations.
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Henrique de Moraes Hols
On Wed, 29 Apr 2020, Stefan Assmann wrote:
> On 29.04.20 02:20, la...@apache.org wrote:
> > Do you have a use case for that behavior?
> >
> > The previous patch broke the /proc interface, didn't not work with the
> > current version of thinkfan
> > (but a a version with multi-fan support is in th
On Mon, 02 Dec 2019, Jenny wrote:
> Whenever I reattach the keyboard cover, the tablet becomes unresponsive
> to inputs shortly after and has to be rebooted forcefully.
...
> [ 157.064177] int3403 thermal INT3403:01: Unsupported event [0x91]
> [ 157.064181] int3403 thermal INT3403:00: Unsupport
On Sun, 30 Jun 2019, Frank Steiner wrote:
> > with the disk-activity trigger not being connected to NVME, and there is
> > nothing thinkpad-acpi can do about it...
>
> Ok! I was just wondering because NVME disks in our PCs do work with
> disk-activity. Is this connection you mention a hardware pro
On Thu, 27 Jun 2019, Frank Steiner wrote:
> This works fine on all our older thinkpad models with SATA hard disks
> works also on our PCs with SSD disks (SATA as well as NVME), but
> it fails on our newer thinkpads, i.e. T570 and T580 with NVME SSDs.
>
> The LED just stays off all the time no matt
On Mon, 03 Dec 2018, Andy Shevchenko wrote:
> On Fri, Nov 16, 2018 at 3:18 PM Jouke Witteveen wrote:
>
> Please, submit a new version with changelog.
>
> Though, before doing this, I would hear if Henrique is OK with the
> change (for me it looks good)
Acked-by: Henrique
f the ugly direct dynamic
> symbol binding.
For the thinkpad-acpi bits, provided that Andy's comments are addressed:
Acked-by: Henrique de Moraes Holschuh
> I checked briefly on my Dell laptop, and a Thinkpad model.
Thanks :-)
--
Henrique Holschuh
__
On Tue, 23 Oct 2018, Jouke Witteveen wrote:
> > Apparently it has to be fixed properly, because if I understood the
> > issue correctly, every two-character quirk will trigger on *any*
> > three-character model that starts with those two characters.
>
> This should be (and hopefully is) incorrect.
On Mon, 15 Oct 2018, Dmitry Torokhov wrote:
> On Sat, Oct 13, 2018 at 6:32 AM Jaak Ristioja wrote:
> > On 27.08.2018 19:22, Jaak Ristioja wrote:
> > > Upgrading Linux from 4.16 to 4.17, a ThinkPad L570 started receiving
> > > spurious input events, mostly right mouse button click events, but also
On Sat, 13 Oct 2018, Jaak Ristioja wrote:
> On 27.08.2018 19:22, Jaak Ristioja wrote:
> > Upgrading Linux from 4.16 to 4.17, a ThinkPad L570 started receiving
> > spurious input events, mostly right mouse button click events, but also
> > cursor jumps.
> >
> > I have not attempted to understand wh
On Fri, 07 Sep 2018, Yves-Alexis Perez wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On Fri, 2018-09-07 at 19:59 +0200, Thomas Weißschuh wrote:
> > > was this included in any tree and is it on route to Linus somehow?
> >
> > This is on track to be released in 4.19.
>
> Thanks. I
On Wed, 01 Aug 2018, Andy Shevchenko wrote:
> On Wed, Aug 1, 2018 at 5:32 PM, Jouke Witteveen wrote:
> > Based on bug reports and a web search for
> > "Thinkpad_acpi: Error probing battery 2"
> > four more models were found that require the battery quirk:
> > Lenovo B5400, Thinkpad 11e (origin
ery and ACPI calls would fail.
>
> Signed-off-by: Jouke Witteveen
Acked-by: Henrique de Moraes Holschuh
> Compared to the previous version of this patch, four new models were found
> that need the quirk. It was tested on the Thinkpad 13 (three character ID)
> and the Thinkpad 11e (
s impossible.
>
> Fixes: 1b0eb5bc2413
> Signed-off-by: Jouke Witteveen
Acked-by: Henrique de Moraes Holschuh
> This has now been tested on both 3-character models (Thinkpad 13) and two
> character models (Thinkpad 11e).
> The part one of this series is identical to the previously
On Mon, 30 Jul 2018, Thomas Weißschuh wrote:
> On Sat, 2018-06-16T11:39+0200, Thomas Weißschuh wrote:
> > Previously the struct containing the supported operations for all
> > batteries was zeroed every time a battery was probed.
> > This prevented all batteries except the lastly probed one from be
ery and ACPI calls would fail.
>
> Signed-off-by: Jouke Witteveen
Needs patch 1/1 to be acked-by first before being accepted, but otherwise:
Acked-by: Henrique de Moraes Holschuh
--
Henrique Holschuh
--
Check ou
On Wed, 11 Jul 2018, Jouke Witteveen wrote:
> Modern Thinkpads have three character model designators. Previously, they
> would be accepted, but recorded incompletely. Revision matching extracted
> the wrong bytes from the ID string. This made the use of quirks for modern
> machines impossible.
>
On Tue, 19 Jun 2018, Benjamin Berg wrote:
> > That said, it would be nice to know if other models also have this
> > hotkey, especially if it has a different meaning (in which case we just
> > special-case the keymap in the driver, so it is *not* a problem).
>
> I believe this is not specific to t
D,/* Clipping tool */
> - KEY_RESERVED,
> + KEY_CALC,/* Calculator (above numpad), 0x313 */
Replace 0x313 with (P52) please.
Other than that,
Acked-by: Henrique de Moraes Holschuh
That said, it would be nice to know if other models also have this
hotkey,
On Sat, 16 Jun 2018, Thomas Weißschuh wrote:
> The error codes for ACPI failures when setting battery start and stop
> thresholds were gobbling the real error code and also inconsistent.
Well, we do not care for ACPI failure codes (other than the fact it
failed): we care for proper errno return to
On Sat, 16 Jun 2018, Pavel Machek wrote:
> Question is if we want flexibility or security.
For thinkpad-acpi, it is security by default. Flexibility is allowed as
*compile*-time (Kconfig) option, and only as long as it defaults to
secure *and* the help text is very explicit at instructing distros
On Fri, 15 Jun 2018, Pali Rohár wrote:
> This means that kernel should not export any led class device. Or when
> exported, then "set" operation should always fail.
"not export" is right.
> > 2. Otherwise implement it in-kernel, so that userspace cannot unmute
> >when the human has activated
On Fri, 15 Jun 2018, Pali Rohár wrote:
> Henrique, any idea why there are no exported led classes for mute and
> micmute? And how are suppose to be controlled?
I have to look into the code, it was contributed by someone who had
access to the proper hardware to test it.
But the way *I* would like
On Fri, 08 Jun 2018, Pali Rohár wrote:
> which has only 4.9 kernel and LEN0268 identifier was added in git commit
> a3c42a467a254a17236ab817d5c7c6bc054e4f84 for 4.10.
You could always request it to be backported to -stable *if* you
manually apply it to a 4.9 kernel and test the heck out of it...
On Mon, 21 May 2018, Kevin Locke wrote:
> as-expected. The only oddity I noticed is that force_discharge has a
> delay taking effect (<1 sec) transitioning from 0 to 1 (but not 1 to
> 0).
The EC can take its sweet time to obey any such requests ;-)
--
Henrique Holschuh
--
On Mon, 14 May 2018, Ognjen Galić wrote:
> On Mon, May 14, 2018 at 08:39:28AM -0300, Henrique de Moraes Holschuh wrote:
> > On Mon, 14 May 2018, Christoph Böhmwalder wrote:
> > > > + case INHIBIT_CHARGE:
> > > > + if ACPI_FAILURE(tpa
On Sun, 13 May 2018, Ognjen Galic wrote:
> +Battery force discharging
> +--
> +
> +There is also support for AC overriding. This means that you can force the
> battery to discharge
> +even when AC is attached. This is also exposed via the generic ACPI driver:
> +
> +/sys/cl
On Mon, 14 May 2018, Christoph Böhmwalder wrote:
> > + case INHIBIT_CHARGE:
> > + if ACPI_FAILURE(tpacpi_battery_acpi_eval(GET_INHIBIT, ret,
> > battery))
> > + return -ENODEV;
> > +
> > + /* The inhibit charge status is in the first bit */
> > + *
On Thu, 26 Apr 2018, Jordan Glover via ibm-acpi-devel wrote:
> I have to admit that I can't handle booting and checking this in tablet mode
> (without keyboard) so I won't confirm it, sorry.
FWIW, any USB keyboard should allow you to do this easily if there is at
least one USB port still exposed w
(changed subject and split email thread on purpose).
On Wed, 25 Apr 2018, Jordan Glover wrote:
> thinkpad_acpi: Unknown/reserved multi mode value 0x for type 4,
> please report this to ibm-acpi-devel@lists.sourceforge.net
>
> After reboot this message is gone. Previously it was printed on eve
Demote to debug level one existing thermal-control related event, and
also add two new ones that would otherwise trigger unknown event
warnings. These events are Windows-only for now.
We do report them to userspace in case they become useful in the future.
Signed-off-by: Henrique de Moraes
We should not do a thermal sensors state dump to the kernel log just
because the laptop is reporting that it changed into or out of tablet
mode.
Signed-off-by: Henrique de Moraes Holschuh
Tested-by: Jordan Glover
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion
Do not consider unknown HKEY events in the 0x6000 range to be thermal
warnings. Instead, handle them as a generic unknown HKEY event, which
are reported to the kernel log at priority "notice", and do not trigger
a thermal registers state dump to the log.
Signed-off-by: Henrique
On Tue, 24 Apr 2018, Jordan Glover via ibm-acpi-devel wrote:
> On April 20, 2018 5:17 PM, Henrique de Moraes Holschuh
> wrote:
> > I will send the (untested) patches, please test.
>
> I tested patches on top of Linux 4.17-rc1. The warning message is gone,
> everything wo
On Fri, 20 Apr 2018, Jordan Glover wrote:
> On April 9, 2018 4:58 AM, Henrique de Moraes Holschuh wrote:
>
> > On Tue, 03 Apr 2018, Henrique de Moraes Holschuh wrote:
> >
> > > > Would you mind giving some hints to Jordan? Thanks.
> > >
> > >
We should not do a thermal sensors state dump to the kernel log just
because the laptop is reporting that it changed into or out of tablet
mode.
Signed-off-by: Henrique de Moraes Holschuh
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Do not consider unknown HKEY events in the 0x6000 range to be thermal
warnings. Instead, handle them as a generic unknown HKEY event, which
are reported to the kernel log at priority "notice", and do not trigger
a thermal registers state dump to the log.
Signed-off-by: Henrique
Demote to debug level one existing thermal-control related event, and
also add two new ones that would otherwise trigger unknown event
warnings. These events are Windows-only for now.
We do report them to userspace in case they become useful in the future.
Signed-off-by: Henrique de Moraes
On Tue, 03 Apr 2018, Henrique de Moraes Holschuh wrote:
> > Would you mind giving some hints to Jordan? Thanks.
>
> Not a problem, I will either give hints or write the patch myself soon.
> Poke me in one week if I did not reply by that timeframe, please.
Patches written (fixed
On Thu, 05 Apr 2018, Sasha Levin wrote:
> This commit has been processed by the -stable helper bot and determined
> to be a high probability candidate for -stable trees. (score: 9.2381)
>
> The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92,
> v4.4.126,
>
> v4.15.15: Build OK!
t; From: Jordan Glover [mailto:golden_mille...@protonmail.ch]
> Sent: Tuesday, April 3, 2018 8:04 PM
> To: Peter FP1 Zhang
> Cc: Henrique de Moraes Holschuh ; Andy Shevchenko
> ; Platform Driver
> ; Darren Hart ;
> Christian Kellner ;
> ibm-acpi-devel@lists.sourceforge
igned-off-by: Alexander Kappner
I assume you tested this on real hardware? If so:
Acked-by: Henrique de Moraes Holschuh
> ---
> drivers/platform/x86/thinkpad_acpi.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/dri
On Thu, 15 Feb 2018, Andy Shevchenko wrote:
> (Luckily entire discussion is kept in this mail)
>
> On Thu, Feb 1, 2018 at 4:07 AM, Peter FP1 Zhang wrote:
> > Dear all,
> >
> > I was told by our BIOS/Thermal team that the two events are designed for
> > Windows OS, for Linux we can just ignore th
On Wed, 07 Feb 2018, Ognjen Galic wrote:
> The EC/ACPI firmware on Lenovo ThinkPads used to report a status
> of "Unknown" when the battery is between the charge start and
> charge stop thresholds. On Windows, it reports "Not Charging"
> so the quirk has been added to also report correctly.
>
> No
Acked-by: Henrique de Moraes Holschuh
--
Henrique Holschuh
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/sla
On Tue, 02 Jan 2018, mth...@mthode.org wrote:
> From: Matthew Thode
>
> Signed-off-by: Matthew Thode
Please, could you add some far more verbose explanations to the
(currently empty) commit log?
Such as: which thinkpad models you know to have this feature, how one is
expected to use it, in whi
On Tue, 19 Dec 2017, SF Markus Elfring wrote:
> >> Delete an error message for a failed memory allocation in three functions
> >
> > This one is questionable since it prints error messages at ->init() stage.
> > I would rather not touch this.
>
> Do you find the Linux allocation failure report
On Tue, 19 Dec 2017, Andy Shevchenko wrote:
> On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring
> wrote:
> > From: Markus Elfring
> > Date: Mon, 18 Dec 2017 22:23:45 +0100
> >
> > Two update suggestions were taken into account
> > from static source code analysis.
> >
> > Markus Elfring (2):
>
On Mon, 09 Oct 2017, Peter wrote:
> This is the exact same as reported months before on this mailing list:
> https://sourceforge.net/p/ibm-acpi/mailman/message/35803112/
> Unfortunately, this went unanswered.
Yeah, sorry about that. We need to done down the driver messages a
bit...
> The event
On Thu, 05 Oct 2017, Raph wrote:
> > BTW, the DSDT has HFSP in the EC space at the expected offset (0x2f), so
> > you *could* try to enable fan control in thinkpad-acpi and force the fan
> > to level 7. If that turns on the fan, then the question becomes WTF is
> > turning it out of "auto" mode in
On Sat, 30 Sep 2017, Raph wrote:
> I didn't find XSDT/RSDP tables (but maybe I didn't understand the concept)
Nah, I screwed up. I need all the SSDT tables, not the XSDT.
BTW, the DSDT has HFSP in the EC space at the expected offset (0x2f), so
you *could* try to enable fan control in thinkpad-ac
On Wed, 27 Sep 2017, Steven Presser wrote:
> I have some new elements to this puzzle that may be useful:
>
> - I've extracted the ACPI DST table. This device, like the X1 Yoga
> (https://patchwork.kernel.org/patch/9395641/) has the MHKG method. But on
> this device it's a no-op! (just returns z
On Thu, 28 Sep 2017, Raph wrote:
> On Sun, Sep 24, 2017 at 07:11:47PM -0300, Henrique de Moraes Holschuh wrote:
> => but should a working Kaveri provide a fifth, GPU-specific, cooling device?
No idea. Not necessarily.
> thinkpad_acpi parameters of interest are:
> /sys/modul
On Sun, 24 Sep 2017, Raph wrote:
> On Sat, Sep 16, 2017 at 08:34:08AM -0300, Henrique de Moraes Holschuh wrote:
> > On Wed, 13 Sep 2017, Raf D wrote:
> > > I own a Lenovo E555.
> > > After the switch from Debian Jessie to Stretch fan stopped working
> > > Sympt
On Wed, 13 Sep 2017, Raf D wrote:
> I own a Lenovo E555.
> After the switch from Debian Jessie to Stretch fan stopped working
> Symptom: overheat then halt circa 90° and fan does not wake up.
>
> Booting with acpi=off: fan run automatically when needed as it should.
We need to know if the issue
rk in other cases.
>
> Thanks to Peter Zhang of Lenovo for providing information on how to use the
> GMMS method to query the tablet mode.
>
> Signed-off-by: Benjamin Berg
> Cc: Peter FP1 Zhang
> Cc: Lyude Paul
Looks good.
Acked-by: Henrique de Moraes Holschuh
---
PS: p
On Fri, 18 Aug 2017, Darren Hart wrote:
> > before:
> > $ cat /sys/devices/platform/thinkpad_hwmon/{name,fan1_input}
> > after:
> > $ cat /sys/devices/platform/thinkpad_hwmon/hwmon/hwmon1/{name,fan1_input}
> > thinkpad
> > 3478
> > $ cat /sys/class/hwmon/hwmon1/{name,fan1_input}
> > thinkpad
> > 3
On Mon, 19 Jun 2017, Stanislav Fomichev wrote:
> Use hwmon_device_register_with_groups instead of deprecated
> hwmon_device_register and fix a dmesg warning.
>
> This patch however changes the userspace API.
> hwmon_device_register_with_groups takes `hwmon' name as an argument and
> creates
> a n
On Fri, 09 Jun 2017, Greg Kroah-Hartman wrote:
> We are trying to get rid of DRIVER_ATTR(), and the thinkpad_acpi
> driver's attributes can be trivially changed to use DRIVER_ATTR_RO() and
> DRIVER_ATTR_RW().
>
> Cc: Henrique de Moraes Holschuh
> Cc: Darren Hart
>
On Sun, 21 May 2017, neil k wrote:
> attachment.) If I boot up the laptop with the lid closed, it won't start
> thermal throttling until after I trigger the event for the first time. So
Some people broke the LID handling hideously for dubious reasons on
later kernel versions, and I don't know ex
On Sat, 13 May 2017, Hrvoje Stojic wrote:
> Are there any solutions for these issues?
A newer kernel should support the 0x13xx hotkeys, I think. It is also
possible to patch support into 4.9. But mostly you can just ignore the
reports in dmesg.
--
Henrique Holschuh
-
On Sun, 14 May 2017, neil k wrote:
> Thanks for the response Henrique. I do have the laptop setup not to
> suspend when I close the lid.
Ok.
> So 60C / ~2.0GHz sounds right to you if I have it set to "balanced" for
> battery power, as opposed to the 80C / ~2.9GHz when I run on battery with
> the
On Fri, 12 May 2017, Pavel Machek wrote:
> On Sun 2017-05-07 20:49:03, Henrique de Moraes Holschuh wrote:
> > On Sun, 07 May 2017, Pavel Machek wrote:
> > > On Thu 2017-01-19 12:21:32, Adam Goode wrote:
> > > > This allows the control of the red status LED, which
On Wed, 10 May 2017, Lars Kellogg-Stedman wrote:
> I'm looking for some help getting Linux to successfully detect the switch
> between tablet/notebook mode on a Yoga 11e. With v4.11.0, it doesn't look
> like the kernel sees any events generated by switching mode: acpi_listen
> doesn't show anythin
On Thu, 04 May 2017, John Marc Imbrescia wrote:
> These 3 key presses are F10-F12 without the Fn key pressed. They're
> labeled "Bluetooth" "Keyboard" "Star"
Thanks for the report!
> Other multimedia keys work as expected.
>
> On Thu, May 4, 2017 at 11:08 AM, John Marc Imbrescia
> wrote:
>
>
On Sat, 22 Apr 2017, neil k wrote:
> I spent some more time testing this today. It seems like it only happens
> when I close the lid while *running on battery*. If I close the lid with
Yeah, that event is some sort of hint to the Lenovo Windows drivers to
change their behavior, or to reprogram som
On Wed, 10 May 2017, Andy Shevchenko wrote:
> Okay, what I'm going to do is:
> 1) drop patch 1 for now;
> 2) split patch 2 into two patches (and append your Ack on both);
> 3) push to our testing branch (I can send v2 if we need one more round
> of review).
>
> Tell me if there is any objection.
On Tue, May 9, 2017, at 14:33, Andy Shevchenko wrote:
> On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh wrote:
> > > While here, print negative error without changing a sign as it is a
> > > common pattern in the kernel.
> >
> > A separate patch f
bove there were no functional changes intended.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Henrique de Moraes Holschuh
> ---
> drivers/platform/x86/thinkpad_acpi.c | 182
> +--
> 1 file changed, 65 insertions(+), 117 deletions(-)
&g
hy 0 is used as permissions in
> module_param_call().
>
> [1]: https://patchwork.ozlabs.org/patch/713245/
>
> Cc: Richard Weinberger
> Signed-off-by: Andy Shevchenko
Acked-by: Henrique de Moraes Holschuh
> ---
> drivers/platform/x86/thinkpad_acpi.c | 1 +
> 1 file
On Tue, 09 May 2017, Andy Shevchenko wrote:
> The commit 4be73005e4dc
>
> ("thinkpad-acpi: remove uneeded tp_features.hotkey tests in
> hotkey_exit")
>
> adds a complex logic behind hotkey status check in a way
> it started mixing logical operations with bitwise ones.
>
> Refactor the cod
On Sun, 07 May 2017, Pavel Machek wrote:
> On Thu 2017-01-19 12:21:32, Adam Goode wrote:
> > This allows the control of the red status LED, which is the dot of the "i"
> > in the word "ThinkPad" on the outside cover of newer models.
> >
> > In the manual, both this LED and the power LED are referr
On Wed, 03 May 2017, Marco Marzetti wrote:
> For some reason /proc/acpi/button/lid/LID/state is always open even if
> the lid is closed.
> I am quite annoyed by the issue, but i ran out of options pretty fast
>
> Hardware is Lenovo X1 Carbon 2nd edition.
> Below you can find:
> - dmesg
> - dmide
> Reviewed-by: Hans de Goede
Acked-by: Henrique de Moraes Holschuh
--
Henrique Holschuh
--
Check out the vibrant tech community on one of the world's most
engaging tech s
efore we introduce a TP_ACPI_HOTKEYSCAN_ADAPTIVE_START and
> ensure that we are in the range 0 and ADAPTIVE_START for the generic
> keycode case.
>
> Signed-off-by: Christian Kellner
> Reviewed-by: Hans de Goede
Acked-by: Henrique de Moraes Ho
ooth (0x1314) and open they keyboard
> settings (0x1315).
>
> The third nibble (0xf00) is used to differentiate between the original
> hotkeys, the adaptive keyboard codes and the new, additional ones.
Looks good.
Acked-by: Henrique de Moraes Holschuh
On Sat, 25 Feb 2017, Christian Kellner wrote:
> @@ -1923,7 +1923,8 @@ enum { /* hot key scan codes (derived from ACPI DSDT)
> */
> TP_ACPI_HOTKEYSCAN_UNK7,
> TP_ACPI_HOTKEYSCAN_UNK8,
>
> - TP_ACPI_HOTKEYSCAN_MUTE2,
> + TP_ACPI_HOTKEYSCAN_ADAPTIVE_START = 32,
> + TP_ACPI_
Hello Adam,
I apologise for the delay on answering you.
On Tue, 31 Jan 2017, Adam Goode wrote:
> On Thu, Jan 19, 2017 at 12:21 PM, Adam Goode wrote:
> > This allows the control of the red status LED, which is the dot of the "i"
> > in the word "ThinkPad" on the outside cover of newer models.
> >
On Sun, 15 Jan 2017, Hans de Goede wrote:
> Do you want me to also send out a new version of the platform patches when
> I send the next shot at the LED side of things, or shall I keep those
> in my personal tree until the LED api is finalized ?
If you don't sent the entire patch set here, please
On Fri, 25 Nov 2016, Tobias Klauser wrote:
> Fix an [-Wold-style-declaration] GCC warning by moving the inline
> keyword before the return type.
>
> Signed-off-by: Tobias Klauser
Acked-by: Henrique de Moraes Holschuh
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
&g
is 0x200 instead of
> 0x100. So adding the new ID into the driver.
This usually means Lenovo expects to have different windows drivers.
Does thinkpad-acpi work properly on these new thinkpads?
If it does, you have my
Acked-by: Henrique de Moraes Holschuh
> Signed-off-by: Hui Wang
>
On Mon, 07 Nov 2016, Lyude wrote:
> There's no need to have multiple copies of the logic we use for checking
> whether or not we're in tablet mode, so just use
> hotkey_get_tablet_mode() when checking the initial state in
> hotkey_init_tablet_mode().
...
> @@ -3130,13 +3130,16 @@ hotkey_init_tabl
On Mon, 07 Nov 2016, Lyude wrote:
> For whatever reason, the X1 Yoga doesn't support the normal method of
> querying for tablet mode. Instead of providing the MHKG method under the
> hotkey handle, we're instead given the CMMD method under the EC handle.
> Values on this handle are either 0x1, lapt
init_tablet_mode(void)
> +{
Function definiton all in one line, please.
Provided that you fix that minor nit,
Acked-by: Henrique de Moraes Holschuh
--
Henrique Holschuh
--
Developer Access Program for Intel Xeon
On Sat, 05 Nov 2016, Pavel Machek wrote:
> On Sat 2016-11-05 15:46:12, Henrique de Moraes Holschuh wrote:
> > On Sat, 05 Nov 2016, Pavel Machek wrote:
> > > Hmm, thanks for the pointer. But it seems like I'll have to build my
> > > own, as /proc/acpi/ibm does not
On Sat, 05 Nov 2016, Darren Hart wrote:
> On Mon, Oct 31, 2016 at 07:56:40PM -0400, Lyude wrote:
> > Suggested by Daniel Martin
> >
> > Lenovo's having a bit of fun randomly changing what hotkey events and
> > acpi handles they use for reporting tablet mode, so unfortunately this
> > means we're
On Sat, 05 Nov 2016, Darren Hart wrote:
> On Thu, Oct 27, 2016 at 03:46:44PM -0400, Lyude wrote:
> > For whatever reason, the X1 Yoga doesn't support the normal method of
> > querying for tablet mode. Instead of providing the MHKG method under the
> > hotkey handle, we're instead given the CMMD met
On Sat, 05 Nov 2016, Pavel Machek wrote:
> [ 825.759661] thinkpad_acpi: THERMAL EMERGENCY: a sensor reports something
> is extremely hot!
> [ 825.761935] thinkpad_acpi: temperatures (Celsius): 101 49 N/A 78 33 N/A 33
> N/A 47 50 N/A N/A N/A N/A N/A N/A
Oh boy, that must be the second time in a
On Sat, 05 Nov 2016, Pavel Machek wrote:
> Hmm, thanks for the pointer. But it seems like I'll have to build my
> own, as /proc/acpi/ibm does not follow the usual infrastructure...
/proc/acpi/ibm has been deprecated for years. 99% of the functionality
is available through more modern, standard in
On Thu, 27 Oct 2016, Lyude Paul wrote:
> as well, can someone confirm this patch made it to the ibm-acpi-devel
> list? When I originally sent this I realized I wasn't subscribed to the
> list, so I'm guessing I might need to resend.
I received it. I just didn't have the time to go over it in deta
hat grounds.
for the thinkpad-acpi bits:
Acked-by: Henrique de Moraes Holschuh
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index b65ce75..31fb979 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x
(cc list trimmed)
On Tue, 02 Aug 2016, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
>
eter value 2 to
> > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > that case there is no adaptive keyboard available.
> > >
> > > Signed-off-by: Dennis Wassenberg
> > > Signed-off-by: Lyude
> > > Tested-by: Lyude
&g
1 - 100 of 1755 matches
Mail list logo
