On Thu, 29 Nov 2018 22:23:31 +0100,
Jacek Anaszewski wrote:
>
> On 11/28/2018 10:22 PM, Pavel Machek wrote:
> > Hi!
> >
> >>> If external USB keyboard is identified as "input7" device, then
> >>> "input7::mute" is a good name for mute key. But "sys::mute" does not say
> >>> anything to which devi
On Thu, 29 Nov 2018 08:31:25 +0100,
Takashi Iwai wrote:
>
> Hi,
>
> this is revised patch series for adding a new LED trigger audio-mute
> and audio-micmute, and converting the HD-audio driver and the platform
> drivers to use the LED trigger instead of the ugly direct dynami
Since we've switched to the LED trigger for binding with HD-audio,
we can drop the exported function as well as the whole
linux/dell-led.h.
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Andy Shevchenko
Acked-by: Pali Rohár
Signed-off-by: Takashi Iwai
---
drivers/platfor
e is based cleanly on
v4.20-rc3. From now on, it'll stay as an immutable branch, so feel
free to merge into other trees.
thanks,
Takashi
===
Takashi Iwai (6):
leds: trigger: Introduce audio mute LED trigger
platform/x86: dell-laptop: Add micmute LED trigger support
platform/x86: thinkpad_
evchenko
Acked-by: Pali Rohár
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/Kconfig | 2 ++
drivers/platform/x86/dell-laptop.c | 25 +
2 files changed, 27 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 54f6a40c7
CMUTE, respectively. They are no longer needed as
referred only locally.
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Andy Shevchenko
Acked-by: Henrique de Moraes Holschuh
Acked-by: Pali Rohár
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/thinkpad_acpi.c
ad.
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Pali Rohár
Signed-off-by: Takashi Iwai
---
sound/pci/hda/dell_wmi_helper.c | 48 -
sound/pci/hda/hda_generic.c | 31 +
sound/pci/hda/hda_generic.h | 2 ++
sound/pci
schuh
Acked-by: Pali Rohár
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/Kconfig | 2 +
drivers/platform/x86/thinkpad_acpi.c | 57 +---
2 files changed, 53 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x8
upcoming huawei-wmi).
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
Acked-by: Pali Rohár
Signed-off-by: Takashi Iwai
---
drivers/leds/trigger/Kconfig | 7 +
drivers/leds/trigger/Makefile| 1 +
drivers/leds/trigger/ledtrig-audio.c | 44
On Wed, 28 Nov 2018 13:25:05 +0100,
Pavel Machek wrote:
>
> On Wed 2018-11-28 12:38:19, Takashi Iwai wrote:
> > On Wed, 28 Nov 2018 12:18:06 +0100,
> > Pali Rohár wrote:
> > >
> > > On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote:
> > > > L
On Wed, 28 Nov 2018 12:18:06 +0100,
Pali Rohár wrote:
>
> On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote:
> > Looks good... except one detail: you have "tpacpi::micmute" and
> > "dell::micmute". I know it follows "tradition", but we are trying to
> > fix that at the moment. Laptop micmute
On Wed, 28 Nov 2018 12:14:34 +0100,
Pali Rohár wrote:
>
> On Monday 26 November 2018 18:11:20 Takashi Iwai wrote:
> > Hi,
> >
> > this is patch series I've hacked after useful conversation with
> > Pavel. Basically this adds a new LED trigger audio-mute and
&g
On Tue, 27 Nov 2018 11:26:32 +0100,
Henrique de Moraes Holschuh wrote:
>
> On Mon, 26 Nov 2018, Takashi Iwai wrote:
> > this is patch series I've hacked after useful conversation with
> > Pavel. Basically this adds a new LED trigger audio-mute and
> > audio-micm
On Tue, 27 Nov 2018 09:44:18 +0100,
Pavel Machek wrote:
>
> Hi!
>
> > this is patch series I've hacked after useful conversation with
> > Pavel. Basically this adds a new LED trigger audio-mute and
> > audio-micmute, and convert the HD-audio driver and the platform
> > drivers to use the LED tri
On Mon, 26 Nov 2018 23:58:36 +0100,
Andy Shevchenko wrote:
>
> On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai wrote:
> >
> > This patch adds a new LED trigger for coupling the audio mixer change
> > with the LED on laptops or other devices. Currently there are two
> &
On Tue, 27 Nov 2018 00:09:17 +0100,
Andy Shevchenko wrote:
>
> On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai wrote:
> >
> > Hi,
> >
> > this is patch series I've hacked after useful conversation with
> > Pavel. Basically this adds a new LED trigger audi
On Tue, 27 Nov 2018 00:04:40 +0100,
Andy Shevchenko wrote:
>
> On Mon, Nov 26, 2018 at 7:13 PM Takashi Iwai wrote:
> >
> > In the upcoming change, the binding of audio mute / mic-mute LED
> > controls will be switched with LED trigger. This patch is the last
> > pi
On Mon, 26 Nov 2018 21:59:24 +0100,
Jacek Anaszewski wrote:
>
> For this patch and FWIW for the whole patch set:
>
> Acked-by: Jacek Anaszewski
Thanks, now added to the series.
The latest patches are found in topic/leds-trigger branch of my sound
git tree.
I'm going to resubmit v2 series tomo
CMUTE, respectively. They are no longer needed as
referred only locally.
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/thinkpad_acpi.c | 30 ++--
include/linux/thinkpad_acpi.h| 16 ---
2 files changed, 11 insertions(+), 35 deletions(-)
delete mode 1
preciated, of course.
thanks,
Takashi
===
Takashi Iwai (6):
leds: trigger: Introduce audio mute LED trigger
platform/x86: dell-laptop: Add micmute LED trigger support
platform/x86: thinkpad_acpi: Add audio mute LED classdev support
ALSA: hda - Support led audio trigger
platform/x8
binding, this test isn't possible, and the
actual check is done in the LED class device side. So it's the
downside of simpleness.
Also, note that the HD-audio codec driver doesn't select CONFIG_LEDS
and co by itself. It's supposed to be selected by the platform
drivers instead.
Si
from the dynamic symbol binding to the
LEDs trigger in a later patch.
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/Kconfig | 2 +
drivers/platform/x86/thinkpad_acpi.c | 56 +---
2 files changed, 52 insertions(+), 6 deletions(-)
diff --git a/drivers/pla
on
easily once after converting from the dynamic symbol binding to the
LEDs trigger in a later patch.
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/Kconfig | 2 ++
drivers/platform/x86/dell-laptop.c | 25 +
2 files changed, 27 insertions(+)
diff --git a/drivers/pl
upcoming huawei-wmi).
Signed-off-by: Takashi Iwai
---
drivers/leds/trigger/Kconfig | 7 +
drivers/leds/trigger/Makefile| 1 +
drivers/leds/trigger/ledtrig-audio.c | 45
include/linux/leds.h | 20 +
4 files changed, 73 insert
Since we've switched to the LED trigger for binding with HD-audio,
we can drop the exported function as well as the whole
linux/dell-led.h.
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/dell-laptop.c | 22 +-
include/linux/dell-led.h | 7 ---
2
On Thu, 21 Jun 2018 13:35:21 +0200,
Damjan Georgievski wrote:
>
> > I applied them to Debian's kernel (with slightly modification) and they
> > are working fine. Via "alsamixer -c 0" I can change "Mic Mute-LED Mode"
> > to "Follow Capture" and then led is ON only when microphone is ON.
> > Recordi
On Thu, 21 Jun 2018 13:24:07 +0200,
Pali Rohár wrote:
>
> On Tuesday 19 June 2018 10:42:12 Takashi Iwai wrote:
> > On Tue, 19 Jun 2018 10:37:12 +0200,
> > Pali Rohár wrote:
> > > Interesting is this part:
> > >
> > > $ head /proc/asound/card0/codec#0
On Tue, 19 Jun 2018 10:37:12 +0200,
Pali Rohár wrote:
>
> On Monday 18 June 2018 13:21:21 Pali Rohár wrote:
> > On Monday 18 June 2018 12:36:31 Takashi Iwai wrote:
> > > On Mon, 18 Jun 2018 12:28:06 +0200,
> > > Pali Rohár wrote:
> > > >
> > &g
On Mon, 18 Jun 2018 13:26:18 +0200,
Pali Rohár wrote:
>
> On Monday 18 June 2018 13:21:21 Pali Rohár wrote:
> > Now I see that in Debian backports is some 4.16.12 kernel version. I can
> > try this one (and later compile one from Linus tree).
>
> Tested, this version is working fine and leds work
On Mon, 18 Jun 2018 12:28:06 +0200,
Pali Rohár wrote:
>
> On Saturday 16 June 2018 18:02:14 Takashi Iwai wrote:
> > On Sat, 16 Jun 2018 17:43:09 +0200,
> > Pali Rohár wrote:
> > >
> > > On Saturday 16 June 2018 09:05:41 Takashi Iwai wrote:
> > > >
On Sat, 16 Jun 2018 17:43:09 +0200,
Pali Rohár wrote:
>
> On Saturday 16 June 2018 09:05:41 Takashi Iwai wrote:
> > On Fri, 15 Jun 2018 21:09:59 +0200,
> > Pali Rohár wrote:
> > >
> > > On Friday 15 June 2018 14:51:47 Takashi Iwai wrote:
> > > >
On Fri, 15 Jun 2018 21:09:59 +0200,
Pali Rohár wrote:
>
> On Friday 15 June 2018 14:51:47 Takashi Iwai wrote:
> > On Fri, 08 Jun 2018 13:10:57 +0200,
> > Pali Rohár wrote:
> > >
> > > Hi! With up-to-date thinkpad_acpi.ko driver on ThinkPad T480s I'm seei
On Fri, 08 Jun 2018 13:10:57 +0200,
Pali Rohár wrote:
>
> Hi! With up-to-date thinkpad_acpi.ko driver on ThinkPad T480s I'm seeing
> a strange behavior of LEDs which are integrated into mic mute (Fn+F4)
> and mute (Fn+F1) keys.
>
> When thinkpad_acpi.ko is not loaded, then mute key is working fin
ht the mute LED is also a part of
thinkpad_acpi's leds_class, but it's not. So, my initial patch is a
correct fix in the end.
Matthew, could you take it please?
thanks,
Takashi
>
> Peter
>
>
> On Thu, 13 Feb 2014 09:35:30 +0100
> Takashi Iwai wrote:
>
>
At Wed, 12 Feb 2014 20:37:36 +,
Matthew Garrett wrote:
>
> On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote:
> > The mute LED states have to be restored after resume.
>
> Oh, never mind, we're not doing this through the LED class, are we?
Good point. It se
The mute LED states have to be restored after resume.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70351
Cc: [v3.13+]
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/thinkpad_acpi.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/platform/x86
SNDRV_CARDS can be specified via Kconfig since 3.11 kernel, so this
can be over 32bit integer range, which leads to a build error.
Cc: [v3.11+]
Signed-off-by: Takashi Iwai
---
drivers/platform/x86/thinkpad_acpi.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers
At Fri, 27 May 2011 14:22:26 -0400,
Andrew Lutomirski wrote:
>
> On Fri, May 27, 2011 at 12:48 PM, Matthew Garrett wrote:
> > On Fri, May 27, 2011 at 12:39:10PM -0400, Andrew Lutomirski wrote:
> >
> >> I don't have docs so I don't really know. But the mute LED does not
> >> appear to be controll
>
> Signed-off-by: Henrique de Moraes Holschuh
> Cc: Ingo Molnar
> Cc: Amerigo Wang
> Cc: Helight Xu
> Cc: Takashi Iwai
> ---
> drivers/platform/x86/Kconfig | 23 +++
> drivers/platform/x86/thinkpad_acpi.c | 26 ++
At Thu, 24 Dec 2009 16:59:12 -0200,
Henrique de Moraes Holschuh wrote:
>
> On Wed, 23 Dec 2009, Takashi Iwai wrote:
> > At Tue, 22 Dec 2009 17:38:58 -0200,
> > Henrique de Moraes Holschuh wrote:
> > > I won't in this case. I think I will cook up a patch to disable
At Tue, 22 Dec 2009 17:38:58 -0200,
Henrique de Moraes Holschuh wrote:
>
> On Mon, 21 Dec 2009, Randy Dunlap wrote:
> > On Mon, 21 Dec 2009 14:38:56 -0800 Marcel Holtmann wrote:
> > > > > The patch isn't correct (I guess the upstream fix is same?).
> > > > >
> > > > > CONFIG_SOUND is a global con
At Fri, 18 Dec 2009 17:42:34 +0800,
Xiaotian Feng wrote:
>
> Ingo already sent this patch yesterday.
> http://lkml.org/lkml/2009/12/17/25
>
>
> On Fri, Dec 18, 2009 at 5:28 PM, Amerigo Wang wrote:
> >
> > This patch fixes the following build error:
> >
> > Building modules, stage 2.
> > MODPO
At Fri, 18 Dec 2009 12:28:15 -0200,
Henrique de Moraes Holschuh wrote:
>
> On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > The patch isn't correct (I guess the upstream fix is same?).
> >
> > CONFIG_SOUND is a global config for sound subsystem. The relevant
> >
At Fri, 18 Dec 2009 13:03:24 -0200,
Henrique de Moraes Holschuh wrote:
>
> On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > At Fri, 18 Dec 2009 12:28:15 -0200,
> > Henrique de Moraes Holschuh wrote:
> > > On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > > > The pa
At Sat, 10 Mar 2007 00:50:55 -0300,
Henrique de Moraes Holschuh wrote:
>
> On Fri, 09 Mar 2007, Takashi Iwai wrote:
> > > On Wed, 07 Mar 2007, Tobin Davis wrote:
> > > > Another question comes to mind. Why would the volume need to be
> > > > controlled
At Wed, 7 Mar 2007 21:38:06 -0300,
Henrique de Moraes Holschuh wrote:
>
> On Wed, 07 Mar 2007, Tobin Davis wrote:
> > Another question comes to mind. Why would the volume need to be
> > controlled if there is no sound driver to generate sound? I'm trying
> > to understand the usage model here fo
At Mon, 26 Feb 2007 23:14:02 -0300,
Henrique de Moraes Holschuh wrote:
>
> On Mon, 26 Feb 2007, Theodore Tso wrote:
> > thinkpad's real sound card. Otherwise sound applications will have no
> > idea that this separate mixer-only sound card has anything to do with
> > the main speaker output (as c
At Mon, 26 Feb 2007 13:28:19 -0300,
Henrique de Moraes Holschuh wrote:
>
> On Mon, 26 Feb 2007, Takashi Iwai wrote:
> > > The only issue was in userspace, apparently alsamixer ignores VOLATILE
> > > controls and doesn't poll them for updates. I wonder how widespre
I
> am trying to get rid of it, and instead of just porting the interface to
> sysfs attributes, I tried to write a proof-of-concept alsa mixer -- if it is
> a mixer, it should be exported as one, not as some driver-specific sysfs
> attributes, IMHO :-)
>
> It worked almost perfectl
49 matches
Mail list logo
