Re: [ibm-acpi-devel] [PATCH 0/3] Add 3 new keycodes and use them for 3 new hotkeys on new Lenovo Thinkpads

2020-07-26 Thread Henrique de Moraes Holschuh
On Tue, 21 Jul 2020, Dmitry Torokhov wrote: > On Sun, Jul 19, 2020 at 07:56:49PM -0300, Henrique de Moraes Holschuh wrote: > > On Fri, 17 Jul 2020, Hans de Goede wrote: > > > This is a simple patch-series adding support for 3 new hotkeys found > > > on various new Lenovo Thinkpad models. > > > > F

Re: [ibm-acpi-devel] [External] RE: [PATCH] platform/x86: thinkpad_acpi: performance mode interface

2020-07-26 Thread Limonciello, Mario
> > On 7/22/2020 2:46 PM, Limonciello, Mario wrote: > > >> > >> +DYTC Thermal mode status and control > >> + > >> + > >> +sysfs: dytc_perfmode > >> + > >> +Lenovo Thinkpad platforms with DYTC version 5 and newer have enhanced > >> firmware to > >> +provide impr

[ibm-acpi-devel] thinkpad_acpi: unhandled HKEY event 0x6031

2020-07-26 Thread Jiri Kanicky
Hi. I received the following event with Thinkpad X1 Extreme Gen 2, hence reporting it as instructed. Jun 26 18:02:27 superman kernel: thinkpad_acpi: unhandled HKEY event 0x6031 Jun 26 18:02:27 superman kernel: thinkpad_acpi: please report the conditions when this event happened to ibm-acpi-de

Re: [ibm-acpi-devel] [External] RE: [PATCH] platform/x86: thinkpad_acpi: performance mode interface

2020-07-26 Thread Limonciello, Mario
> > > > Since it's not mentioned I can only guess your firmware implementation > associated > > with this code. I would think for example that touching some PLx related > MSR or > > possibly RAPL interface might cause unexpected behaviors. > > > > Assuming that's right kernel lockdown might preven

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: performance mode interface

2020-07-26 Thread Limonciello, Mario
> > Lenovo Thinkpad platforms with DYTC version 5 and newer have enhanced > firmware to provide different performance/thermal modes. > > The modes can be controlled by hotkeys (FN+H, FN+M, FN+L) to switch > the operating mode between three different modes. > > H - High performance. Maximum power

[ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Replace HTTP links with HTTPS ones

2020-07-26 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[ibm-acpi-devel] [v3][PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

2020-07-26 Thread Aaron Ma
When _BCL invalid, disable thinkpad_acpi backlight brightness control. brightness_enable is already checked at the beginning. Most new thinkpads are using GPU driver to control brightness now, print notice when enabled brightness control even when brightness_enable = 1. Signed-off-by: Aaron Ma -

[ibm-acpi-devel] unhandled HKEY event 0x6031 - Thinkpad X1 Extreme 2nd gen 20QV-00C0IX

2020-07-26 Thread Riccardo Cicuto via ibm-acpi-devel
I'm experiencing frequent crashes. The laptop has a dual boot win10/ubuntu20.04, but i work only with Ubuntu. The crash comes always when I re-launch a command to a virtualbox vms from a terminator shell by pressing arrow-up (last command from history) and Enter. Here a slice of system.log: Jul

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

2020-07-26 Thread Aaron Ma
On 7/2/20 5:30 PM, Andy Shevchenko wrote: > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote: >> >> When _BCL invalid, disable thinkpad_acpi backlight brightness control. >> >> brightness_enable is already checked at the beginning, > >> Always print notice when enabled brightness control. > > Why?

[ibm-acpi-devel] [v2][PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

2020-07-26 Thread Aaron Ma
When _BCL invalid, disable thinkpad_acpi backlight brightness control. brightness_enable is already checked at the beginning. Most new thinkpads are using GPU driver to control brightness now, print notice when enabled brightness control even when brightness_enable = 1. Signed-off-by: Aaron Ma -

Re: [ibm-acpi-devel] [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-26 Thread Bastien Nocera
- Original Message - > Newer Lenovo Thinkpad platforms have support to identify whether the > system is on-lap or not using an ACPI DYTC event from the firmware. > > This patch provides the ability to retrieve the current mode via sysfs > entrypoints and will be used by userspace

[ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

2020-07-26 Thread Aaron Ma
When _BCL invalid, disable thinkpad_acpi backlight brightness control. brightness_enable is already checked at the beginning, Always print notice when enabled brightness control. Signed-off-by: Aaron Ma --- drivers/platform/x86/thinkpad_acpi.c | 7 +-- 1 file changed, 5 insertions(+), 2 del

Re: [ibm-acpi-devel] [External] Re: [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-26 Thread Nitin Joshi1
Hello Bastien >-Original Message- >From: Bastien Nocera >- Original Message - >> Newer Lenovo Thinkpad platforms have support to identify whether the >> system is on-lap or not using an ACPI DYTC event from the firmware. >> >> This patch provides the ability to retrieve the c